From: Tony Lindgren <tony@atomide.com>
To: Kees Cook <keescook@chromium.org>
Cc: kernel test robot <lkp@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Keerthy <j-keerthy@ti.com>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Ladislav Michl <ladis@linux-mips.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
linux-omap@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF
Date: Thu, 30 Sep 2021 11:49:45 +0300 [thread overview]
Message-ID: <YVV6KZ7TYhvABjIz@atomide.com> (raw)
In-Reply-To: <20210828175747.3777891-1-keescook@chromium.org>
* Kees Cook <keescook@chromium.org> [210828 17:58]:
> When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
> due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
> CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@intel.com/
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> Cc: Ladislav Michl <ladis@linux-mips.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: linux-omap@vger.kernel.org
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Kees Cook <keescook@chromium.org>
Sorry for the delay, I just noticed I never replied earlier:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..08f8cb944a2a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -24,6 +24,7 @@ config I8253_LOCK
>
> config OMAP_DM_TIMER
> bool
> + select TIMER_OF
>
> config CLKBLD_I8253
> def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-09-30 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 17:57 [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF Kees Cook
2021-09-30 8:49 ` Tony Lindgren [this message]
2021-10-24 15:39 ` [tip: timers/core] " tip-bot2 for Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVV6KZ7TYhvABjIz@atomide.com \
--to=tony@atomide.com \
--cc=daniel.lezcano@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=keescook@chromium.org \
--cc=ladis@linux-mips.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.