From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Mark Brown <broonie@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init()
Date: Thu, 30 Sep 2021 15:41:56 +0200 [thread overview]
Message-ID: <YVW+pLtnipm0/q9o@shikoro> (raw)
In-Reply-To: <20210928140721.8805-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Tue, Sep 28, 2021 at 03:07:18PM +0100, Lad Prabhakar wrote:
> rpcif_sw_init() can fail so make sure we check the return value
> of it and on error exit rpcif_spi_probe() callback with error code.
>
> Fixes: eb8d6d464a27 ("spi: add Renesas RPC-IF driver")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
If it fails, we should really bail out.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-30 13:42 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 14:07 [PATCH 0/6] Add SPI Multi I/O Bus Controller support for RZ/G2L Lad Prabhakar
2021-09-28 14:07 ` Lad Prabhakar
2021-09-28 14:07 ` [PATCH 1/6] dt-bindings: memory: renesas,rpc-if: Add support for the R9A07G044 Lad Prabhakar
2021-09-28 14:07 ` [PATCH 1/6] dt-bindings: memory: renesas, rpc-if: " Lad Prabhakar
2021-10-04 18:30 ` [PATCH 1/6] dt-bindings: memory: renesas,rpc-if: " Rob Herring
2021-10-04 18:30 ` [PATCH 1/6] dt-bindings: memory: renesas, rpc-if: " Rob Herring
2021-10-05 14:46 ` [PATCH 1/6] dt-bindings: memory: renesas,rpc-if: " Geert Uytterhoeven
2021-10-05 14:46 ` [PATCH 1/6] dt-bindings: memory: renesas, rpc-if: " Geert Uytterhoeven
2021-09-28 14:07 ` [PATCH 2/6] dt-bindings: memory: renesas,rpc-if: Add optional interrupts property Lad Prabhakar
2021-09-28 14:07 ` [PATCH 2/6] dt-bindings: memory: renesas, rpc-if: " Lad Prabhakar
2021-09-30 13:39 ` [PATCH 2/6] dt-bindings: memory: renesas,rpc-if: " Wolfram Sang
2021-10-04 18:30 ` Rob Herring
2021-10-04 18:30 ` Rob Herring
2021-10-05 15:11 ` Geert Uytterhoeven
2021-10-05 15:11 ` Geert Uytterhoeven
2021-09-28 14:07 ` [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init() Lad Prabhakar
2021-09-28 14:07 ` Lad Prabhakar
2021-09-30 13:41 ` Wolfram Sang [this message]
2021-10-05 15:25 ` Geert Uytterhoeven
2021-10-05 15:25 ` Geert Uytterhoeven
2021-09-28 14:07 ` [PATCH 4/6] mtd: hyperbus: rpc-if: " Lad Prabhakar
2021-09-28 14:07 ` Lad Prabhakar
2021-09-30 13:42 ` Wolfram Sang
2021-10-08 9:27 ` Geert Uytterhoeven
2021-10-08 9:27 ` Geert Uytterhoeven
2021-09-28 14:07 ` [PATCH 5/6] memory: renesas-rpc-if: Drop usage of RPCIF_DIRMAP_SIZE macro Lad Prabhakar
2021-09-28 14:07 ` Lad Prabhakar
2021-09-30 13:55 ` Wolfram Sang
2021-09-30 14:14 ` Lad, Prabhakar
2021-09-30 14:14 ` Lad, Prabhakar
2021-09-30 14:43 ` Wolfram Sang
2021-09-30 14:43 ` Wolfram Sang
2021-09-28 14:07 ` [PATCH 6/6] memory: renesas-rpc-if: Add support for RZ/G2L Lad Prabhakar
2021-09-28 14:07 ` Lad Prabhakar
2021-09-30 14:40 ` Wolfram Sang
2021-09-30 14:40 ` Wolfram Sang
2021-10-01 8:02 ` Lad, Prabhakar
2021-10-01 8:02 ` Lad, Prabhakar
2021-10-01 8:54 ` Wolfram Sang
2021-10-01 8:54 ` Wolfram Sang
2021-10-01 9:06 ` Lad, Prabhakar
2021-10-01 9:06 ` Lad, Prabhakar
2021-10-01 12:04 ` Wolfram Sang
2021-10-01 12:04 ` Wolfram Sang
2021-10-01 12:53 ` Lad, Prabhakar
2021-10-01 12:53 ` Lad, Prabhakar
2021-10-05 9:14 ` Wolfram Sang
2021-10-05 9:14 ` Wolfram Sang
2021-09-30 15:01 ` [PATCH 0/6] Add SPI Multi I/O Bus Controller " Wolfram Sang
2021-09-30 15:01 ` Wolfram Sang
2021-10-01 8:03 ` Lad, Prabhakar
2021-10-01 8:03 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVW+pLtnipm0/q9o@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.