All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Palmer <daniel@0x0f.com>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused
Date: Thu, 30 Sep 2021 18:23:53 +0300	[thread overview]
Message-ID: <YVXWiQWGkzmp6O1A@smile.fi.intel.com> (raw)
In-Reply-To: <20210930124950.3069638-1-daniel@0x0f.com>

On Thu, Sep 30, 2021 at 09:49:50PM +0900, Daniel Palmer wrote:
> When building kernels without ACPI support the table is declared
> but is not used because ACPI_PTR() turns it into a NULL.

Okay.

> Add the __maybe_unused attribute to stop the compiler whining.

And incorrect fix. See my patches regarding to the topic
(`git log --grep ACPI_PTR`) and do accordingly, i.e. drop
ACPI_PTR() for good.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-09-30 15:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 12:49 [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused Daniel Palmer
2021-09-30 15:23 ` Andy Shevchenko [this message]
2021-09-30 15:31   ` Daniel Palmer
2021-09-30 21:04     ` Andy Shevchenko
2021-10-01  0:16       ` Daniel Palmer
2021-10-05 12:14         ` Andy Shevchenko
2021-10-05 12:41           ` Daniel Palmer
2021-10-06 16:01             ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVXWiQWGkzmp6O1A@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=daniel@0x0f.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.