From: Petr Vorel <petr.vorel@gmail.com>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 2/2] lapi/if_addr.h: Define IFA_FLAGS
Date: Thu, 30 Sep 2021 19:17:01 +0200 [thread overview]
Message-ID: <YVXwjNU3MbZxmxWq@pevik> (raw)
In-Reply-To: <17c1aab9-6c53-f1ec-692d-735721eb9290@suse.cz>
Hi Martin
,
> > +++ b/include/lapi/if_addr.h
> > @@ -8,6 +8,10 @@
> > #include <linux/if_addr.h>
> > +#ifndef IFA_FLAGS
> > +# define IFA_FLAGS 8
> > +#endif
> I don't understand why the move of IFA_FLAGS from lapi/rtnetlink.h to
> lapi/if_addr.h is split into two separate patches. IFA_FLAGS is required
> for compiling tst_netdevice.c so this patchset is not very bisect-friendly.
Ah, good catch, thank you. Silly error I mixed up IFA_F_NOPREFIXROUTE and IFA_FLAGS => v2.
Kind regards,
Petr
> > +
> > #ifndef IFA_F_NOPREFIXROUTE
> > # define IFA_F_NOPREFIXROUTE 0x200
> > #endif
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2021-09-30 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 18:17 [LTP] [RFC PATCH 0/2] Fix old toolchain (< v3.14) Petr Vorel
2021-09-29 18:17 ` [LTP] [RFC PATCH 1/2] lapi: Create if_addr.h and reuse it in rtnetlink.h Petr Vorel
2021-09-29 18:17 ` [LTP] [RFC PATCH 2/2] lapi/if_addr.h: Define IFA_FLAGS Petr Vorel
2021-09-30 11:17 ` Martin Doucha
2021-09-30 17:17 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVXwjNU3MbZxmxWq@pevik \
--to=petr.vorel@gmail.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.