From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: <xen-devel@lists.xenproject.org>,
Anthony PERARD <anthony.perard@gmail.com>,
Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [XEN PATCH 2/2] automation: Add qemu to debian:stretch container for smoke test
Date: Fri, 1 Oct 2021 09:21:46 +0100 [thread overview]
Message-ID: <YVbFGqWEMIVyr1JY@perard> (raw)
In-Reply-To: <c242d263-25e1-1540-419b-11c74b2719d5@citrix.com>
On Thu, Sep 30, 2021 at 06:05:44PM +0100, Andrew Cooper wrote:
> On 30/09/2021 17:17, Anthony PERARD wrote:
> > --- a/automation/scripts/qemu-smoke-x86-64.sh
> > +++ b/automation/scripts/qemu-smoke-x86-64.sh
> > @@ -6,9 +6,11 @@ set -ex
> > variant=$1
> >
> > # Install QEMU
> > -export DEBIAN_FRONTENT=noninteractive
> > -apt-get -qy update
> > -apt-get -qy install qemu-system-x86
> > +if ! type qemu-system-x86_64; then
> > + export DEBIAN_FRONTENT=noninteractive
> > + apt-get -qy update
> > + apt-get -qy install qemu-system-x86
> > +fi
>
> I'd just delete this all. It's wrong for running smoke tests in other
> containers anyway.
>
> Can fix commit too.
Sounds good, thanks. In that case, I need to push the updated container
before we commit the patch.
Cheers,
--
Anthony PERARD
prev parent reply other threads:[~2021-10-01 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 16:17 [XEN PATCH 0/2] Fixing gitlab CI tests Anthony PERARD
2021-09-30 16:17 ` [XEN PATCH 1/2] automation: switch GitLab x86 smoke test to use PV 64bit binary Anthony PERARD
2021-09-30 16:20 ` Andrew Cooper
2021-09-30 16:29 ` Anthony PERARD
2021-09-30 16:17 ` [XEN PATCH 2/2] automation: Add qemu to debian:stretch container for smoke test Anthony PERARD
2021-09-30 17:05 ` Andrew Cooper
2021-10-01 8:21 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVbFGqWEMIVyr1JY@perard \
--to=anthony.perard@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@gmail.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.