From: Greg Kroah-Hartman <firstname.lastname@example.org>
To: Andy Shevchenko <email@example.com>
Cc: Reinette Chatre <firstname.lastname@example.org>,
Shuo Liu <email@example.com>, Zhi Wang <firstname.lastname@example.org>,
email@example.com, Fei Li <firstname.lastname@example.org>
Subject: Re: [PATCH v1 1/1] virt: acrn: Drop internal kernel type from ABI
Date: Fri, 1 Oct 2021 17:10:10 +0200 [thread overview]
Message-ID: <YVck0pu9wkUM++Rf@kroah.com> (raw)
On Fri, Oct 01, 2021 at 05:58:49PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 01, 2021 at 04:01:41PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 01, 2021 at 04:56:44PM +0300, Andy Shevchenko wrote:
> > > guid_t is internal type of the kernel which is mistakenly had been exposed
> > > to the user space. Replace it with raw buffers.
> > Wait, why is it a mistake to expose it to userspace? What does this
> > conflict with? Is it a namespace issue? Or something else?
> It is the type which is defined solely for kernel use and what user space
> should do is to use types defined by respective libraries, such as libuuid.
But that does not work here. We want to expose a common uuid type that
userspace can use in these structures, as well as the kernel. Do you
really want to "open code" arrays all over the place?
> If you read the commit message to the end, you will notice that I have
> mentioned the possible scenario what happened here. They seems misusing
> guid_t as uuid_t, but the latter is not available for the users from
> the kernel headers (and this is good). So this is an exact example why
> guid_t shouldn't be exposed.
Then we should create a type that we can use here. The kernel can not
use libuuid, so what is wrong with using the kernel variable type
namespace for this? __guid? __uuid?
next prev parent reply other threads:[~2021-10-01 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 13:56 [PATCH v1 1/1] virt: acrn: Drop internal kernel type from ABI Andy Shevchenko
2021-10-01 14:01 ` Greg Kroah-Hartman
2021-10-01 14:58 ` Andy Shevchenko
2021-10-01 15:10 ` Greg Kroah-Hartman [this message]
2021-12-13 20:18 ` Andy Shevchenko
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.