All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Orlando Chamberlain <redecorating@protonmail.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART
Date: Sat, 2 Oct 2021 14:04:30 +0300	[thread overview]
Message-ID: <YVg8vsdU89wjC9/7@smile.fi.intel.com> (raw)
In-Reply-To: <20211002032810.3729-1-redecorating@protonmail.com>

On Sat, Oct 02, 2021 at 03:31:07AM +0000, Orlando Chamberlain wrote:
> Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake
> PCH-N UART controler present on the MacBookPro16,2.

You ignoring my Reviewed-by tag. Any reason why?

Besides that you are posting patches as continuation of the thread. It may be
problematic for some tools, like `b4`, although I dunno if Lee is using such
tools.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
> ---
> v2->v3: Mention "ICL-N" in commit message.
>  drivers/mfd/intel-lpss-pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index c54d19fb184c..a872b4485eac 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
>  	{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
> +	/* ICL-N */
> +	{ PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
>  	/* TGL-H */
>  	{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
>  	{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
> -- 
> 2.33.0
> 
> 

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-10-02 11:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  8:51 [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART Orlando Chamberlain
2021-10-01 10:16 ` Andy Shevchenko
2021-10-01 10:40   ` [PATCHv2] " Orlando Chamberlain
2021-10-01 11:04     ` Andy Shevchenko
2021-10-01 18:14   ` [PATCH] " Lee Jones
2021-10-01 18:22     ` Andy Shevchenko
2021-10-02  3:31       ` [PATCHv3] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Orlando Chamberlain
2021-10-02 11:04         ` Andy Shevchenko [this message]
2021-10-02 11:12           ` Orlando Chamberlain
2021-10-02 12:07             ` Andy Shevchenko
2021-10-04  6:53             ` Lee Jones
2021-10-04  7:16       ` [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART Lee Jones
2021-10-02 11:16 ` [PATCHv4] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART Orlando Chamberlain
2021-10-04  7:17   ` Lee Jones
2021-10-04 15:58     ` Aditya Garg
2021-10-04 16:10       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVg8vsdU89wjC9/7@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=redecorating@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.