From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF00C433EF for ; Sat, 2 Oct 2021 17:24:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A684361A7D for ; Sat, 2 Oct 2021 17:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A684361A7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3DB2A6B006C; Sat, 2 Oct 2021 13:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38B6C900002; Sat, 2 Oct 2021 13:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20DC46B0072; Sat, 2 Oct 2021 13:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 0F00D6B006C for ; Sat, 2 Oct 2021 13:24:32 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C4C3539476 for ; Sat, 2 Oct 2021 17:24:31 +0000 (UTC) X-FDA: 78652171542.08.F7C0D90 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf05.hostedemail.com (Postfix) with ESMTP id 7CD49506F661 for ; Sat, 2 Oct 2021 17:24:31 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id 145so10809395pfz.11 for ; Sat, 02 Oct 2021 10:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D1bXkBk9YxmebFeA6E0BW5aK15Kg0BQ6ZYq9gHvLf8I=; b=bD7c6t/HirAEIz+/PxtC8eGDtvg1LK+3UlvnvIzjRphISe/ujCdscLeEaYSqGdB2cj JceH5o9k+buUK9BNbOFXYeSR6DHP8ur+gBgb3eBAUsRAu2yqdnuBuRC/DMXAkD3ty/RE BKJFJIER/2X0fKhIho35yK3irtEi8Cr1Ru59ywzHmKOD6NQHYnBqMsP3yYZi6nVszfMo yxXeTDn2azo9UfL+g1crhi6VQX939ULcMfw+t4q8pLQ+UwAB9cCtQp0MiV/yoQL4nr1H Q17zkMpwJTeP2iFQKAU9BbhXTjeExEr8SMlR20wT94Rx1kUGfpINHmZLFEM6wdRtfFRp kbgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D1bXkBk9YxmebFeA6E0BW5aK15Kg0BQ6ZYq9gHvLf8I=; b=TbXI6t+V7+24Th5FTLenunljY5qBcWUuMgOApRbMPoefPg3N4oP23u4ZjlngogEjhV Hne/tmoKFf9aZZlVpcJwSs8Xk7PWTz851hvvbgFh6ePgEKvnD7f6xodzePPUwKajV22I eW5y9sS30ntviTSWokAQPmVyUscuPdcmOy2sgrnfd/7l9PireeaApgJksm14ZZG8S69n wL76D6rNYJlJuLANRTOcCqfm/t6lUhCTu8FJDcNITv0rjBB1eR/DjQQCVlkEyvCSxQhV Gpk7qgvva7+JjWs5HSoP48EA6qYdg6O8A8XYw2Ocs6G7hEeO49HU8Pi6cVoj7uMAJ+/p 3gBg== X-Gm-Message-State: AOAM532xOT1WFT5jGqXT8a4HJIb0iwDS5UdCOdDYpNSpQG6dg6a7N5lz PF6TcVGLI9jjLB0KMWi7yDY= X-Google-Smtp-Source: ABdhPJx5joTF1gNiWd6ZXwTh3t1fPMuPaA4tteEBIL9LThUASubI0TivX6vd9CDwEQL/39E2/PqcBw== X-Received: by 2002:a63:131f:: with SMTP id i31mr3665877pgl.207.1633195470271; Sat, 02 Oct 2021 10:24:30 -0700 (PDT) Received: from localhost (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id ch7sm10714708pjb.44.2021.10.02.10.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 10:24:29 -0700 (PDT) Date: Sat, 2 Oct 2021 10:24:31 -0700 From: Yury Norov To: Geert Uytterhoeven Cc: Stephen Rothwell , Andrew Morton , Linux Kernel Mailing List , Linux MM , Linux-Arch , "open list:KERNEL SELFTEST FRAMEWORK" , Linux MMC List , linux-perf-users@vger.kernel.org, KVM list , "James E.J. Bottomley" , Alexander Lobakin , Alexander Shishkin , Alexey Klimov , Andrea Merello , Andy Shevchenko , Arnaldo Carvalho de Melo , Arnd Bergmann , Ben Gardon , Benjamin Herrenschmidt , Brian Cain , Catalin Marinas , Christoph Lameter , Daniel Bristot de Oliveira , David Hildenbrand , Dennis Zhou , Heiko Carstens , Ian Rogers , Ingo Molnar , Jaegeuk Kim , Jakub Kicinski , Jiri Olsa , Joe Perches , Jonas Bonn , Leo Yan , Mark Rutland , Namhyung Kim , Palmer Dabbelt , Paolo Bonzini , Peter Xu , Peter Zijlstra , Petr Mladek , Rasmus Villemoes , Rich Felker , Samuel Mendoza-Jonas , Sean Christopherson , Sergey Senozhatsky , Shuah Khan , Stefan Kristiansson , Steven Rostedt , Tejun Heo , Thomas Bogendoerfer , Ulf Hansson , Will Deacon , Wolfram Sang , Yoshinori Sato Subject: Re: [PATCH 03/16] include: move find.h from asm_generic to linux Message-ID: References: <20211001181245.228419-1-yury.norov@gmail.com> <20211001181245.228419-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7CD49506F661 X-Stat-Signature: nczqqhrdysumbr4jpamk7qdkq4ii97yr Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="bD7c6t/H"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=yury.norov@gmail.com X-HE-Tag: 1633195471-477451 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 02, 2021 at 11:23:26AM +0200, Geert Uytterhoeven wrote: > Hi Yuri, > > Thanks for your patch! > > On Fri, Oct 1, 2021 at 8:12 PM Yury Norov wrote: > > find_bit API and bitmap API are closely related, but inclusion paths > > are different - include/asm-generic and include/linux, correspondingly. > > In the past it made a lot of troubles due to circular dependencies > > and/or undefined symbols. Fix this by moving find.h under include/linux. > > .. and including it from include/linux/bitmap.h, like the other helper includes? yes. > > Signed-off-by: Yury Norov > > Tested-by: Wolfram Sang > > > arch/m68k/include/asm/bitops.h | 2 -- > > Acked-by: Geert Uytterhoeven > > > --- a/include/linux/bitmap.h > > +++ b/include/linux/bitmap.h > > @@ -6,6 +6,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03501C433EF for ; Sat, 2 Oct 2021 17:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBCF861AE0 for ; Sat, 2 Oct 2021 17:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233707AbhJBR1h (ORCPT ); Sat, 2 Oct 2021 13:27:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233739AbhJBR0R (ORCPT ); Sat, 2 Oct 2021 13:26:17 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF939C0613EC; Sat, 2 Oct 2021 10:24:31 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id h1so126296pfv.12; Sat, 02 Oct 2021 10:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D1bXkBk9YxmebFeA6E0BW5aK15Kg0BQ6ZYq9gHvLf8I=; b=bD7c6t/HirAEIz+/PxtC8eGDtvg1LK+3UlvnvIzjRphISe/ujCdscLeEaYSqGdB2cj JceH5o9k+buUK9BNbOFXYeSR6DHP8ur+gBgb3eBAUsRAu2yqdnuBuRC/DMXAkD3ty/RE BKJFJIER/2X0fKhIho35yK3irtEi8Cr1Ru59ywzHmKOD6NQHYnBqMsP3yYZi6nVszfMo yxXeTDn2azo9UfL+g1crhi6VQX939ULcMfw+t4q8pLQ+UwAB9cCtQp0MiV/yoQL4nr1H Q17zkMpwJTeP2iFQKAU9BbhXTjeExEr8SMlR20wT94Rx1kUGfpINHmZLFEM6wdRtfFRp kbgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D1bXkBk9YxmebFeA6E0BW5aK15Kg0BQ6ZYq9gHvLf8I=; b=0UNITr5eyIip/TO9bOJ/g/xAAccRGaRr8rjXSU0Ri/IMT0ohCu1F4v73HyVPS8Qhar /wbYTbjn5wjS5TcbFzAKf91E+F01plNewRwhw0NHl9DQeq/o3pnNBEgACk93VBLweV0G UOmaHVv5gs7WVEqqkg6hO8zD9khevZBIn0/MkWySBEkTb7PPenkBdtTHglwQF91skboq v+e+qY3BBn3HwiRkknDTyAKYwIadrSZBoPKVaD6lqeNPIVb0JK499EgLscJaEOHDWCmG goWtNgRac2oZoWi7xPgFMnhUpkCwZituc8HXDEuC25p/1whNqf0o4HsK6ZlV+DVj5Lfu 0iRg== X-Gm-Message-State: AOAM533ifFVAhrlepNY97KbdqQgdtmk2/NWf5hl4b4XkH7JhpKnVzakH s1MoJ51bBrwd6XnxlRmOVuA= X-Google-Smtp-Source: ABdhPJx5joTF1gNiWd6ZXwTh3t1fPMuPaA4tteEBIL9LThUASubI0TivX6vd9CDwEQL/39E2/PqcBw== X-Received: by 2002:a63:131f:: with SMTP id i31mr3665877pgl.207.1633195470271; Sat, 02 Oct 2021 10:24:30 -0700 (PDT) Received: from localhost (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id ch7sm10714708pjb.44.2021.10.02.10.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 10:24:29 -0700 (PDT) Date: Sat, 2 Oct 2021 10:24:31 -0700 From: Yury Norov To: Geert Uytterhoeven Cc: Stephen Rothwell , Andrew Morton , Linux Kernel Mailing List , Linux MM , Linux-Arch , "open list:KERNEL SELFTEST FRAMEWORK" , Linux MMC List , linux-perf-users@vger.kernel.org, KVM list , "James E.J. Bottomley" , Alexander Lobakin , Alexander Shishkin , Alexey Klimov , Andrea Merello , Andy Shevchenko , Arnaldo Carvalho de Melo , Arnd Bergmann , Ben Gardon , Benjamin Herrenschmidt , Brian Cain , Catalin Marinas , Christoph Lameter , Daniel Bristot de Oliveira , David Hildenbrand , Dennis Zhou , Heiko Carstens , Ian Rogers , Ingo Molnar , Jaegeuk Kim , Jakub Kicinski , Jiri Olsa , Joe Perches , Jonas Bonn , Leo Yan , Mark Rutland , Namhyung Kim , Palmer Dabbelt , Paolo Bonzini , Peter Xu , Peter Zijlstra , Petr Mladek , Rasmus Villemoes , Rich Felker , Samuel Mendoza-Jonas , Sean Christopherson , Sergey Senozhatsky , Shuah Khan , Stefan Kristiansson , Steven Rostedt , Tejun Heo , Thomas Bogendoerfer , Ulf Hansson , Will Deacon , Wolfram Sang , Yoshinori Sato Subject: Re: [PATCH 03/16] include: move find.h from asm_generic to linux Message-ID: References: <20211001181245.228419-1-yury.norov@gmail.com> <20211001181245.228419-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 02, 2021 at 11:23:26AM +0200, Geert Uytterhoeven wrote: > Hi Yuri, > > Thanks for your patch! > > On Fri, Oct 1, 2021 at 8:12 PM Yury Norov wrote: > > find_bit API and bitmap API are closely related, but inclusion paths > > are different - include/asm-generic and include/linux, correspondingly. > > In the past it made a lot of troubles due to circular dependencies > > and/or undefined symbols. Fix this by moving find.h under include/linux. > > .. and including it from include/linux/bitmap.h, like the other helper includes? yes. > > Signed-off-by: Yury Norov > > Tested-by: Wolfram Sang > > > arch/m68k/include/asm/bitops.h | 2 -- > > Acked-by: Geert Uytterhoeven > > > --- a/include/linux/bitmap.h > > +++ b/include/linux/bitmap.h > > @@ -6,6 +6,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds