From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
stable@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 01/10] regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS is disabled
Date: Mon, 4 Oct 2021 09:30:15 -0500 [thread overview]
Message-ID: <YVsP96GK9SJFRDkI@robh.at.kernel.org> (raw)
In-Reply-To: <20211001094106.52412-2-krzysztof.kozlowski@canonical.com>
On Fri, 01 Oct 2021 11:40:57 +0200, Krzysztof Kozlowski wrote:
> The driver and its bindings, before commit 04f9f068a619 ("regulator:
> s5m8767: Modify parsing method of the voltage table of buck2/3/4") were
> requiring to provide at least one safe/default voltage for DVS registers
> if DVS GPIO is not being enabled.
>
> IOW, if s5m8767,pmic-buck2-uses-gpio-dvs is missing, the
> s5m8767,pmic-buck2-dvs-voltage should still be present and contain one
> voltage.
>
> This requirement was coming from driver behavior matching this condition
> (none of DVS GPIO is enabled): it was always initializing the DVS
> selector pins to 0 and keeping the DVS enable setting at reset value
> (enabled). Therefore if none of DVS GPIO is enabled in devicetree,
> driver was configuring the first DVS voltage for buck[234].
>
> Mentioned commit 04f9f068a619 ("regulator: s5m8767: Modify parsing
> method of the voltage table of buck2/3/4") broke it because DVS voltage
> won't be parsed from devicetree if DVS GPIO is not enabled. After the
> change, driver will configure bucks to use the register reset value as
> voltage which might have unpleasant effects.
>
> Fix this by relaxing the bindings constrain: if DVS GPIO is not enabled
> in devicetree (therefore DVS voltage is also not parsed), explicitly
> disable it.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 04f9f068a619 ("regulator: s5m8767: Modify parsing method of the voltage table of buck2/3/4")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> .../bindings/regulator/samsung,s5m8767.txt | 21 +++++++------------
> drivers/regulator/s5m8767.c | 21 ++++++++-----------
> 2 files changed, 17 insertions(+), 25 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-10-04 14:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 9:40 [PATCH v2 00/10] regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema Krzysztof Kozlowski
2021-10-01 9:40 ` [PATCH v2 01/10] regulator: s5m8767: do not use reset value as DVS voltage if GPIO DVS is disabled Krzysztof Kozlowski
2021-10-04 14:30 ` Rob Herring [this message]
2021-10-01 9:40 ` [PATCH v2 02/10] regulator: dt-bindings: samsung,s5m8767: correct s5m8767,pmic-buck-default-dvs-idx property Krzysztof Kozlowski
2021-10-04 14:30 ` Rob Herring
2021-10-01 9:40 ` [PATCH v2 03/10] dt-bindings: clock: samsung,s2mps11: convert to dtschema Krzysztof Kozlowski
2021-10-04 14:32 ` Rob Herring
2021-10-08 1:00 ` Stephen Boyd
2021-10-01 9:41 ` [PATCH v2 04/10] regulator: dt-bindings: samsung,s2m: " Krzysztof Kozlowski
2021-10-04 14:34 ` Rob Herring
2021-10-01 9:41 ` [PATCH v2 05/10] regulator: dt-bindings: samsung,s2mpa01: " Krzysztof Kozlowski
2021-10-04 14:35 ` Rob Herring
2021-10-01 9:41 ` [PATCH v2 06/10] regulator: dt-bindings: samsung,s5m8767: " Krzysztof Kozlowski
2021-10-04 14:41 ` Rob Herring
2021-10-04 14:48 ` Krzysztof Kozlowski
2021-10-01 9:41 ` [PATCH v2 07/10] dt-bindings: mfd: samsung,s2mps11: " Krzysztof Kozlowski
2021-10-04 14:42 ` Rob Herring
2021-10-01 9:41 ` [PATCH v2 08/10] dt-bindings: mfd: samsung,s2mpa01: " Krzysztof Kozlowski
2021-10-04 14:43 ` Rob Herring
2021-10-01 9:41 ` [PATCH v2 09/10] dt-bindings: mfd: samsung,s5m8767: " Krzysztof Kozlowski
2021-10-01 11:18 ` Krzysztof Kozlowski
2021-10-04 14:49 ` Rob Herring
2021-10-01 9:41 ` [PATCH v2 10/10] dt-bindings: mfd: samsung,s5m8767: document buck and LDO supplies Krzysztof Kozlowski
2021-10-04 14:50 ` Rob Herring
2021-10-05 12:14 ` [PATCH v2 00/10] regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema Mark Brown
2021-10-05 13:14 ` Lee Jones
2021-10-06 12:55 ` Krzysztof Kozlowski
2021-10-06 13:20 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVsP96GK9SJFRDkI@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.