From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1348C433EF for ; Mon, 4 Oct 2021 19:20:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81D6461163 for ; Mon, 4 Oct 2021 19:20:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 81D6461163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C82BE6E02B; Mon, 4 Oct 2021 19:20:27 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC36B6E02B for ; Mon, 4 Oct 2021 19:20:26 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="205675001" X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="205675001" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 11:38:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="521530295" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga001.jf.intel.com with SMTP; 04 Oct 2021 11:38:48 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 04 Oct 2021 21:38:47 +0300 Date: Mon, 4 Oct 2021 21:38:47 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Gupta, Anshuman" Cc: "intel-gfx@lists.freedesktop.org" , Sean Paul , "C, Ramalingam" , "B S, Karthik" , "Nautiyal, Ankit K" Message-ID: References: <9078bb70f03e41738043771fb1d89ff3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9078bb70f03e41738043771fb1d89ff3@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] i915 MST HDCP code looks broken X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Oct 04, 2021 at 03:04:01PM +0000, Gupta, Anshuman wrote: > > > > -----Original Message----- > > From: Ville Syrjälä > > Sent: Monday, October 4, 2021 4:22 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Sean Paul ; Gupta, Anshuman > > ; C, Ramalingam ; B S, > > Karthik > > Subject: i915 MST HDCP code looks broken > > > > Hi, > > > > I took a quick peek at intel_dp_add_mst_connector() the other day and noticed > > that it calls intel_dp_hdcp_init() and passes in the SST dig_port. And digging in a > > bit further that seems to clobber all kinds of things in dig_port->hdcp_port_data. > > This looks rather broken to me. > > > > So has anyone actually thought what happens if you first use MST on the port, > > and then later switch to SST on the same port? > AFAIU there shouldn't be , when the last connector of MST topology get destroyed and it switches to SST mode on same port. > The base static connector of same dig_port should get connected and will call intel_dp_init_connector()->intel_dp_hdcp_init(). SST conectors are static. They are created exactly once when the driver loads. -- Ville Syrjälä Intel