All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: linux-usb@vger.kernel.org,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>,
	Felipe Balbi <balbi@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Jack Pham <jackp@codeaurora.org>
Subject: Re: [PATCH] usb: gadget: u_audio.c: Adding Playback Pitch ctl for sync playback
Date: Tue, 5 Oct 2021 13:31:07 +0200	[thread overview]
Message-ID: <YVw3e1zOS2QvKiM0@kroah.com> (raw)
In-Reply-To: <20210925143003.12476-1-pavel.hofman@ivitera.com>

On Sat, Sep 25, 2021 at 04:30:03PM +0200, Pavel Hofman wrote:
> EP IN is hard-coded as ASYNC both in f_uac1 and f_uac2 but u_audio sends
> steady number of audio frames in each USB packet, without any control.
> 
> This patch adds 'Playback Pitch 1000000' ctl analogous to the existing
> 'Capture Pitch 1000000' ctl. The calculation of playback req->length in
> u_audio_iso_complete respects the Playback Pitch ctl value to 1ppm now.
> 
> Max. value for Playback Pitch is configured by the existing parameter
> uac2_opts->fb_max, used also for the Capture Pitch.
> 
> Since the EP IN packet size can be increased by uac2_opts->fb_max now,
> maxPacketSize for the playback direction is calculated by the same
> algorithm as for the async capture direction in
> f_uac2.c:set_ep_max_packet_size.
> 
> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> ---
>  drivers/usb/gadget/function/f_uac2.c  |  5 +-
>  drivers/usb/gadget/function/u_audio.c | 93 ++++++++++++++++++++-------
>  2 files changed, 74 insertions(+), 24 deletions(-)

Does not apply to my tree, what kernel release / branch did you make
this against?

thanks,

greg k-h

  reply	other threads:[~2021-10-05 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25 14:30 [PATCH] usb: gadget: u_audio.c: Adding Playback Pitch ctl for sync playback Pavel Hofman
2021-10-05 11:31 ` Greg KH [this message]
2021-10-06  6:43   ` Pavel Hofman
2021-10-06  7:34     ` Greg KH
2021-10-06  7:40       ` Pavel Hofman
2021-10-06  7:45         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVw3e1zOS2QvKiM0@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=jackp@codeaurora.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel.hofman@ivitera.com \
    --cc=ruslan.bilovol@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.