From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DB1C433EF for ; Tue, 5 Oct 2021 08:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2DA461507 for ; Tue, 5 Oct 2021 08:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232772AbhJEIGL (ORCPT ); Tue, 5 Oct 2021 04:06:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28651 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232793AbhJEIGK (ORCPT ); Tue, 5 Oct 2021 04:06:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633421060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vtULx88xAOp/JsicdkATYnwFMV/hB6VPvYC999jApo8=; b=gFzTspHhC2bk/Wbc+oD/AqwlgTsgf0GNC4xiMvRHU2d44ihuSN7ZV3FJF4K1weH+IZvvRO R+5Zuob35ljVJAxQuFgDv0gGZnpT826mIGSXKc1dti4vRxg1PkegN/ZDo9KK1GG2qXAcoJ 1mGiym8/IzrdXqaZ75ndF23xHZlmn4U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-8fu__61VMtOhSr-PMRLRiw-1; Tue, 05 Oct 2021 04:04:16 -0400 X-MC-Unique: 8fu__61VMtOhSr-PMRLRiw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 140611842158; Tue, 5 Oct 2021 08:04:15 +0000 (UTC) Received: from T590 (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F88E60C17; Tue, 5 Oct 2021 08:04:10 +0000 (UTC) Date: Tue, 5 Oct 2021 16:04:06 +0800 From: Ming Lei To: Chaitanya Kulkarni Cc: Jens Axboe , Christoph Hellwig , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Sagi Grimberg , Keith Busch Subject: Re: [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue Message-ID: References: <20210930125621.1161726-1-ming.lei@redhat.com> <20210930125621.1161726-2-ming.lei@redhat.com> <95d25bd6-f632-67cc-657e-5158c6412256@nvidia.com> <79efb733-4904-d27f-b336-d5d97d3ca261@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79efb733-4904-d27f-b336-d5d97d3ca261@nvidia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Oct 05, 2021 at 03:38:18AM +0000, Chaitanya Kulkarni wrote: > On 10/4/21 19:23, Ming Lei wrote: > > External email: Use caution opening links or attachments > > > > > > Hello Chaitanya, > > > > On Fri, Oct 01, 2021 at 05:56:04AM +0000, Chaitanya Kulkarni wrote: > >> On 9/30/2021 5:56 AM, Ming Lei wrote: > >>> External email: Use caution opening links or attachments > >>> > >>> > >>> Add two APIs for stopping and starting admin queue. > >>> > >>> Signed-off-by: Ming Lei > >> > >> > >> this patch looks good to me, but from the feedback I've received in past > >> we need to add the new functions in the patch where they are actually > >> used than adding it in a separate patch. > > > > The added two APIs are exported via EXPORT_SYMBOL_GPL(), so it won't > > cause any build warning. I see lots of such practise too. > > > > the comment was not related to any build or warning. > > > It is easier for reviewing in this way since the 1st patch focuses on > > API implementation, and the 2nd patch focuses on using the API, > > especially there are lots of users in patch 2. > > > > I am aware of that, just sharing what I got the comments in the past. > > > But if you really don't like this way, I am fine to merge the two since > > merging is always easier than splitting, :-) > > > > it will be good if we can keep the consistency ... nothing else .. OK, got it, and the latest such nvme patch is the following one, which introduced an API in one standalone patch. commit dda3248e7fc306e0ce3612ae96bdd9a36e2ab04f Author: Chao Leng Date: Thu Feb 4 08:55:11 2021 +0100 nvme: introduce a nvme_host_path_error helper Thanks Ming From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61899C433EF for ; Tue, 5 Oct 2021 08:05:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F03F610EA for ; Tue, 5 Oct 2021 08:05:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F03F610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=STjyFMp7Pj741GmPDdz6eThYGi9PeYfc84RY3j2cM3I=; b=3xvigea2OHLj0x jj0mKXAC+DPwx25vUJ6SMmvwnGCBv8WpqVUBj4MLiVXEz86j3kWTbWzdVvjTcGNTBal9vR3bN0cPy lTZNt//sOi8yY75MwliDXxfjZ+yRvVccdOcZXuq4KiZuX7DLRp6B0i4fuazRm3jDi/uBM8oKphAS8 BJrZyEEhpDmbk+YJCr60vkBHsQAbYCfl7HPoGku78xMIrRVZE0Xkd/uZSJJWRKS75/x9qiO7rZYbL 6oDpHLzIBglC0oSqIu2nvqA6dvnPewjOYL++CDF+i3xMc9sWSBDXbUM+9AVN/9Vnq8eyNjVvccRzh yyytv2luiZB/SfQDqrFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXfRo-009T6o-M3; Tue, 05 Oct 2021 08:05:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXfQx-009T5G-Ed for linux-nvme@lists.infradead.org; Tue, 05 Oct 2021 08:04:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633421058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vtULx88xAOp/JsicdkATYnwFMV/hB6VPvYC999jApo8=; b=JSk7PFpS80G3NFN3RFjUWXLPKPW0CGeq10kZo5k6bSzoHZa8NdwyOILeaULmtD/anYIUNq mFctHj+fU3vsep6xTzsZixPpkv6gYGiuOVcatNg1pqkFrMpdu0Tc0FyXAkchdBlRoks8jw 7wlhGgIiRCp1r6jI1st9rD/FtCPDL9Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-8fu__61VMtOhSr-PMRLRiw-1; Tue, 05 Oct 2021 04:04:16 -0400 X-MC-Unique: 8fu__61VMtOhSr-PMRLRiw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 140611842158; Tue, 5 Oct 2021 08:04:15 +0000 (UTC) Received: from T590 (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F88E60C17; Tue, 5 Oct 2021 08:04:10 +0000 (UTC) Date: Tue, 5 Oct 2021 16:04:06 +0800 From: Ming Lei To: Chaitanya Kulkarni Cc: Jens Axboe , Christoph Hellwig , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Sagi Grimberg , Keith Busch Subject: Re: [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue Message-ID: References: <20210930125621.1161726-1-ming.lei@redhat.com> <20210930125621.1161726-2-ming.lei@redhat.com> <95d25bd6-f632-67cc-657e-5158c6412256@nvidia.com> <79efb733-4904-d27f-b336-d5d97d3ca261@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <79efb733-4904-d27f-b336-d5d97d3ca261@nvidia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_010419_701481_19201E39 X-CRM114-Status: GOOD ( 31.06 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Oct 05, 2021 at 03:38:18AM +0000, Chaitanya Kulkarni wrote: > On 10/4/21 19:23, Ming Lei wrote: > > External email: Use caution opening links or attachments > > > > > > Hello Chaitanya, > > > > On Fri, Oct 01, 2021 at 05:56:04AM +0000, Chaitanya Kulkarni wrote: > >> On 9/30/2021 5:56 AM, Ming Lei wrote: > >>> External email: Use caution opening links or attachments > >>> > >>> > >>> Add two APIs for stopping and starting admin queue. > >>> > >>> Signed-off-by: Ming Lei > >> > >> > >> this patch looks good to me, but from the feedback I've received in past > >> we need to add the new functions in the patch where they are actually > >> used than adding it in a separate patch. > > > > The added two APIs are exported via EXPORT_SYMBOL_GPL(), so it won't > > cause any build warning. I see lots of such practise too. > > > > the comment was not related to any build or warning. > > > It is easier for reviewing in this way since the 1st patch focuses on > > API implementation, and the 2nd patch focuses on using the API, > > especially there are lots of users in patch 2. > > > > I am aware of that, just sharing what I got the comments in the past. > > > But if you really don't like this way, I am fine to merge the two since > > merging is always easier than splitting, :-) > > > > it will be good if we can keep the consistency ... nothing else .. OK, got it, and the latest such nvme patch is the following one, which introduced an API in one standalone patch. commit dda3248e7fc306e0ce3612ae96bdd9a36e2ab04f Author: Chao Leng Date: Thu Feb 4 08:55:11 2021 +0100 nvme: introduce a nvme_host_path_error helper Thanks Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme