From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F7AC433F5 for ; Tue, 5 Oct 2021 12:18:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A06B6117A for ; Tue, 5 Oct 2021 12:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234388AbhJEMTy (ORCPT ); Tue, 5 Oct 2021 08:19:54 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:38296 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbhJEMTy (ORCPT ); Tue, 5 Oct 2021 08:19:54 -0400 X-Greylist: delayed 336 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Oct 2021 08:19:53 EDT Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id DC7CEFB03; Tue, 5 Oct 2021 14:12:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9MfrIIi09mzw; Tue, 5 Oct 2021 14:12:23 +0200 (CEST) Date: Tue, 5 Oct 2021 14:12:22 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Shawn Guo Cc: Martin Kepplinger , robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, kernel@puri.sm Subject: Re: [PATCH v1 3/6] arm64: dts: imx8mq-librem5: wire up the wifi regulator Message-ID: References: <20210913135706.309685-1-martin.kepplinger@puri.sm> <20210913135706.309685-4-martin.kepplinger@puri.sm> <20211004120054.GG15650@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211004120054.GG15650@dragon> Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Hi Shawn, On Mon, Oct 04, 2021 at 08:00:57PM +0800, Shawn Guo wrote: > On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote: > > From: Guido Günther > > > > Connect the wifi power regulator to the corresponding GPIO. > > > > Signed-off-by: Guido Günther > > Signed-off-by: Martin Kepplinger > > --- > > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > > index ba26c6ee98a0..b5562c8f9a3c 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > > @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 { > > > > reg_wifi_3v3: regulator-wifi-3v3 { > > compatible = "regulator-fixed"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_wifi_pwr>; > > regulator-name = "3V3_WIFI"; > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > + gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + vin-supply = <®_vdd_3v3>; > > + regulator-always-on; > > Any reason you need to have this always-on? I think we can drop the `regulator-always-on` nowadays - it's wired up correctly as `vmmc-supply` so turned on accordingly. Will drop for the next revision. Cheers, -- Guido > > Shawn > > > }; > > > > sound { > > @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1 > > >; > > }; > > > > + pinctrl_wifi_pwr: wifipwrgrp { > > + fsl,pins = < > > + /* WIFI3V3_EN */ > > + MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10 0x83 > > + >; > > + }; > > + > > pinctrl_wdog: wdoggrp { > > fsl,pins = < > > /* nWDOG */ > > -- > > 2.30.2 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6249FC433EF for ; Tue, 5 Oct 2021 12:19:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 350AC6120D for ; Tue, 5 Oct 2021 12:19:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 350AC6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YnnvBXF3V7s30sqWHZgNXq6nz14RJL/FoqH62MSUgQ8=; b=fPkHp9huDDbjS/ 6oHG82opBqfVQa1+JTNDKf6KwyoPz5X2fIMTrXZAbKN60aNggB4b+nLS/yDy3SKvdOADrTgijG+a2 BdZsgrNV40AGYB5WOtHkUQHLMJ2LMto1qu6AmbYOg5j2yFvxYexzmUOTT36MG0KH1pQN1bs5hQon6 Sb6fUMevFOu1390lYgUKAtst7BOb1saHvW+OE+NCAfuoGtHSwkjcQbFy1NsQEcEZ+QxriR8Zwzv6f xa5PGuDF+TC1Ud4kI+UjSXZCIHUw2W0VdKxQkkuzIMmi7Wibj4NwODKPQ08FKCKi+oUyO0h5dMoT+ be3IuPkbOhvezejcGozw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjOb-00AL35-O1; Tue, 05 Oct 2021 12:18:09 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXjOV-00AL0s-Ce for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 12:18:04 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id DC7CEFB03; Tue, 5 Oct 2021 14:12:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9MfrIIi09mzw; Tue, 5 Oct 2021 14:12:23 +0200 (CEST) Date: Tue, 5 Oct 2021 14:12:22 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Shawn Guo Cc: Martin Kepplinger , robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, kernel@puri.sm Subject: Re: [PATCH v1 3/6] arm64: dts: imx8mq-librem5: wire up the wifi regulator Message-ID: References: <20210913135706.309685-1-martin.kepplinger@puri.sm> <20210913135706.309685-4-martin.kepplinger@puri.sm> <20211004120054.GG15650@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211004120054.GG15650@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_051803_614384_666F8B49 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shawn, On Mon, Oct 04, 2021 at 08:00:57PM +0800, Shawn Guo wrote: > On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote: > > From: Guido G=FCnther > > = > > Connect the wifi power regulator to the corresponding GPIO. > > = > > Signed-off-by: Guido G=FCnther > > Signed-off-by: Martin Kepplinger > > --- > > arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > = > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/a= rm64/boot/dts/freescale/imx8mq-librem5.dtsi > > index ba26c6ee98a0..b5562c8f9a3c 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > > @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 { > > = > > reg_wifi_3v3: regulator-wifi-3v3 { > > compatible =3D "regulator-fixed"; > > + pinctrl-names =3D "default"; > > + pinctrl-0 =3D <&pinctrl_wifi_pwr>; > > regulator-name =3D "3V3_WIFI"; > > regulator-min-microvolt =3D <3300000>; > > regulator-max-microvolt =3D <3300000>; > > + gpio =3D <&gpio3 10 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + vin-supply =3D <®_vdd_3v3>; > > + regulator-always-on; > = > Any reason you need to have this always-on? I think we can drop the `regulator-always-on` nowadays - it's wired up correctly as `vmmc-supply` so turned on accordingly. Will drop for the next revision. Cheers, -- Guido > = > Shawn > = > > }; > > = > > sound { > > @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1 > > >; > > }; > > = > > + pinctrl_wifi_pwr: wifipwrgrp { > > + fsl,pins =3D < > > + /* WIFI3V3_EN */ > > + MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10 0x83 > > + >; > > + }; > > + > > pinctrl_wdog: wdoggrp { > > fsl,pins =3D < > > /* nWDOG */ > > -- = > > 2.30.2 > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel