From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5465CC433EF for ; Tue, 5 Oct 2021 12:26:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15B3F61505 for ; Tue, 5 Oct 2021 12:26:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15B3F61505 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXjWD-0002ux-3l for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 08:26:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjTO-0008Eb-MG for qemu-devel@nongnu.org; Tue, 05 Oct 2021 08:23:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjTM-0007iX-SS for qemu-devel@nongnu.org; Tue, 05 Oct 2021 08:23:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633436583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XPQj23sWb/O+16k0uw7dn+IVPu+2mmehno2BcKIhJMI=; b=S/Z4dS8gKuE2l/7QdhHIJmEpBTHUmyX8Xp1Npu9G05DZfTXcSw7rySkIsWbEH8GkEztDQK o5J6DbzxTb8cDS/UrBxMgbWrJ2e/vUuEXLoG/aM7W4wWE+wqbcXYsU191aLZjtaiH+UGB1 t0+OGP3Jrbz4iYRSbtHffYK8LwkyEvE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455--JncXWmbOzelr_AXj3nWlQ-1; Tue, 05 Oct 2021 08:23:00 -0400 X-MC-Unique: -JncXWmbOzelr_AXj3nWlQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 806AD835DE2; Tue, 5 Oct 2021 12:22:59 +0000 (UTC) Received: from localhost (unknown [10.39.194.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CC235F4E8; Tue, 5 Oct 2021 12:22:58 +0000 (UTC) Date: Tue, 5 Oct 2021 13:22:58 +0100 From: Stefan Hajnoczi To: Vivek Goyal Subject: Re: [PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list Message-ID: References: <20210930153037.1194279-1-vgoyal@redhat.com> <20210930153037.1194279-14-vgoyal@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210930153037.1194279-14-vgoyal@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gvHFzYKtcbZ26Q1s" Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: miklos@szeredi.hu, qemu-devel@nongnu.org, iangelak@redhat.com, dgilbert@redhat.com, virtio-fs@redhat.com, jaggel@bu.edu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --gvHFzYKtcbZ26Q1s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 30, 2021 at 11:30:37AM -0400, Vivek Goyal wrote: > g_usleep() calls nanosleep() and that now seems to call clock_nanosleep() > syscall. Now these patches are making use of g_usleep(). So add > clock_nanosleep() to list of allowed syscalls. >=20 > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/passthrough_seccomp.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/pass= through_seccomp.c > index cd24b40b78..03080806c0 100644 > --- a/tools/virtiofsd/passthrough_seccomp.c > +++ b/tools/virtiofsd/passthrough_seccomp.c > @@ -117,6 +117,7 @@ static const int syscall_allowlist[] =3D { > SCMP_SYS(writev), > SCMP_SYS(umask), > SCMP_SYS(nanosleep), > + SCMP_SYS(clock_nanosleep), This patch can be dropped once sleep has been replaced by a condvar. --gvHFzYKtcbZ26Q1s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmFcQ6IACgkQnKSrs4Gr c8hAWggAtWAYKqdiNQnnzwGMGMCtbpq78P2T9Y1X0YRwNqi6RQW2LLTne8DrCS3m sssAGkK1c19CYa8tyaDBolKFNtUEPY2aIUW8mikXrPj72CrNH4dy9fFhdXFoLb/a /nMYQ57E8mvzVfNgOaZjhmr7IPQoU+CFP3kMaL0o+J/PrRqrWcYj7alx29ASnV3B 0mkjZJGYqPJeEWpchfQDHK94H3p9qNVA2FpZ8ZPzjc9ofXo1ijGno6QNxEodqnYc RA3xdCz/8wLfhLPf20yCunBuhRe//CqBb921d8ZTCLv2G6jf9NLUB9mMy/lshtDx 89wMw2pIffXtGeklEYxJ2c/YXiNkYA== =ocDr -----END PGP SIGNATURE----- --gvHFzYKtcbZ26Q1s-- From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 5 Oct 2021 13:22:58 +0100 From: Stefan Hajnoczi Message-ID: References: <20210930153037.1194279-1-vgoyal@redhat.com> <20210930153037.1194279-14-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gvHFzYKtcbZ26Q1s" Content-Disposition: inline In-Reply-To: <20210930153037.1194279-14-vgoyal@redhat.com> Subject: Re: [Virtio-fs] [PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vivek Goyal Cc: miklos@szeredi.hu, qemu-devel@nongnu.org, virtio-fs@redhat.com --gvHFzYKtcbZ26Q1s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 30, 2021 at 11:30:37AM -0400, Vivek Goyal wrote: > g_usleep() calls nanosleep() and that now seems to call clock_nanosleep() > syscall. Now these patches are making use of g_usleep(). So add > clock_nanosleep() to list of allowed syscalls. >=20 > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/passthrough_seccomp.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/pass= through_seccomp.c > index cd24b40b78..03080806c0 100644 > --- a/tools/virtiofsd/passthrough_seccomp.c > +++ b/tools/virtiofsd/passthrough_seccomp.c > @@ -117,6 +117,7 @@ static const int syscall_allowlist[] =3D { > SCMP_SYS(writev), > SCMP_SYS(umask), > SCMP_SYS(nanosleep), > + SCMP_SYS(clock_nanosleep), This patch can be dropped once sleep has been replaced by a condvar. --gvHFzYKtcbZ26Q1s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmFcQ6IACgkQnKSrs4Gr c8hAWggAtWAYKqdiNQnnzwGMGMCtbpq78P2T9Y1X0YRwNqi6RQW2LLTne8DrCS3m sssAGkK1c19CYa8tyaDBolKFNtUEPY2aIUW8mikXrPj72CrNH4dy9fFhdXFoLb/a /nMYQ57E8mvzVfNgOaZjhmr7IPQoU+CFP3kMaL0o+J/PrRqrWcYj7alx29ASnV3B 0mkjZJGYqPJeEWpchfQDHK94H3p9qNVA2FpZ8ZPzjc9ofXo1ijGno6QNxEodqnYc RA3xdCz/8wLfhLPf20yCunBuhRe//CqBb921d8ZTCLv2G6jf9NLUB9mMy/lshtDx 89wMw2pIffXtGeklEYxJ2c/YXiNkYA== =ocDr -----END PGP SIGNATURE----- --gvHFzYKtcbZ26Q1s--