From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F735C433EF for ; Tue, 5 Oct 2021 21:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A3DB61216 for ; Tue, 5 Oct 2021 21:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236686AbhJEVVn (ORCPT ); Tue, 5 Oct 2021 17:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236590AbhJEVVm (ORCPT ); Tue, 5 Oct 2021 17:21:42 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E191C061749 for ; Tue, 5 Oct 2021 14:19:51 -0700 (PDT) Received: from zn.tnic (p200300ec2f0d200041aa61d88eaf7a6e.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:2000:41aa:61d8:8eaf:7a6e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9742D1EC04DA; Tue, 5 Oct 2021 23:19:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633468789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=C7vNPv9qxUKW9pQwmNcRNhYvKa4vCfzU3SkADMazk8M=; b=rcfI9eMXeakIUn/rZEB6rWJ0kzBPP1m9Att0EgDAYd/A6fFh7vjz24OXsi6rzZM//Cfusq rt2Iimy3gY2MOyZekX3dg+MNwh3+0K30nNGp+4n2XjuFmk49icUV1P/g/v/gCwbHp5v50z mEvWKIrUncGPRfklMG024Sq60zBHzJo= Date: Tue, 5 Oct 2021 23:19:49 +0200 From: Borislav Petkov To: Josh Poimboeuf Cc: Kuppuswamy Sathyanarayanan , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 03/11] x86/cpufeatures: Add TDX Guest CPU feature Message-ID: References: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005025205.1784480-4-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005210423.yfftpxxmj3cjprtv@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211005210423.yfftpxxmj3cjprtv@treble> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 05, 2021 at 02:04:23PM -0700, Josh Poimboeuf wrote: > What's the point of having both 'is_tdx_guest' and > X86_FEATURE_TDX_GUEST? Are they not redundant? I think this should explain it: https://lkml.kernel.org/r/YVL4ZUGhfsh1QfRX@zn.tnic but I've yet to go through these here patches and see what's happening there. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette