From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A4FC433FE for ; Mon, 18 Oct 2021 06:13:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E561610C7 for ; Mon, 18 Oct 2021 06:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbhJRGPf (ORCPT ); Mon, 18 Oct 2021 02:15:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:38122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbhJRGPf (ORCPT ); Mon, 18 Oct 2021 02:15:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6686860F56; Mon, 18 Oct 2021 06:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634537604; bh=roG/LrnebQ24A/ZxdxzZ3+XJwO8+/2dyKFc3em3jnq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QG191IV/yu4uR2WjkHTA+csB2wOkyVZFW68dx1Sq3WC/3ZekKZXRTVudqjejgGbXM jLbmh/VVnkgJrRXlL6OTQp6+v4k4QUIUWaUPpT3fLPlA6o/DqhpDbztPiFvpeMBbiJ /VVnBXXqmWOc1ySlg+wQk/W2S0RHUx6EJAoP0SIsKCQLA7JV9/fCpyD9SCql6gDRHU vHaNooyJn1ZH2fzCBXP3FIHdc2dbqLxxkaQKWWuxH6cXP3c/M/LbaAJc2FXgdm4xaV KZeOTPwlbcut4fbYs/A42NouxtWEZ7lSsT0713s+VcSeM67cnkGlYmaDlZ4UfiiMhp 0Y1i4yKaL+Gqw== Date: Mon, 18 Oct 2021 11:43:19 +0530 From: Vinod Koul To: Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] dmaengine: bestcomm: fix system boot lockups Message-ID: References: <20211014094012.21286-1-agust@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014094012.21286-1-agust@denx.de> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 14-10-21, 11:40, Anatolij Gustschin wrote: > memset() and memcpy() on an MMIO region like here results in a > lockup at startup on mpc5200 platform (since this first happens > during probing of the ATA and Ethernet drivers). Use memset_io() > and memcpy_toio() instead. Applied, thanks -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3409FC433F5 for ; Mon, 18 Oct 2021 06:14:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89BB360F9E for ; Mon, 18 Oct 2021 06:14:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 89BB360F9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HXmmJ6sY6z3c6G for ; Mon, 18 Oct 2021 17:14:08 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QG191IV/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=vkoul@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QG191IV/; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HXmlW4F2Pz2yQL for ; Mon, 18 Oct 2021 17:13:27 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6686860F56; Mon, 18 Oct 2021 06:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634537604; bh=roG/LrnebQ24A/ZxdxzZ3+XJwO8+/2dyKFc3em3jnq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QG191IV/yu4uR2WjkHTA+csB2wOkyVZFW68dx1Sq3WC/3ZekKZXRTVudqjejgGbXM jLbmh/VVnkgJrRXlL6OTQp6+v4k4QUIUWaUPpT3fLPlA6o/DqhpDbztPiFvpeMBbiJ /VVnBXXqmWOc1ySlg+wQk/W2S0RHUx6EJAoP0SIsKCQLA7JV9/fCpyD9SCql6gDRHU vHaNooyJn1ZH2fzCBXP3FIHdc2dbqLxxkaQKWWuxH6cXP3c/M/LbaAJc2FXgdm4xaV KZeOTPwlbcut4fbYs/A42NouxtWEZ7lSsT0713s+VcSeM67cnkGlYmaDlZ4UfiiMhp 0Y1i4yKaL+Gqw== Date: Mon, 18 Oct 2021 11:43:19 +0530 From: Vinod Koul To: Anatolij Gustschin Subject: Re: [PATCH] dmaengine: bestcomm: fix system boot lockups Message-ID: References: <20211014094012.21286-1-agust@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014094012.21286-1-agust@denx.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 14-10-21, 11:40, Anatolij Gustschin wrote: > memset() and memcpy() on an MMIO region like here results in a > lockup at startup on mpc5200 platform (since this first happens > during probing of the ATA and Ethernet drivers). Use memset_io() > and memcpy_toio() instead. Applied, thanks -- ~Vinod