All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andrej Shadura <andrew.shadura@collabora.co.uk>
Cc: "Jiří Kosina" <jikos@kernel.org>,
	linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
	kernel@collabora.com,
	"Benjamin Tissoires" <benjamin.tissoires@gmail.com>
Subject: Re: [PATCH 1/2] HID: u2fzero: explicitly check for errors
Date: Mon, 18 Oct 2021 08:56:58 +0200	[thread overview]
Message-ID: <YW0aulXWy86FvTvq@kroah.com> (raw)
In-Reply-To: <20211018064800.15173-1-andrew.shadura@collabora.co.uk>

On Mon, Oct 18, 2021 at 08:47:59AM +0200, Andrej Shadura wrote:
> The previous commit fixed handling of incomplete packets but broke error
> handling: offsetof returns an unsigned value (size_t), but when compared
> against the signed return value, the return value is interpreted as if
> it were unsigned, so negative return values are never less than the
> offset.
> 
> Fixes: 22d65765f211c("HID: u2fzero: ignore incomplete packets without data")
> Fixes: 42337b9d4d958("HID: add driver for U2F Zero built-in LED and RNG")

Nit, you need a ' ' before the '(' character here, and you only need 12
digits of the sha1.  It should look like:
	Fixes: 22d65765f211 ("HID: u2fzero: ignore incomplete packets without data")

Also, how about a cc: stable for these as well?

thanks,

greg k-h

  parent reply	other threads:[~2021-10-18  6:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18  6:47 [PATCH 1/2] HID: u2fzero: explicitly check for errors Andrej Shadura
2021-10-18  6:48 ` [PATCH 2/2] HID: u2fzero: properly handle timeouts in usb_submit_urb Andrej Shadura
2021-10-18  6:56 ` Greg KH [this message]
2021-10-18 12:06   ` [PATCH 1/2] HID: u2fzero: explicitly check for errors Andrej Shadura
2021-10-18 12:09     ` Andrej Shadura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW0aulXWy86FvTvq@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andrew.shadura@collabora.co.uk \
    --cc=benjamin.tissoires@gmail.com \
    --cc=jikos@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.