From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD6FC4332F for ; Mon, 18 Oct 2021 16:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 616BF60F12 for ; Mon, 18 Oct 2021 16:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233692AbhJRQpl (ORCPT ); Mon, 18 Oct 2021 12:45:41 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:35451 "EHLO mail-oi1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbhJRQpk (ORCPT ); Mon, 18 Oct 2021 12:45:40 -0400 Received: by mail-oi1-f177.google.com with SMTP id r6so628455oiw.2; Mon, 18 Oct 2021 09:43:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/vsPv2SD1Rt8WbOkNW13ZNWlyAjKc3bg4K4BxMrdTKc=; b=Pa6GomVbVXYYe/9ExmVV6kjIEgfq6uTGu8OoluinqdpUSOiTZd7nMFcCHluXIbqmw4 I5DpeX3U/Hcg8fg8zzx1e6bfYfHVq99iQ81E8LhiOgidhHSY4ha32kTCz7H91erY0qE7 uDYZMpjGrMBGdeWquNXi+BSv3ibalgE1WQGlOeOVwmIpq2An5FlypjmQdse26FIF86Yb UzBI+lAU1YFaI1OU7bXE+hKwSPzps/qLc3cXONFyTNalf3XegM+AqzNGwOtJf9XSDnyN MchZC3ppEXyZ2yaaQVusE/3b85XoSUPcebpE8KIw3PZvZAydLhE04NUy5RoJHXeNT9ff kowg== X-Gm-Message-State: AOAM530uSZt1A8JjgzJW0dcWQTK14lrQTnc13P/SPvDAyydjuieXmwfS hQdMOICgtICvx7+J7JBmFQ== X-Google-Smtp-Source: ABdhPJxOfGc66L0/rXjSFdldE/BLsaDwndHWOMX5LeqJpkR4KftoMRAgJrb4lXRb41d95MOC+xLB+g== X-Received: by 2002:a05:6808:7c8:: with SMTP id f8mr638949oij.146.1634575408315; Mon, 18 Oct 2021 09:43:28 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id ay42sm3156043oib.22.2021.10.18.09.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 09:43:27 -0700 (PDT) Received: (nullmailer pid 2532419 invoked by uid 1000); Mon, 18 Oct 2021 16:43:26 -0000 Date: Mon, 18 Oct 2021 11:43:26 -0500 From: Rob Herring To: Sean Anderson Cc: linux-arm-kernel@lists.infradead.org, Thierry Reding , linux-kernel@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alvaro Gamez , devicetree@vger.kernel.org, Lee Jones , michal.simek@xilinx.com, linux-pwm@vger.kernel.org Subject: Re: [PATCH v8 2/3] dt-bindings: pwm: Add Xilinx AXI Timer Message-ID: References: <20211015190025.409426-1-sean.anderson@seco.com> <20211015190025.409426-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015190025.409426-2-sean.anderson@seco.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Oct 2021 15:00:24 -0400, Sean Anderson wrote: > This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is a > "soft" block, so it has some parameters which would not be configurable in > most hardware. This binding is usually automatically generated by Xilinx's > tools, so the names and values of some properties should be kept as they > are, if possible. In addition, this binding is already in the kernel at > arch/microblaze/boot/dts/system.dts, and in user software such as QEMU. > > The existing driver uses the clock-frequency property, or alternatively the > /cpus/timebase-frequency property as its frequency input. Because these > properties are deprecated, they have not been included with this schema. > All new bindings should use the clocks/clock-names properties to specify > the parent clock. > > Because we need to init timer devices so early in boot, we determine if we > should use the PWM driver or the clocksource/clockevent driver by the > presence/absence, respectively, of #pwm-cells. Because both counters are > used by the PWM, there is no need for a separate property specifying which > counters are to be used for the PWM. > > Signed-off-by: Sean Anderson > --- > > Changes in v8: > - Set additionalProperties: false > > Changes in v7: > - Add #pwm-cells to properties > - Document why additionalProperties is true > > Changes in v6: > - Enumerate possible counter widths > - Fix incorrect schema id > > Changes in v5: > - Add example for timer binding > - Fix indentation lint > - Move schema into the timer directory > - Remove xlnx,axi-timer-2.0 compatible string > - Update commit message to reflect revisions > > Changes in v4: > - Make some properties optional for clocksource drivers > - Predicate PWM driver on the presence of #pwm-cells > - Remove references to generate polarity so this can get merged > > Changes in v3: > - Add an example with non-deprecated properties only. > - Add xlnx,pwm and xlnx,gen?-active-low properties. > - Make newer replacement properties mutually-exclusive with what they > replace > - Mark all boolean-as-int properties as deprecated > > Changes in v2: > - Use 32-bit addresses for example binding > > .../bindings/timer/xlnx,xps-timer.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/xlnx,xps-timer.yaml > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C377C433EF for ; Mon, 18 Oct 2021 16:44:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38E3B610C8 for ; Mon, 18 Oct 2021 16:44:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38E3B610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d9tMpHx24Kz9LrHgh81wO27RpkzLuMCbcJEHC/9MH+s=; b=Z+D/4QUCuqZUNM lElg5Cg3DDeHA5faKdaNU/fIxkFDBMnK6JTKm8udtPgu1nMTxbnBwui6Pj+9ISA5ZHwvIJs/7p4qM 0cTvRXW8mWxZLAFveX4Q1rAkGleFfeBdm/TOlXO4g+ZtvbqWgmjwYfKefh/4+8Nulk3Y9PLuVv7yu 4SrYRDGWOKhvbUbngCVN9ZpSkvV+IXTKFGNWkpNf2LLR/XYwrbc6QvoZb4cgVgWkb00j3EIKdTiIj tvD7LR/AD1rTNHLS1d3eBe1i8ZEL4e7EK7OoVTsMVVMAm3L/S8d3wYQqhkpziNcdKZOm8N6tOh6dr C7IY8W87JwfWRNSXrJ6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcVja-00GXKp-H3; Mon, 18 Oct 2021 16:43:34 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcVjW-00GXJR-Fa for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 16:43:31 +0000 Received: by mail-oi1-f175.google.com with SMTP id m67so600088oif.6 for ; Mon, 18 Oct 2021 09:43:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/vsPv2SD1Rt8WbOkNW13ZNWlyAjKc3bg4K4BxMrdTKc=; b=JWMotdY7lmMAxNOlTf5bLJCoJWBTnizPXx8+wfwQrbN2RG7Vxn5Lcy6AnvU1hmcdUk uSr9CPi04p6m+PmV3B4ukNqqMvnNVll5RscmsVStgRKhdqWCLr+CpKFq9CrviZZe1mCr xfj8yom97q/CV3Qr2v4rsbKqpDfCCGloZQmdU4pSKZG6hfApP8vocZuXsZmb+dKNOk7l i2wXliahpcovpNXsCrE9Amq1HioO6GwHjqAy11UEOzq8fwVdCtGXiyd4197Q+7XnxyB4 VmCueRHuy/e6JkcO4xy78H4tte+SXmj4kI2KnnChtRw/WPrdSXg8GsTnVf2/ji64R/AL DPDQ== X-Gm-Message-State: AOAM532w9y4vgq10XBjUCF4y7pC8FDjrQm9hQyYgfLqrLmKl+wcy6JeP ACK5ubXJSq1w5mutnJUPdA== X-Google-Smtp-Source: ABdhPJxOfGc66L0/rXjSFdldE/BLsaDwndHWOMX5LeqJpkR4KftoMRAgJrb4lXRb41d95MOC+xLB+g== X-Received: by 2002:a05:6808:7c8:: with SMTP id f8mr638949oij.146.1634575408315; Mon, 18 Oct 2021 09:43:28 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id ay42sm3156043oib.22.2021.10.18.09.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 09:43:27 -0700 (PDT) Received: (nullmailer pid 2532419 invoked by uid 1000); Mon, 18 Oct 2021 16:43:26 -0000 Date: Mon, 18 Oct 2021 11:43:26 -0500 From: Rob Herring To: Sean Anderson Cc: linux-arm-kernel@lists.infradead.org, Thierry Reding , linux-kernel@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alvaro Gamez , devicetree@vger.kernel.org, Lee Jones , michal.simek@xilinx.com, linux-pwm@vger.kernel.org Subject: Re: [PATCH v8 2/3] dt-bindings: pwm: Add Xilinx AXI Timer Message-ID: References: <20211015190025.409426-1-sean.anderson@seco.com> <20211015190025.409426-2-sean.anderson@seco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211015190025.409426-2-sean.anderson@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_094330_547188_37A85B56 X-CRM114-Status: GOOD ( 26.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 15 Oct 2021 15:00:24 -0400, Sean Anderson wrote: > This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is a > "soft" block, so it has some parameters which would not be configurable in > most hardware. This binding is usually automatically generated by Xilinx's > tools, so the names and values of some properties should be kept as they > are, if possible. In addition, this binding is already in the kernel at > arch/microblaze/boot/dts/system.dts, and in user software such as QEMU. > > The existing driver uses the clock-frequency property, or alternatively the > /cpus/timebase-frequency property as its frequency input. Because these > properties are deprecated, they have not been included with this schema. > All new bindings should use the clocks/clock-names properties to specify > the parent clock. > > Because we need to init timer devices so early in boot, we determine if we > should use the PWM driver or the clocksource/clockevent driver by the > presence/absence, respectively, of #pwm-cells. Because both counters are > used by the PWM, there is no need for a separate property specifying which > counters are to be used for the PWM. > > Signed-off-by: Sean Anderson > --- > > Changes in v8: > - Set additionalProperties: false > > Changes in v7: > - Add #pwm-cells to properties > - Document why additionalProperties is true > > Changes in v6: > - Enumerate possible counter widths > - Fix incorrect schema id > > Changes in v5: > - Add example for timer binding > - Fix indentation lint > - Move schema into the timer directory > - Remove xlnx,axi-timer-2.0 compatible string > - Update commit message to reflect revisions > > Changes in v4: > - Make some properties optional for clocksource drivers > - Predicate PWM driver on the presence of #pwm-cells > - Remove references to generate polarity so this can get merged > > Changes in v3: > - Add an example with non-deprecated properties only. > - Add xlnx,pwm and xlnx,gen?-active-low properties. > - Make newer replacement properties mutually-exclusive with what they > replace > - Mark all boolean-as-int properties as deprecated > > Changes in v2: > - Use 32-bit addresses for example binding > > .../bindings/timer/xlnx,xps-timer.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/xlnx,xps-timer.yaml > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel