All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Meng Li <Meng.Li@windriver.com>
Cc: geert+renesas@glider.be, magnus.damm@gmail.com,
	robh+dt@kernel.org, marek.vasut+renesas@gmail.com,
	yoshihiro.shimoda.uh@renesas.com, lorenzo.pieralisi@arm.com,
	kw@linux.com, bhelgaas@google.com, lgirdwood@gmail.com,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci: pcie-rcar: add regulators support
Date: Tue, 19 Oct 2021 13:36:06 +0100	[thread overview]
Message-ID: <YW67tsigF89EkDWS@sirena.org.uk> (raw)
In-Reply-To: <20211019095858.21316-1-Meng.Li@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

On Tue, Oct 19, 2021 at 05:58:58PM +0800, Meng Li wrote:

> From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> 
> Add PCIe regulators for KingFisher board.
> 
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---

You've not provided a Signed-off-by for Andrey, please see
Documentation/process/submitting-patches.rst for details on what this is
and why it's important.

> +	host->pcie3v3 = devm_regulator_get_optional(dev, "pcie3v3");

> +	host->pcie1v8 = devm_regulator_get_optional(dev, "pcie1v8");

Unless PCIe works without these supplies (which are in my understanding
mandatory according to the spec) these should not be optional, this API
is for supplies that may be physically absent.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-10-19 12:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  9:58 [PATCH] pci: pcie-rcar: add regulators support Meng Li
2021-10-19 10:19 ` Geert Uytterhoeven
2021-10-19 10:59   ` Li, Meng
2021-10-19 12:36 ` Mark Brown [this message]
2021-10-19 13:30 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW67tsigF89EkDWS@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Meng.Li@windriver.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=kw@linux.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=magnus.damm@gmail.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.