From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0881C433F5 for ; Tue, 19 Oct 2021 13:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B00EC61374 for ; Tue, 19 Oct 2021 13:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230267AbhJSNTk (ORCPT ); Tue, 19 Oct 2021 09:19:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:57216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhJSNTk (ORCPT ); Tue, 19 Oct 2021 09:19:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E55160F8F; Tue, 19 Oct 2021 13:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634649447; bh=AO1utIzn3HlksXxw/tPApGLTScmglkP/vy4c3NTf1kc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QUky2395LRvtYFkpjsYIyuYo+aiYWORW3h8WGFESGk2bJd+ugnMojwAMhN43GoIhE aHDFBfHL/FGQclgKpe+9OfpIGe2yHqcVoJKuszPLmKmeHlas3RK+gMrePTWjLVmUXz Xqg/cHbjOChLRwZUs8SmVzOvviisfqU1/OaGjE/IVBDf9noyHdlV/igrmDtu3A5FJW LH5Gy8bLE6fzotlGR8K89h8ZITMBgHVUJhJqJd7fN2ZI2atnmmvPXA2VMv9+7zV3sJ OmeK+85e1xFbriZ50H2buIoPw/ljo4wN5EbKRLBcP6MfGj71WmlIe7VTFhHElvh743 dYvPX9LL5bVwQ== Date: Tue, 19 Oct 2021 14:17:25 +0100 From: Mark Brown To: Will Deacon Cc: Catalin Marinas , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 04/42] arm64/sve: Make access to FFR optional Message-ID: References: <20211018190858.2119209-1-broonie@kernel.org> <20211018190858.2119209-5-broonie@kernel.org> <20211019101447.GA13251@willie-the-truck> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4JynMv7lS+7bIYBb" Content-Disposition: inline In-Reply-To: <20211019101447.GA13251@willie-the-truck> X-Cookie: I program, therefore I am. Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org --4JynMv7lS+7bIYBb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 19, 2021 at 11:14:47AM +0100, Will Deacon wrote: > > -1: sve_flush_p_ffr > > +1: cbz x0, 2f > > + sve_flush_p > > +2: sve_flush_ffr > > ret > I'm confused by this -- x0 seems to control whether or not we flush the > predicate registers rather then ffr. Yes, that's buggy - it got broken with rebasing for skipping the Z register flush. Thanks for spotting, sorry about that. --4JynMv7lS+7bIYBb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFuxWQACgkQJNaLcl1U h9BnTwf+LwKtrqWdF9opVZuivEWDjISRuGNlA41n3FjVZdGc2P8FQKn9MWoNpN5V ybAf8ooy+tPwsqy7HbZNIlgvnGMOkZcl6NegKBv2YoeyNgqHMiEvCuDvvld7axgS IdP0V0VwdIWd4ODT+ZATgbSobSbyMCIhGhOkVI7Z1OG/3e1yU3QOD6BvAYn+WzJw rt+OqKQl7T1QOmBfbE00Bl7fcZbPDYytd7xKejk/tX+QEN32QSr/1L7k5VHbYFam KU7B0hpq6W5y3U5fTj6+zryPBXYQCGdLZUeKnm0oaaAB4mi8VX1DxlkjHUj2DeZm 4uzC8O4XSI6mNiCCcTweBwkB8bRq+g== =Gqkr -----END PGP SIGNATURE----- --4JynMv7lS+7bIYBb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8C9C433F5 for ; Tue, 19 Oct 2021 13:18:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6EDF610E7 for ; Tue, 19 Oct 2021 13:18:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6EDF610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8Ryvkq8ihQHYkNLLwI2YEKI1Bkdpw1MNItLVLW/coDo=; b=BP+EUyO97oRuwBtJ4ATkilo1HT UA3/LB3hAJBP2ixgQrchCoLLUOrRzg4TbW8QpbWv5u0TiMPlbxJfW655rfU3ZoTN9zE+THWF4w5Tl SAeQTvRIxm2YlLjsHqg9OJClLcIeJxcaCygaIhQ2Elo7UK/rPbkle6MS6T/ZpcmwlD5kFBRyyHVuE uToen42uZFJO3HVX+bM28ibFvImUQaGGUwV7u2X22ZYW4FcwdpMG+NhOonOZWV636geGcWLhbRZac o2Jk4mPeEFffBEMxzlKvWkBLF93FdcZzvLEaUiiutf+M1gO3G42bGm0ytjmFMl5PEcTyp8anTJgnv MhtnqqSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcozo-001Nwp-MS; Tue, 19 Oct 2021 13:17:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcozg-001Nve-2q for linux-arm-kernel@lists.infradead.org; Tue, 19 Oct 2021 13:17:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E55160F8F; Tue, 19 Oct 2021 13:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634649447; bh=AO1utIzn3HlksXxw/tPApGLTScmglkP/vy4c3NTf1kc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QUky2395LRvtYFkpjsYIyuYo+aiYWORW3h8WGFESGk2bJd+ugnMojwAMhN43GoIhE aHDFBfHL/FGQclgKpe+9OfpIGe2yHqcVoJKuszPLmKmeHlas3RK+gMrePTWjLVmUXz Xqg/cHbjOChLRwZUs8SmVzOvviisfqU1/OaGjE/IVBDf9noyHdlV/igrmDtu3A5FJW LH5Gy8bLE6fzotlGR8K89h8ZITMBgHVUJhJqJd7fN2ZI2atnmmvPXA2VMv9+7zV3sJ OmeK+85e1xFbriZ50H2buIoPw/ljo4wN5EbKRLBcP6MfGj71WmlIe7VTFhHElvh743 dYvPX9LL5bVwQ== Date: Tue, 19 Oct 2021 14:17:25 +0100 From: Mark Brown To: Will Deacon Cc: Catalin Marinas , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 04/42] arm64/sve: Make access to FFR optional Message-ID: References: <20211018190858.2119209-1-broonie@kernel.org> <20211018190858.2119209-5-broonie@kernel.org> <20211019101447.GA13251@willie-the-truck> MIME-Version: 1.0 In-Reply-To: <20211019101447.GA13251@willie-the-truck> X-Cookie: I program, therefore I am. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_061728_168484_5B1AC17D X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7239973238580428286==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7239973238580428286== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4JynMv7lS+7bIYBb" Content-Disposition: inline --4JynMv7lS+7bIYBb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 19, 2021 at 11:14:47AM +0100, Will Deacon wrote: > > -1: sve_flush_p_ffr > > +1: cbz x0, 2f > > + sve_flush_p > > +2: sve_flush_ffr > > ret > I'm confused by this -- x0 seems to control whether or not we flush the > predicate registers rather then ffr. Yes, that's buggy - it got broken with rebasing for skipping the Z register flush. Thanks for spotting, sorry about that. --4JynMv7lS+7bIYBb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFuxWQACgkQJNaLcl1U h9BnTwf+LwKtrqWdF9opVZuivEWDjISRuGNlA41n3FjVZdGc2P8FQKn9MWoNpN5V ybAf8ooy+tPwsqy7HbZNIlgvnGMOkZcl6NegKBv2YoeyNgqHMiEvCuDvvld7axgS IdP0V0VwdIWd4ODT+ZATgbSobSbyMCIhGhOkVI7Z1OG/3e1yU3QOD6BvAYn+WzJw rt+OqKQl7T1QOmBfbE00Bl7fcZbPDYytd7xKejk/tX+QEN32QSr/1L7k5VHbYFam KU7B0hpq6W5y3U5fTj6+zryPBXYQCGdLZUeKnm0oaaAB4mi8VX1DxlkjHUj2DeZm 4uzC8O4XSI6mNiCCcTweBwkB8bRq+g== =Gqkr -----END PGP SIGNATURE----- --4JynMv7lS+7bIYBb-- --===============7239973238580428286== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7239973238580428286==--