From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D60FC433FE for ; Tue, 19 Oct 2021 18:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72DEF6136F for ; Tue, 19 Oct 2021 18:53:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234625AbhJSSzj (ORCPT ); Tue, 19 Oct 2021 14:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233744AbhJSSzj (ORCPT ); Tue, 19 Oct 2021 14:55:39 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B52E3C061746 for ; Tue, 19 Oct 2021 11:53:25 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id x192so9547653lff.12 for ; Tue, 19 Oct 2021 11:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=r2rrts++NxgImf0a82glzOmEBUZi84j06zH7Tkh8a8M=; b=UCfOxF5aleDe9ZpwZmCWIP9VsQAb4vMBWEfUnp+qQcgTZjP8QmmJb3ku5lBKiuNK+3 aGqchluX/vJ+TMf9yoXaEbIkDsQEB0GpDtBpZeo5Nf2yiOF7Ai4tOhdh92kZvRNqvrlK JXMeme5yEDlqC9tBBaHPoB/xKQ7lJQwX6isLQSMJinQtqDsDicpA40jAHPfaG/liUwzR tzdzvk4BfDFjrXRnRmP3f/utMjATXwQtRPVDYyGBI7ab+loFYldRFmJi1szd/WKOg9dj e0wUezSGyCjoTZ82q5SXaJa+9sXigedgHqOE0Z0p5YnZwAx8VrpXbDgohbNBm0GVbEJJ K/6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=r2rrts++NxgImf0a82glzOmEBUZi84j06zH7Tkh8a8M=; b=BtRBhZyRaFli3SOdvNxloZaomqqABSZif+hXYdtB2Z/yDF/Y4VdU51j+xRcVl1tMI8 rAvrE67wYvjjPlpHLTsWvSBcWdg5/yF4W2oKYtaE0EYwilDJBLGRDHrgWH9MNnFsDw+a g+N0y0EglcRjq+m83mZCsI54+CzL1Z2RujcFuLEcZfDbx6PcsY5rPE6X6rRP0ezV4bYA dyMNTBlwawLv2Rr9bTsM/lKMohdK6ooTQtOGVYNLPz5ghPbLEtsvwfHvNB8PARcMQSv5 UKpuHarp3NAcOgixT0JrmIUEZZeQkjyO0txqRmaGYCXdpR9yWkQ+eatP3M4MmAQ7BoV2 EfWw== X-Gm-Message-State: AOAM532AauZusotnBj4mUL43laBOLQ33EIaLCOjOu47I2kR76zsRKjTv xaRURaM9AqemuIlDcLSSSak6fw== X-Google-Smtp-Source: ABdhPJwG39+FkLXNePl3OVv2tcHg9caTiE1j1aHd+NogGFk6PsF6gGSl2z6yWbUydEr42eFxSBLuWA== X-Received: by 2002:ac2:4bc2:: with SMTP id o2mr7615405lfq.501.1634669604111; Tue, 19 Oct 2021 11:53:24 -0700 (PDT) Received: from localhost (h-46-59-88-219.A463.priv.bahnhof.se. [46.59.88.219]) by smtp.gmail.com with ESMTPSA id o22sm709865lfr.250.2021.10.19.11.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 11:53:23 -0700 (PDT) Date: Tue, 19 Oct 2021 20:53:22 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Lad Prabhakar , Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: renesas: rzg2l: Add missing kerneldoc for resets Message-ID: References: <39c2c5fd4232b6620a4a56dba4e2b0d61476ee36.1634646869.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <39c2c5fd4232b6620a4a56dba4e2b0d61476ee36.1634646869.git.geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, Thanks for your work. On 2021-10-19 14:35:36 +0200, Geert Uytterhoeven wrote: > make W=1: > > drivers/clk/renesas/rzg2l-cpg.c:95: warning: Function parameter or member 'num_resets' not described in 'rzg2l_cpg_priv' > > Add the missing kerneldoc for fields in struct rzg2l_cpg_priv and struct > rzg2l_cpg_info related to Module Resets. > > Fixes: c3e67ad6f5a2c698 ("dt-bindings: clock: r9a07g044-cpg: Update clock/reset definitions") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > To be queued in renesas-clk for v5.17. > --- > drivers/clk/renesas/rzg2l-cpg.c | 1 + > drivers/clk/renesas/rzg2l-cpg.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c > index 4021f6cabda4b3bc..a77cb47b75e7c253 100644 > --- a/drivers/clk/renesas/rzg2l-cpg.c > +++ b/drivers/clk/renesas/rzg2l-cpg.c > @@ -74,6 +74,7 @@ struct sd_hw_data { > * @clks: Array containing all Core and Module Clocks > * @num_core_clks: Number of Core Clocks in clks[] > * @num_mod_clks: Number of Module Clocks in clks[] > + * @num_resets: Number of Module Resets in info->resets[] > * @last_dt_core_clk: ID of the last Core Clock exported to DT > * @notifiers: Notifier chain to save/restore clock state for system resume > * @info: Pointer to platform data > diff --git a/drivers/clk/renesas/rzg2l-cpg.h b/drivers/clk/renesas/rzg2l-cpg.h > index 7fb6b4030f72e237..484c7cee2629366f 100644 > --- a/drivers/clk/renesas/rzg2l-cpg.h > +++ b/drivers/clk/renesas/rzg2l-cpg.h > @@ -168,6 +168,9 @@ struct rzg2l_reset { > * @num_mod_clks: Number of entries in mod_clks[] > * @num_hw_mod_clks: Number of Module Clocks supported by the hardware > * > + * @resets: Array of Module Reset definitions > + * @num_resets: Number of entries in resets[] > + * > * @crit_mod_clks: Array with Module Clock IDs of critical clocks that > * should not be disabled without a knowledgeable driver > * @num_crit_mod_clks: Number of entries in crit_mod_clks[] > -- > 2.25.1 > -- Regards, Niklas Söderlund