From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC64FC433FE for ; Fri, 8 Oct 2021 09:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B145E610CE for ; Fri, 8 Oct 2021 09:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238253AbhJHJ2D (ORCPT ); Fri, 8 Oct 2021 05:28:03 -0400 Received: from foss.arm.com ([217.140.110.172]:37534 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbhJHJ17 (ORCPT ); Fri, 8 Oct 2021 05:27:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9DB0D6E; Fri, 8 Oct 2021 02:26:04 -0700 (PDT) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CEA153F70D; Fri, 8 Oct 2021 02:26:01 -0700 (PDT) Date: Fri, 8 Oct 2021 10:27:41 +0100 From: Alexandru Elisei To: Punit Agrawal Cc: davem@davemloft.net, michael.riesch@wolfvision.net, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, p.zabel@pengutronix.de, lgirdwood@gmail.com, Mark Brown , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, arm-mail-list , Linux Kernel Mailing List Subject: Re: [BUG] Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") Message-ID: References: <8e33c244-b786-18e8-79bc-407e27e4756b@arm.com> <87zgrk19yb.fsf@stealth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zgrk19yb.fsf@stealth> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Punit, On Fri, Oct 08, 2021 at 12:17:48PM +0900, Punit Agrawal wrote: > Alexandru Elisei writes: > > > (Sorry I'm sending this to the wrong person, this is what I got > > scripts/get_maintainer.pl for the file touched by the commit) > > > > After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced > > pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left unable > > to get a DHCP lease from the network. The offending commit was found by bisecting > > the kernel; I tried reverting the commit from current master (commit 0513e464f900 > > ("Merge tag 'perf-tools-fixes-for-v5.15-2021-09-27' of > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux")) and the network card > > was working as expected. > > > > It goes without saying that I can help with testing the fix and > > further diagnosing. > > A fix was recently merged for this (see aec3f415f724 ("net: stmmac: > dwmac-rk: Fix ethernet on rk3399 based devices") and should show up in > the next rc. Please shout out if that doesn't fix the broken ethernet > for you. I can confirm that it's now working, many thanks. Alex > > Thanks, > Punit > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D95CC433EF for ; Fri, 8 Oct 2021 09:27:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D567560F58 for ; Fri, 8 Oct 2021 09:27:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D567560F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bOJqG5j5QosehLLqKkWTCxq0Oa7EmV7avl6NURMmzB0=; b=VfX079L7yqUeoK W5TfT5CbfA58S4mug3IxjKpJHAD5DgT51W8RQYRhOBIu2wLJ6mjPnqL1+YzVpY3bTOUSDR7YTJn/P W5An/hre81kFk095EW5xQNiuzntA7h4lvvaEex4lilPCv7QHQhHlM+l6RL1q7XlgbIlz7/VqRJQ9O qYKdkn14eQW8CwB/ogy4PFAvhi25wB3ApYijSPkOkqMlX3BU1sfPGUbHoBa4Mz2YXvi2xdEyHyQvX Gzp+SYN7U3VLT8RH4SbIioeH4H4FiyOQ7nTK+i+fSyiqJpZqw5/yGHuQu2XAjxtHbfg+yJuYgQv9L SyHTg8ELE7gptm+6TH5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYm8s-002AzP-N7; Fri, 08 Oct 2021 09:26:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYm8o-002Ay7-3U for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 09:26:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9DB0D6E; Fri, 8 Oct 2021 02:26:04 -0700 (PDT) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CEA153F70D; Fri, 8 Oct 2021 02:26:01 -0700 (PDT) Date: Fri, 8 Oct 2021 10:27:41 +0100 From: Alexandru Elisei To: Punit Agrawal Cc: davem@davemloft.net, michael.riesch@wolfvision.net, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, p.zabel@pengutronix.de, lgirdwood@gmail.com, Mark Brown , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, arm-mail-list , Linux Kernel Mailing List Subject: Re: [BUG] Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") Message-ID: References: <8e33c244-b786-18e8-79bc-407e27e4756b@arm.com> <87zgrk19yb.fsf@stealth> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87zgrk19yb.fsf@stealth> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_022610_234625_B90E2733 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Punit, On Fri, Oct 08, 2021 at 12:17:48PM +0900, Punit Agrawal wrote: > Alexandru Elisei writes: > > > (Sorry I'm sending this to the wrong person, this is what I got > > scripts/get_maintainer.pl for the file touched by the commit) > > > > After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced > > pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left unable > > to get a DHCP lease from the network. The offending commit was found by bisecting > > the kernel; I tried reverting the commit from current master (commit 0513e464f900 > > ("Merge tag 'perf-tools-fixes-for-v5.15-2021-09-27' of > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux")) and the network card > > was working as expected. > > > > It goes without saying that I can help with testing the fix and > > further diagnosing. > > A fix was recently merged for this (see aec3f415f724 ("net: stmmac: > dwmac-rk: Fix ethernet on rk3399 based devices") and should show up in > the next rc. Please shout out if that doesn't fix the broken ethernet > for you. I can confirm that it's now working, many thanks. Alex > > Thanks, > Punit > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel