From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
anthony.yznaga@oracle.com
Subject: Re: [PATCH v2] mm: Optimise put_pages_list()
Date: Fri, 8 Oct 2021 15:17:14 +0100 [thread overview]
Message-ID: <YWBS6iJr/4RJ+hNE@casper.infradead.org> (raw)
In-Reply-To: <20211007163554.d9088a65f0e293e2bd906a56@linux-foundation.org>
On Thu, Oct 07, 2021 at 04:35:54PM -0700, Andrew Morton wrote:
> On Thu, 7 Oct 2021 21:55:21 +0100 Matthew Wilcox <willy@infradead.org> wrote:
> > My first response is an appeal to authority -- release_pages() does
> > this same thing. Only it takes an array, constructs a list and passes
> > that to put_unref_page_list(). So if that's slower (and lists _are_
> > slower than arrays), we should have a put_unref_page_array().
>
> And put_unref_page_list() does two passes across the list!
>
> <quietly sobs>
>
> Here is my beautiful release_pages(), as disrtibuted in linux-2.5.33:
I think that looks much better!
> I guess the current version is some commentary on the aging process?
I blame the guy who sent cc59850ef940 to Linus back in 2011 ...
I think Anthony was going to look into this and perhaps revert us to
a pagevec_free() interface.
next prev parent reply other threads:[~2021-10-08 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 19:21 [PATCH v2] mm: Optimise put_pages_list() Matthew Wilcox (Oracle)
2021-10-07 19:31 ` Andrew Morton
2021-10-07 20:55 ` Matthew Wilcox
2021-10-07 23:35 ` Andrew Morton
2021-10-08 14:17 ` Matthew Wilcox [this message]
2021-10-20 22:07 ` Anthony Yznaga
2021-10-21 14:41 ` Joao Martins
2021-10-22 23:26 ` Anthony Yznaga
2021-10-23 1:13 ` Matthew Wilcox
2021-10-23 6:11 ` Anthony Yznaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWBS6iJr/4RJ+hNE@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.