From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64471C433F5 for ; Fri, 8 Oct 2021 19:12:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88ED260F4F for ; Fri, 8 Oct 2021 19:12:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 88ED260F4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C3822833B1; Fri, 8 Oct 2021 21:12:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SWvxRUeo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 672B183410; Fri, 8 Oct 2021 21:12:06 +0200 (CEST) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C196E8336D for ; Fri, 8 Oct 2021 21:12:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x434.google.com with SMTP id e12so32686389wra.4 for ; Fri, 08 Oct 2021 12:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=arwkSRMEF486mQxepm9FE8XYirT3oiW8QHlpZ9dfkcs=; b=SWvxRUeo3yiwGM+ZgMM0qkRRlXdc9dmB25+UEmvyPZ7z8aRPihV4y4fXelcXXJrLdK d9UqqIUcJ1t6CSePRyDxAeGSDDsSgairFee7hr/fqKNC3Ervoq0Iwi8Yi9kp2eoyWcid h0Gp1YrWRv9Xap6j9Nc23OKBb3n3gwxG8+ylQBhTUzJ2t3W+3Regpsn7PfOjqnazlNO4 38ota+dtHCenEoHZ+W3R6hb7nzUE4Utiq6RjUmjsNsk8abJAQVEI+1HhUaSp4cGYP8zS 8VKH5lsEaQVJV7uyiHAMA03o19x1IQ2vM0AUeVPbAPjEBCE/dfjlIvUVBqQBhWlttGaN UWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=arwkSRMEF486mQxepm9FE8XYirT3oiW8QHlpZ9dfkcs=; b=iNU6HjhfZc1YuZpSCRYjK1n+1ZGyi+lZZK/iRyoDbCLws64+gmhsdJXRxYyz5orcD+ Zg4oIq+Z6Iva556iT+yD221QLhe4GtR2OxBoniypudN/U0Upv0bx3s5xXWWIKKEePX6i fkaLyQCGgEfeQg7EdDOIzecgyi9g0yzoAVamdzzC9TQXlB0rQ/IjgJyiA/tEMJEVvXhN 1yJu5d4SL5SnXQ0NHCeqzJCtebck/1WdFI+dlg9Ul8m00rMKcvExZGsY6V+695gMoPZ7 RB8WXk4WMArXByHNQdH4Cm6DTHtXJEmsJAW7fIiPzMmWk5UTySAmWb9x+Bh6H0Cmj1Az I/YA== X-Gm-Message-State: AOAM5333+VNJANd9W0Kc0pzcqobbPX9c9t88HxdWnuGxHZZTRJ3LhJ47 WapwydE9GBDQjyJLCeNMbcIqqA== X-Google-Smtp-Source: ABdhPJwoczRL6lH1p4b7a4XqPjdLIfVG2K7iUgn8BYJBkOpPw8Byjqr6327XUnvzPN03PXH4SZhNJg== X-Received: by 2002:a7b:c351:: with SMTP id l17mr5420921wmj.120.1633720322366; Fri, 08 Oct 2021 12:12:02 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-217.home.otenet.gr. [94.66.220.217]) by smtp.gmail.com with ESMTPSA id z18sm185226wro.25.2021.10.08.12.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 12:12:01 -0700 (PDT) Date: Fri, 8 Oct 2021 22:11:59 +0300 From: Ilias Apalodimas To: Simon Glass Cc: AKASHI Takahiro , Heinrich Schuchardt , Alex Graf , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Subject: Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options"" Message-ID: References: <20211007062340.72207-1-takahiro.akashi@linaro.org> <20211007062340.72207-2-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro wrote: > > > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab. > > We have agreed with removing dtb-related stuff from mkeficapsule > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move > > signature from DTB to .rodata"") was applied. > > Can you please explain why this is being removed? How is the public > key to be communicated? Via the script that Akashi-san is adding in this patch series. > > Please can you also copy me on future related patches? (thank for you > for the private email alerting me) > > What does "We have agreed" mean? This has nothing to do with the public key. This is only changing the tool we used to include the key in the DTB. It is the same patch I mentioned you should never have reverted in the first place on your pull request, but since that happened very late in the release cycle we said we would re-apply it after the release. > > > > > Signed-off-by: AKASHI Takahiro > > --- > > tools/mkeficapsule.c | 229 ++----------------------------------------- > > 1 file changed, 7 insertions(+), 222 deletions(-) > > > > Regards, > Simon It was my patch to begin with so I am not really sure my reviewed tag has any value, but FWIW Reviewed-by: Ilias Apalodimas