From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A203C433F5 for ; Sat, 9 Oct 2021 15:39:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E843860F5C for ; Sat, 9 Oct 2021 15:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E843860F5C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0572B6E1B7; Sat, 9 Oct 2021 15:39:19 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A05A6E1B7 for ; Sat, 9 Oct 2021 15:39:17 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 074a5cf0-2917-11ec-ac3c-0050568cd888; Sat, 09 Oct 2021 15:39:02 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id B57BF194BAC; Sat, 9 Oct 2021 17:39:02 +0200 (CEST) Date: Sat, 9 Oct 2021 17:39:12 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Dmitry Baryshkov Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/2] drm/panel: Add support for Sharp LS060T1SX01 panel Message-ID: References: <20210926001005.3442668-1-dmitry.baryshkov@linaro.org> <20210926001005.3442668-3-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210926001005.3442668-3-dmitry.baryshkov@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dmityry, On Sun, Sep 26, 2021 at 03:10:05AM +0300, Dmitry Baryshkov wrote: > Add driver to support Sharp LS06T1SX01 FullHD panel. The panel uses > nt35695 driver IC. For example this LCD module can be found in the > kwaek.ca Dragonboard Display Adapter Bundle. > > Signed-off-by: Dmitry Baryshkov The driver looks fine. It would have been nicer could you have used regulator_bulk - but I guess timing constraints prevents that - right? Please address the following checkpatch warnings: -:181: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #181: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:129: + msleep(1); -:187: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #187: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:135: + msleep(10); -:193: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #193: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:141: + msleep(10); -:210: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #210: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:158: + msleep(10); -:241: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #241: FILE: drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c:189: + msleep(10); I expect patches to be checkpatch --strict clean - or it is mentioned in the changelog otherwise. Sam