All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: heghedus razvan <heghedus.razvan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Chen <peter.chen@nxp.com>,
	Anant Thazhemadam <anant.thazhemadam@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: misc: ehset: Workaround for "special" hubs
Date: Mon, 11 Oct 2021 10:44:23 +0200	[thread overview]
Message-ID: <YWP5Z6IaD3blIfue@hovoldconsulting.com> (raw)
In-Reply-To: <CAACGJgbXEV4rnvkmHy-peaO2GiR7Mt=3Y=Q8w1Bnc9mJLwFPnQ@mail.gmail.com>

[ Please avoid top-posting. ]

On Thu, Oct 07, 2021 at 07:51:00PM +0300, heghedus razvan wrote:
> Hi all,
> 
> This was tested only with some external powered hubs. Indeed for the root
> hub there is
> a problem. I see that in the HCDs in hub_control there is the handling for
> testing
> procedures, but I don't know how they are used for the root hub.

This isn't just an issue with root hubs, the current implementation is
just completely broken for all hubs. Which begs the question of how you
tested this, if at all.

> I want to fix this problem, but I don't know how exactly, because I don't
> have a good
> grasp on the USB code since it's a huge beast. The main problem is how can I
> match the VID:PID of the hub_udev(the hub on which the USB testing device
> was connected) with the hub list for which I need to apply the quirk? I
> tried to
> use usb_match_id because I want to use functionality already in the kernel,
> but it seems that in this context I need to do the checking myself.

You can access the interfaces of a USB device through

	udev->actconfig->interface

but in this case it's probably better to just export
usb_device_match_id(), which seems to be what you need.

Johan

      parent reply	other threads:[~2021-10-11  8:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 12:16 [PATCH v2] usb: misc: ehset: Workaround for "special" hubs Razvan Heghedus
2021-10-07 10:21 ` Johan Hovold
2021-10-07 10:47   ` Greg Kroah-Hartman
     [not found]     ` <CAACGJgbXEV4rnvkmHy-peaO2GiR7Mt=3Y=Q8w1Bnc9mJLwFPnQ@mail.gmail.com>
2021-10-11  8:44       ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWP5Z6IaD3blIfue@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=anant.thazhemadam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heghedus.razvan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.