From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CEAC433EF for ; Mon, 11 Oct 2021 16:56:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7ECC60F38 for ; Mon, 11 Oct 2021 16:56:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E7ECC60F38 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 434D46E903; Mon, 11 Oct 2021 16:56:11 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB0DD6E903 for ; Mon, 11 Oct 2021 16:56:09 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 16fc776d-2ab4-11ec-ac3c-0050568cd888; Mon, 11 Oct 2021 16:55:50 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id BA48B194B88; Mon, 11 Oct 2021 18:55:49 +0200 (CEST) Date: Mon, 11 Oct 2021 18:56:00 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Guido =?iso-8859-1?Q?G=FCnther?= Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Ondrej Jirman , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] mxsfb/nwl/panels: media bus format fixes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Guido, On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido Günther wrote: > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if > present") added bus format probing to mxsfb this exposed several issues in the > display stack as used on the Librem 5: > > The nwl bridge and the panels didn't bother to set any media bus formats and in > that case mxsfb would not pick a reasonable default. This series aims to fix > this. > > This series includes the patch from > https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.org/ > with a `dev_warn` added. > > The patches are against 5.15-rc3. I've marked a single patch with a 'fixes' > which is enough to unbreak the display stack in 5.15. > > All patches of this series can be applied independently. > > Changes from v1: > - Review comment by Marek Vasut > https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03d@denx.de/ > Improve warning message > - Move mxsfb patches to the end of the queue and the actual nwl fix to the > front. > > Changes from v2: > - Review comments by Lucas Stach > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > Drop fixes tag from mxsfb driver and tweak commit message > - Add Reviewed-by from Lucas > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > - Add Reviewd-by from Rober Foss > https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfHBezW+1Hcf3-z91QQ@mail.gmail.com/ > > > > Guido Günther (5): > drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts > drm/panel: mantix: Add media bus format > drm/panel: st7703: Add media bus format > drm: mxsfb: Print failed bus format in hex > drm: mxsfb: Set fallback bus format when the bridge doesn't provide > one Full series are: Reviewed-by: Sam Ravnborg Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCCBC433F5 for ; Mon, 11 Oct 2021 16:58:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3245060F3A for ; Mon, 11 Oct 2021 16:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3245060F3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MyvXtOoEqnoUwIlqHKxkLfJ6PLVot9XujGoiCb3AcmE=; b=S4YnY9q/O8ilSQ 88LmrFBsx+djQIY6PQFpcBSJrnfRZ9c3gDjgzNhTkWvYQAPx6IeNbqMGruoEgcuLZ1hFSEPBGo3vL uCCvD6pBzgqWHobKn/PuzeB7FuW38wtG6yqYutt0jT0OQGh/iUIZxlWKAgGtVR5KHi+vaHSvJjrd5 N2PSI+zf+O9G0pbQus2jJI09vfa5G0kXIdBHOk2uB2K9GrUHC2nvScjjFGZ12tVFOS4uPaL2B5EMm 7v9SRq+rvBJTshT3gxC54RTNnUIEfdR8kfkzJD+/YAAqLAUZPo2ZuTevIcX41Mmy8dLcd7Kv9iRQ5 Beev8pitrSKKckOh049w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZyb4-00A87c-T0; Mon, 11 Oct 2021 16:56:19 +0000 Received: from mx2.smtp.larsendata.com ([91.221.196.228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZyaz-00A86V-Ak for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 16:56:15 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 16fc776d-2ab4-11ec-ac3c-0050568cd888; Mon, 11 Oct 2021 16:55:50 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id BA48B194B88; Mon, 11 Oct 2021 18:55:49 +0200 (CEST) Date: Mon, 11 Oct 2021 18:56:00 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Guido =?iso-8859-1?Q?G=FCnther?= Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Ondrej Jirman , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] mxsfb/nwl/panels: media bus format fixes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_095613_523352_9B254E7C X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guido, On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido G=FCnther wrote: > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge = if > present") added bus format probing to mxsfb this exposed several issues i= n the > display stack as used on the Librem 5: > = > The nwl bridge and the panels didn't bother to set any media bus formats = and in > that case mxsfb would not pick a reasonable default. This series aims to = fix > this. > = > This series includes the patch from > https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.org/ > with a `dev_warn` added. > = > The patches are against 5.15-rc3. I've marked a single patch with a 'fixe= s' > which is enough to unbreak the display stack in 5.15. > = > All patches of this series can be applied independently. > = > Changes from v1: > - Review comment by Marek Vasut > https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03d@= denx.de/ > Improve warning message > - Move mxsfb patches to the end of the queue and the actual nwl fix to the > front. > = > Changes from v2: > - Review comments by Lucas Stach > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/= T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > Drop fixes tag from mxsfb driver and tweak commit message > - Add Reviewed-by from Lucas > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/= T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/= T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/= T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > - Add Reviewd-by from Rober Foss > https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfHBe= zW+1Hcf3-z91QQ@mail.gmail.com/ > = > = > = > Guido G=FCnther (5): > drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts > drm/panel: mantix: Add media bus format > drm/panel: st7703: Add media bus format > drm: mxsfb: Print failed bus format in hex > drm: mxsfb: Set fallback bus format when the bridge doesn't provide > one Full series are: Reviewed-by: Sam Ravnborg Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel