From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5335BC433EF for ; Tue, 12 Oct 2021 10:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3136061076 for ; Tue, 12 Oct 2021 10:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235796AbhJLKXl (ORCPT ); Tue, 12 Oct 2021 06:23:41 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:52856 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232638AbhJLKXk (ORCPT ); Tue, 12 Oct 2021 06:23:40 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 73DC4FB03; Tue, 12 Oct 2021 12:21:36 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lGutAmbmMggN; Tue, 12 Oct 2021 12:21:35 +0200 (CEST) Date: Tue, 12 Oct 2021 12:21:33 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Sam Ravnborg Cc: Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Ondrej Jirman , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] mxsfb/nwl/panels: media bus format fixes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, On Mon, Oct 11, 2021 at 06:56:00PM +0200, Sam Ravnborg wrote: > Hi Guido, > > On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido Günther wrote: > > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if > > present") added bus format probing to mxsfb this exposed several issues in the > > display stack as used on the Librem 5: > > > > The nwl bridge and the panels didn't bother to set any media bus formats and in > > that case mxsfb would not pick a reasonable default. This series aims to fix > > this. > > > > This series includes the patch from > > https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.org/ > > with a `dev_warn` added. > > > > The patches are against 5.15-rc3. I've marked a single patch with a 'fixes' > > which is enough to unbreak the display stack in 5.15. > > > > All patches of this series can be applied independently. > > > > Changes from v1: > > - Review comment by Marek Vasut > > https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03d@denx.de/ > > Improve warning message > > - Move mxsfb patches to the end of the queue and the actual nwl fix to the > > front. > > > > Changes from v2: > > - Review comments by Lucas Stach > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > > Drop fixes tag from mxsfb driver and tweak commit message > > - Add Reviewed-by from Lucas > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > > - Add Reviewd-by from Rober Foss > > https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfHBezW+1Hcf3-z91QQ@mail.gmail.com/ > > > > > > > > Guido Günther (5): > > drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts > > drm/panel: mantix: Add media bus format > > drm/panel: st7703: Add media bus format > > drm: mxsfb: Print failed bus format in hex > > drm: mxsfb: Set fallback bus format when the bridge doesn't provide > > one > > Full series are: > Reviewed-by: Sam Ravnborg Pushed the whole series to drm-misc-next. Thanks, -- Guido > > Sam > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B04CC433FE for ; Tue, 12 Oct 2021 10:23:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5721B61076 for ; Tue, 12 Oct 2021 10:23:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5721B61076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=13E6DPe3bh9ZejTc6rbT3r2cpkZMdaeQIpDNRZx/8ao=; b=kOVPLf+0Z3E1fe 7c1gf7DL8ahcCR0onUXCMGCX1dYTAIFFO185aPaTWJZ6pBu8Bf7XLx+8pPJVNvynxquqTQk5oH1XV hp9bj+vjE3mih7km2HkeWa/5sTTRvauFJXIh8aNzLmTVGR90xaYW+2VXHTeMpy8dQNjepuvLHtBg2 /Lj4XBFPmxQhmqmFYbEfPqrqaXLK3S9F0+Hu/BVhqfjQXM4AgSJpJtLuJIDIGVy7IdA720YoZI/Ey 3FHKvkm9ksEIaO2LEOnnvRRFNiX5r+fpCTC2ENC3Vv2hsbdiupbuZOAiQ3GRZbhR2Qy3u+lDq/Lmz Yo3n6KlJEeyqGiX+PYsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maEum-00CPq1-RO; Tue, 12 Oct 2021 10:21:44 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maEui-00CPoi-Ob for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 10:21:42 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 73DC4FB03; Tue, 12 Oct 2021 12:21:36 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lGutAmbmMggN; Tue, 12 Oct 2021 12:21:35 +0200 (CEST) Date: Tue, 12 Oct 2021 12:21:33 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Sam Ravnborg Cc: Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Ondrej Jirman , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] mxsfb/nwl/panels: media bus format fixes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_032140_980437_88566140 X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, On Mon, Oct 11, 2021 at 06:56:00PM +0200, Sam Ravnborg wrote: > Hi Guido, > = > On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido G=FCnther wrote: > > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridg= e if > > present") added bus format probing to mxsfb this exposed several issues= in the > > display stack as used on the Librem 5: > > = > > The nwl bridge and the panels didn't bother to set any media bus format= s and in > > that case mxsfb would not pick a reasonable default. This series aims t= o fix > > this. > > = > > This series includes the patch from > > https://lore.kernel.org/dri-devel/YVLYh%2FSgBritG%2FRJ@qwark.sigxcpu.or= g/ > > with a `dev_warn` added. > > = > > The patches are against 5.15-rc3. I've marked a single patch with a 'fi= xes' > > which is enough to unbreak the display stack in 5.15. > > = > > All patches of this series can be applied independently. > > = > > Changes from v1: > > - Review comment by Marek Vasut > > https://lore.kernel.org/dri-devel/67e6056a-6157-795d-908d-d65cc803c03= d@denx.de/ > > Improve warning message > > - Move mxsfb patches to the end of the queue and the actual nwl fix to = the > > front. > > = > > Changes from v2: > > - Review comments by Lucas Stach > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.or= g/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > > Drop fixes tag from mxsfb driver and tweak commit message > > - Add Reviewed-by from Lucas > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.or= g/T/#m9f3337a673ae1adbb1f0152a48270b0e1104b0c1 > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.or= g/T/#m5706d5b93cb6879b6bb4a1810b88800fe4180f74 > > https://lore.kernel.org/dri-devel/cover.1633332399.git.agx@sigxcpu.or= g/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2 > > - Add Reviewd-by from Rober Foss > > https://lore.kernel.org/dri-devel/CAG3jFyteqcPNZqrFsggCrnpDfsGGQvibfH= BezW+1Hcf3-z91QQ@mail.gmail.com/ > > = > > = > > = > > Guido G=FCnther (5): > > drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts > > drm/panel: mantix: Add media bus format > > drm/panel: st7703: Add media bus format > > drm: mxsfb: Print failed bus format in hex > > drm: mxsfb: Set fallback bus format when the bridge doesn't provide > > one > = > Full series are: > Reviewed-by: Sam Ravnborg Pushed the whole series to drm-misc-next. Thanks, -- Guido > = > Sam > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel