From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Anju T Sudhakar <anju@linux.vnet.ibm.com>, fstests@vger.kernel.org
Subject: Re: [PATCH 4/4] generic/219: Fix test failure on 64k block size
Date: Tue, 12 Oct 2021 13:33:52 -0400 [thread overview]
Message-ID: <YWXHAIK4Ol+x2qb+@mit.edu> (raw)
In-Reply-To: <20211011083639.GC1164794@dread.disaster.area>
On Mon, Oct 11, 2021 at 07:36:39PM +1100, Dave Chinner wrote:
> On Mon, Oct 11, 2021 at 01:25:52PM +0530, Anju T Sudhakar wrote:
> > Skip this test on 64k, as 4k as taken as the default block size.
> >
> > Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
> > ---
> > But I have a Query:
> > This test fails on ext4&xfs with 64k block size. Do we need to
> > rephrase this test to incorporate the 64k bs scenario as well?
> > If not we can skip this test.
>
> Right, we should fix the test to use multiples of block size rather
> than fixed byte sizes as we do for all the other tests that need to
> work across different block sizes. e.g. probe the block size after
> mkfs and then convert the "48k" numbers to "$((12 * $bs))".
... and then make sure that you understand what the test is trying to
do, and with those changes, audit the test to make sure it is correct
and valid when the block size is as small as 1k, and as large as 64k.
It might require adjusting other parameters, including the size of the
scratch file system, etc.
Cheers,
- Ted
prev parent reply other threads:[~2021-10-12 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 7:55 [PATCH 0/4] Random fixes for xfstest Anju T Sudhakar
2021-10-11 7:55 ` [PATCH 1/4] xfs/432: Skip this test for dax config and pagesize not equal to the specified block size Anju T Sudhakar
2021-10-11 8:27 ` Dave Chinner
2021-10-11 7:55 ` [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools Anju T Sudhakar
2021-10-11 8:32 ` Dave Chinner
2021-10-11 16:46 ` Darrick J. Wong
2021-10-12 2:57 ` Eryu Guan
2021-10-12 5:25 ` xuyang2018.jy
2021-10-11 7:55 ` [PATCH 3/4] generic/600: Fix this test on xfs with " Anju T Sudhakar
2021-10-11 7:55 ` [PATCH 4/4] generic/219: Fix test failure on 64k block size Anju T Sudhakar
2021-10-11 8:36 ` Dave Chinner
2021-10-12 17:33 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWXHAIK4Ol+x2qb+@mit.edu \
--to=tytso@mit.edu \
--cc=anju@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.