From: Kent Overstreet <kent.overstreet@gmail.com>
To: Chris Webb <chris@arachsys.com>
Cc: linux-bcachefs@vger.kernel.org
Subject: Re: Metadata rereplication not triggering
Date: Tue, 12 Oct 2021 14:19:55 -0400 [thread overview]
Message-ID: <YWXRy46DZY7AV+Kf@moria.home.lan> (raw)
In-Reply-To: <20211012090745.GA11670@arachsys.com>
On Tue, Oct 12, 2021 at 10:07:46AM +0100, Chris Webb wrote:
> [Spotted while double-checking c85e27c45512 fixed the rereplicate BUG_ON at
> fs/bcachefs/btree_iter.c:2475 the other day.]
>
> If I create a filesystem with --replicas=2, fail a component drive and
> replace with a new one, then use bcachefs data rereplicate, metadata
> doesn't seem to get copied to the new drive.
It turns out rereplicate_pred() wasn't checking the key types correctly, and it
wasn't rereplicating any of the newer key types - I just pushed a fix. Thanks
for the report and the test!
next prev parent reply other threads:[~2021-10-12 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 9:07 Metadata rereplication not triggering Chris Webb
2021-10-12 9:11 ` [PATCH] [ktest] Test simple drive replacement on a replicated fs Chris Webb
2021-10-12 18:19 ` Kent Overstreet [this message]
2021-10-13 16:52 ` Metadata rereplication not triggering Chris Webb
2021-10-13 17:29 ` Kent Overstreet
2021-10-13 19:39 ` Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWXRy46DZY7AV+Kf@moria.home.lan \
--to=kent.overstreet@gmail.com \
--cc=chris@arachsys.com \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.