From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA53C433F5 for ; Wed, 13 Oct 2021 05:59:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5142C60E53 for ; Wed, 13 Oct 2021 05:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbhJMGBG (ORCPT ); Wed, 13 Oct 2021 02:01:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:49064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhJMGBF (ORCPT ); Wed, 13 Oct 2021 02:01:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D2F5760C4A; Wed, 13 Oct 2021 05:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634104743; bh=/qus41ilY6w21Ca2R+0Q6xIAZtlILxDno5T19N3Hbh0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SpDIVM2VGBPZsKjcC97qrSMhyUjATK0iwjm1dmQcPw52HWoSMTiTYciSLUQ/Ss92d h/EQyXwbDzuXxR5uHYtTdFICsob4rzONLe6Tgq0VLdp50etPD0ZuBDSRx3eRhtpxfH FWtL2YaYFXH1YFJzanaKq6d4doBz3WR0T9JnQV5I= Date: Wed, 13 Oct 2021 07:58:58 +0200 From: Greg KH To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnd Bergmann , Bjorn Andersson , Charles Keepax , Will Deacon , Mark Brown , Liam Girdwood , Simon Trimmer , Michael Ellerman , linux@armlinux.org.uk, catalin.marinas@arm.com, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linus.walleij@linaro.org, geert+renesas@glider.be, rmk+kernel@armlinux.org.uk, akpm@linux-foundation.org, anshuman.khandual@arm.com, mark.rutland@arm.com, ardb@kernel.org, u.kleine-koenig@pengutronix.de, rppt@kernel.org, lukas.bulwahn@gmail.com, wangkefeng.wang@huawei.com, slyfox@gentoo.org, axboe@kernel.dk, ben.widawsky@intel.com, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Message-ID: References: <20211013005532.700190-1-sashal@kernel.org> <20211013005532.700190-11-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013005532.700190-11-sashal@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > From: Arnd Bergmann > > [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ] > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Reviewed-by: Bjorn Andersson > Reviewed-by: Charles Keepax > Acked-by: Will Deacon > Acked-by: Bjorn Andersson > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Charles Keepax > Cc: Simon Trimmer > Cc: Michael Ellerman > Reviewed-by: Mark Brown > Signed-off-by: Arnd Bergmann > Signed-off-by: Sasha Levin > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 002e0cf025f5..d4c6b95b24d7 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE > > endmenu > > -source "drivers/firmware/Kconfig" > - > if CRYPTO > source "arch/arm/crypto/Kconfig" > endif > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5e5cf3af6351..f4809760a806 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 39b25a5a591b..e8014d2e36c0 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -426,8 +426,6 @@ config CRASH_DUMP > help > Generate crash dump after being started by kexec. > > -source "drivers/firmware/Kconfig" > - > endmenu > > menu "Power management and ACPI options" > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 1a63f592034e..3bd3a01a2a2b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "arch/mips/kvm/Kconfig" > > source "arch/mips/vdso/Kconfig" > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index 14f3252f2da0..ad13477fb40c 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -378,6 +378,4 @@ config KEXEC_FILE > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/parisc/Kconfig" > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index f7abd118d23d..fcb8e5da148e 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -428,5 +428,3 @@ menu "Power management options" > source "kernel/power/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index f3c8a8110f60..499f3cc1e62f 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP > def_bool y > depends on X86_32 > > -source "drivers/firmware/Kconfig" > - > source "arch/x86/kvm/Kconfig" > > source "arch/x86/Kconfig.assembler" > diff --git a/drivers/Kconfig b/drivers/Kconfig > index dcecc9f6e33f..493ac7ffd8d0 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig" > > source "drivers/connector/Kconfig" > > +source "drivers/firmware/Kconfig" > + > source "drivers/gnss/Kconfig" > > source "drivers/mtd/Kconfig" > -- > 2.33.0 > This isn't for stable kernels, it should be dropped from all of your AUTOSEL queues. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF44C433EF for ; Wed, 13 Oct 2021 07:29:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F04DC60E53 for ; Wed, 13 Oct 2021 07:29:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F04DC60E53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YyXQWc4ZswBLKOd2BjFv9HHvPKltHPRg3Wxktu56yFs=; b=4ZgyH83OOIbSfk n4nOg8/8mrYf8pPZ/ltFSNkR4Q/UzeIatoEqLqBDaoukzvO+VSEuay8+dSSuxHunEzKU4z/je6VSv JSsBlp+IT0IyNQZcSDDpp6hSc3jezAHO0R72+2FT1ZRulV5Xt9LrYfzRcQ+FgQJ/wgI4vrM9ppfmp 3l6oKj3SXGzyWjc1XTAA8B3ll/oxkqowOJUUyM1UX/fJ2ISbL+FSVqsi7d0EEzOm4fuAZE4KxHB8p MwlSzdbubpi4bYM0pFK2dScPR8ZHTruQr57qQawarVcIJyk4gWvLOSbyisv1cK86GVWp61xZ7I1M6 97qgtraAqHNohml5tFYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYgY-00FMGO-KQ; Wed, 13 Oct 2021 07:28:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXI8-00F3b2-Fm; Wed, 13 Oct 2021 05:59:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D2F5760C4A; Wed, 13 Oct 2021 05:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634104743; bh=/qus41ilY6w21Ca2R+0Q6xIAZtlILxDno5T19N3Hbh0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SpDIVM2VGBPZsKjcC97qrSMhyUjATK0iwjm1dmQcPw52HWoSMTiTYciSLUQ/Ss92d h/EQyXwbDzuXxR5uHYtTdFICsob4rzONLe6Tgq0VLdp50etPD0ZuBDSRx3eRhtpxfH FWtL2YaYFXH1YFJzanaKq6d4doBz3WR0T9JnQV5I= Date: Wed, 13 Oct 2021 07:58:58 +0200 From: Greg KH To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnd Bergmann , Bjorn Andersson , Charles Keepax , Will Deacon , Mark Brown , Liam Girdwood , Simon Trimmer , Michael Ellerman , linux@armlinux.org.uk, catalin.marinas@arm.com, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linus.walleij@linaro.org, geert+renesas@glider.be, rmk+kernel@armlinux.org.uk, akpm@linux-foundation.org, anshuman.khandual@arm.com, mark.rutland@arm.com, ardb@kernel.org, u.kleine-koenig@pengutronix.de, rppt@kernel.org, lukas.bulwahn@gmail.com, wangkefeng.wang@huawei.com, slyfox@gentoo.org, axboe@kernel.dk, ben.widawsky@intel.com, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Message-ID: References: <20211013005532.700190-1-sashal@kernel.org> <20211013005532.700190-11-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013005532.700190-11-sashal@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_225904_619703_5E234AFA X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > From: Arnd Bergmann > > [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ] > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Reviewed-by: Bjorn Andersson > Reviewed-by: Charles Keepax > Acked-by: Will Deacon > Acked-by: Bjorn Andersson > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Charles Keepax > Cc: Simon Trimmer > Cc: Michael Ellerman > Reviewed-by: Mark Brown > Signed-off-by: Arnd Bergmann > Signed-off-by: Sasha Levin > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 002e0cf025f5..d4c6b95b24d7 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE > > endmenu > > -source "drivers/firmware/Kconfig" > - > if CRYPTO > source "arch/arm/crypto/Kconfig" > endif > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5e5cf3af6351..f4809760a806 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 39b25a5a591b..e8014d2e36c0 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -426,8 +426,6 @@ config CRASH_DUMP > help > Generate crash dump after being started by kexec. > > -source "drivers/firmware/Kconfig" > - > endmenu > > menu "Power management and ACPI options" > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 1a63f592034e..3bd3a01a2a2b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "arch/mips/kvm/Kconfig" > > source "arch/mips/vdso/Kconfig" > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index 14f3252f2da0..ad13477fb40c 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -378,6 +378,4 @@ config KEXEC_FILE > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/parisc/Kconfig" > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index f7abd118d23d..fcb8e5da148e 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -428,5 +428,3 @@ menu "Power management options" > source "kernel/power/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index f3c8a8110f60..499f3cc1e62f 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP > def_bool y > depends on X86_32 > > -source "drivers/firmware/Kconfig" > - > source "arch/x86/kvm/Kconfig" > > source "arch/x86/Kconfig.assembler" > diff --git a/drivers/Kconfig b/drivers/Kconfig > index dcecc9f6e33f..493ac7ffd8d0 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig" > > source "drivers/connector/Kconfig" > > +source "drivers/firmware/Kconfig" > + > source "drivers/gnss/Kconfig" > > source "drivers/mtd/Kconfig" > -- > 2.33.0 > This isn't for stable kernels, it should be dropped from all of your AUTOSEL queues. thanks, greg k-h _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E54C433F5 for ; Wed, 13 Oct 2021 07:32:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BD3E6044F for ; Wed, 13 Oct 2021 07:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2BD3E6044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JfmAvv+KmJkDdZ6fsVBJNpdAirkcTStNlIB1NcayAz0=; b=nSNGY+mifoxqEy W0Prr9Xvj+0HXx4RqLdgX5cncIidhMEluy6KrVxhbNvKsx0YnuoceQVv/fA89PkKuDbxtw9L64r1J yjpC8TeJP7VgcQAdvyJz/trvZ7xQT1trOaelwoIWj76qGa1rclf6N5Ujy4g1QfncEhajt8nQU2qGX gtueNnlLGu/W9P0OKDVepPvbbxE+R8zqalzrlhRTPshYaA7Rxg440r8C+G8yL3q9Vnflvjphd1lCL k6IKj8PQ1hibCt2hi6Jhwi/rZwU+RF51VTGwQj1MlNjGo6NdRM5Q0YzVGqc6U+Hji4XsdH3lrPLKW qFmgNLFXDmWCsobcQHdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYfD-00FLnq-Tu; Wed, 13 Oct 2021 07:27:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXI8-00F3b2-Fm; Wed, 13 Oct 2021 05:59:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D2F5760C4A; Wed, 13 Oct 2021 05:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634104743; bh=/qus41ilY6w21Ca2R+0Q6xIAZtlILxDno5T19N3Hbh0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SpDIVM2VGBPZsKjcC97qrSMhyUjATK0iwjm1dmQcPw52HWoSMTiTYciSLUQ/Ss92d h/EQyXwbDzuXxR5uHYtTdFICsob4rzONLe6Tgq0VLdp50etPD0ZuBDSRx3eRhtpxfH FWtL2YaYFXH1YFJzanaKq6d4doBz3WR0T9JnQV5I= Date: Wed, 13 Oct 2021 07:58:58 +0200 From: Greg KH To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnd Bergmann , Bjorn Andersson , Charles Keepax , Will Deacon , Mark Brown , Liam Girdwood , Simon Trimmer , Michael Ellerman , linux@armlinux.org.uk, catalin.marinas@arm.com, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linus.walleij@linaro.org, geert+renesas@glider.be, rmk+kernel@armlinux.org.uk, akpm@linux-foundation.org, anshuman.khandual@arm.com, mark.rutland@arm.com, ardb@kernel.org, u.kleine-koenig@pengutronix.de, rppt@kernel.org, lukas.bulwahn@gmail.com, wangkefeng.wang@huawei.com, slyfox@gentoo.org, axboe@kernel.dk, ben.widawsky@intel.com, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Message-ID: References: <20211013005532.700190-1-sashal@kernel.org> <20211013005532.700190-11-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013005532.700190-11-sashal@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_225904_619703_5E234AFA X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > From: Arnd Bergmann > > [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ] > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Reviewed-by: Bjorn Andersson > Reviewed-by: Charles Keepax > Acked-by: Will Deacon > Acked-by: Bjorn Andersson > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Charles Keepax > Cc: Simon Trimmer > Cc: Michael Ellerman > Reviewed-by: Mark Brown > Signed-off-by: Arnd Bergmann > Signed-off-by: Sasha Levin > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 002e0cf025f5..d4c6b95b24d7 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE > > endmenu > > -source "drivers/firmware/Kconfig" > - > if CRYPTO > source "arch/arm/crypto/Kconfig" > endif > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5e5cf3af6351..f4809760a806 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 39b25a5a591b..e8014d2e36c0 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -426,8 +426,6 @@ config CRASH_DUMP > help > Generate crash dump after being started by kexec. > > -source "drivers/firmware/Kconfig" > - > endmenu > > menu "Power management and ACPI options" > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 1a63f592034e..3bd3a01a2a2b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "arch/mips/kvm/Kconfig" > > source "arch/mips/vdso/Kconfig" > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index 14f3252f2da0..ad13477fb40c 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -378,6 +378,4 @@ config KEXEC_FILE > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/parisc/Kconfig" > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index f7abd118d23d..fcb8e5da148e 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -428,5 +428,3 @@ menu "Power management options" > source "kernel/power/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index f3c8a8110f60..499f3cc1e62f 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP > def_bool y > depends on X86_32 > > -source "drivers/firmware/Kconfig" > - > source "arch/x86/kvm/Kconfig" > > source "arch/x86/Kconfig.assembler" > diff --git a/drivers/Kconfig b/drivers/Kconfig > index dcecc9f6e33f..493ac7ffd8d0 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig" > > source "drivers/connector/Kconfig" > > +source "drivers/firmware/Kconfig" > + > source "drivers/gnss/Kconfig" > > source "drivers/mtd/Kconfig" > -- > 2.33.0 > This isn't for stable kernels, it should be dropped from all of your AUTOSEL queues. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 13 Oct 2021 05:58:58 +0000 Subject: Re: [PATCH AUTOSEL 5.10 11/11] firmware: include drivers/firmware/Kconfig unconditionally Message-Id: List-Id: References: <20211013005532.700190-1-sashal@kernel.org> <20211013005532.700190-11-sashal@kernel.org> In-Reply-To: <20211013005532.700190-11-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnd Bergmann , Bjorn Andersson , Charles Keepax , Will Deacon , Mark Brown , Liam Girdwood , Simon Trimmer , Michael Ellerman , linux@armlinux.org.uk, catalin.marinas@arm.com, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linus.walleij@linaro.org, geert+renesas@glider.be, rmk+kernel@armlinux.org.uk, akpm@linux-foundation.org, anshuman.khandual@arm.com, mark.rutland@arm.com, ardb@kernel.org, u.kleine-koenig@pengutronix.de, rppt@kernel.org, lukas.bulwahn@gmail.com, wangkefeng.wang@huawei.com, slyfox@gentoo.org, axboe@kernel.dk, ben.widawsky@intel.com, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org On Tue, Oct 12, 2021 at 08:55:31PM -0400, Sasha Levin wrote: > From: Arnd Bergmann > > [ Upstream commit 951cd3a0866d29cb9c01ebc1d9c17590e598226e ] > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Reviewed-by: Bjorn Andersson > Reviewed-by: Charles Keepax > Acked-by: Will Deacon > Acked-by: Bjorn Andersson > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Charles Keepax > Cc: Simon Trimmer > Cc: Michael Ellerman > Reviewed-by: Mark Brown > Signed-off-by: Arnd Bergmann > Signed-off-by: Sasha Levin > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 002e0cf025f5..d4c6b95b24d7 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -2043,8 +2043,6 @@ config ARCH_HIBERNATION_POSSIBLE > > endmenu > > -source "drivers/firmware/Kconfig" > - > if CRYPTO > source "arch/arm/crypto/Kconfig" > endif > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5e5cf3af6351..f4809760a806 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1933,8 +1933,6 @@ source "drivers/cpufreq/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 39b25a5a591b..e8014d2e36c0 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -426,8 +426,6 @@ config CRASH_DUMP > help > Generate crash dump after being started by kexec. > > -source "drivers/firmware/Kconfig" > - > endmenu > > menu "Power management and ACPI options" > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 1a63f592034e..3bd3a01a2a2b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -3328,8 +3328,6 @@ source "drivers/cpuidle/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "arch/mips/kvm/Kconfig" > > source "arch/mips/vdso/Kconfig" > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index 14f3252f2da0..ad13477fb40c 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -378,6 +378,4 @@ config KEXEC_FILE > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/parisc/Kconfig" > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index f7abd118d23d..fcb8e5da148e 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -428,5 +428,3 @@ menu "Power management options" > source "kernel/power/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index f3c8a8110f60..499f3cc1e62f 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2899,8 +2899,6 @@ config HAVE_ATOMIC_IOMAP > def_bool y > depends on X86_32 > > -source "drivers/firmware/Kconfig" > - > source "arch/x86/kvm/Kconfig" > > source "arch/x86/Kconfig.assembler" > diff --git a/drivers/Kconfig b/drivers/Kconfig > index dcecc9f6e33f..493ac7ffd8d0 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -16,6 +16,8 @@ source "drivers/bus/Kconfig" > > source "drivers/connector/Kconfig" > > +source "drivers/firmware/Kconfig" > + > source "drivers/gnss/Kconfig" > > source "drivers/mtd/Kconfig" > -- > 2.33.0 > This isn't for stable kernels, it should be dropped from all of your AUTOSEL queues. thanks, greg k-h