* [PATCH v1 1/1] device property: Add missed header in fwnode.h
@ 2021-10-13 14:37 Andy Shevchenko
2021-10-13 17:21 ` Saravana Kannan
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2021-10-13 14:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Saravana Kannan, linux-acpi, linux-kernel
Cc: Rafael J. Wysocki, Len Brown, Andy Shevchenko
When adding some stuff to the header file we must not rely on
implicit dependencies that are happen by luck or bugs in other
headers. Hence fwnode.h needs to use bits.h directly.
Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
Cc: Saravana Kannan <saravanak@google.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/fwnode.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 9f4ad719bfe3..3a532ba66f6c 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -11,6 +11,7 @@
#include <linux/types.h>
#include <linux/list.h>
+#include <linux/bits.h>
#include <linux/err.h>
struct fwnode_operations;
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h
2021-10-13 14:37 [PATCH v1 1/1] device property: Add missed header in fwnode.h Andy Shevchenko
@ 2021-10-13 17:21 ` Saravana Kannan
2021-10-13 17:30 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Saravana Kannan @ 2021-10-13 17:21 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Greg Kroah-Hartman, linux-acpi, linux-kernel, Rafael J. Wysocki,
Len Brown
On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When adding some stuff to the header file we must not rely on
> implicit dependencies that are happen by luck or bugs in other
> headers. Hence fwnode.h needs to use bits.h directly.
>
> Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
> Cc: Saravana Kannan <saravanak@google.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Saravana Kannan <saravanak@google.com>
-Saravana
> ---
> include/linux/fwnode.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 9f4ad719bfe3..3a532ba66f6c 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -11,6 +11,7 @@
>
> #include <linux/types.h>
> #include <linux/list.h>
> +#include <linux/bits.h>
> #include <linux/err.h>
>
> struct fwnode_operations;
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h
2021-10-13 17:21 ` Saravana Kannan
@ 2021-10-13 17:30 ` Rafael J. Wysocki
2021-10-13 17:34 ` Saravana Kannan
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2021-10-13 17:30 UTC (permalink / raw)
To: Saravana Kannan, Andy Shevchenko
Cc: Greg Kroah-Hartman, ACPI Devel Maling List,
Linux Kernel Mailing List, Rafael J. Wysocki, Len Brown
On Wed, Oct 13, 2021 at 7:21 PM Saravana Kannan <saravanak@google.com> wrote:
>
> On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > When adding some stuff to the header file we must not rely on
> > implicit dependencies that are happen by luck or bugs in other
> > headers. Hence fwnode.h needs to use bits.h directly.
> >
> > Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
> > Cc: Saravana Kannan <saravanak@google.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Saravana Kannan <saravanak@google.com>
I'm going to pick this up, thanks!
> > ---
> > include/linux/fwnode.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> > index 9f4ad719bfe3..3a532ba66f6c 100644
> > --- a/include/linux/fwnode.h
> > +++ b/include/linux/fwnode.h
> > @@ -11,6 +11,7 @@
> >
> > #include <linux/types.h>
> > #include <linux/list.h>
> > +#include <linux/bits.h>
> > #include <linux/err.h>
> >
> > struct fwnode_operations;
> > --
> > 2.33.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h
2021-10-13 17:30 ` Rafael J. Wysocki
@ 2021-10-13 17:34 ` Saravana Kannan
2021-10-13 18:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Saravana Kannan @ 2021-10-13 17:34 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Andy Shevchenko, Greg Kroah-Hartman, ACPI Devel Maling List,
Linux Kernel Mailing List, Len Brown
On Wed, Oct 13, 2021 at 10:31 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, Oct 13, 2021 at 7:21 PM Saravana Kannan <saravanak@google.com> wrote:
> >
> > On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > When adding some stuff to the header file we must not rely on
> > > implicit dependencies that are happen by luck or bugs in other
> > > headers. Hence fwnode.h needs to use bits.h directly.
> > >
> > > Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
> > > Cc: Saravana Kannan <saravanak@google.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Acked-by: Saravana Kannan <saravanak@google.com>
>
> I'm going to pick this up, thanks!
>
I think Greg already picked it up.
-Saravana
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h
2021-10-13 17:34 ` Saravana Kannan
@ 2021-10-13 18:18 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-10-13 18:18 UTC (permalink / raw)
To: Saravana Kannan
Cc: Rafael J. Wysocki, Andy Shevchenko, ACPI Devel Maling List,
Linux Kernel Mailing List, Len Brown
On Wed, Oct 13, 2021 at 10:34:54AM -0700, Saravana Kannan wrote:
> On Wed, Oct 13, 2021 at 10:31 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Wed, Oct 13, 2021 at 7:21 PM Saravana Kannan <saravanak@google.com> wrote:
> > >
> > > On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > >
> > > > When adding some stuff to the header file we must not rely on
> > > > implicit dependencies that are happen by luck or bugs in other
> > > > headers. Hence fwnode.h needs to use bits.h directly.
> > > >
> > > > Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
> > > > Cc: Saravana Kannan <saravanak@google.com>
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Acked-by: Saravana Kannan <saravanak@google.com>
> >
> > I'm going to pick this up, thanks!
> >
>
> I think Greg already picked it up.
I did, but multiple people can :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-13 18:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 14:37 [PATCH v1 1/1] device property: Add missed header in fwnode.h Andy Shevchenko
2021-10-13 17:21 ` Saravana Kannan
2021-10-13 17:30 ` Rafael J. Wysocki
2021-10-13 17:34 ` Saravana Kannan
2021-10-13 18:18 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.