From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C7EC433F5 for ; Wed, 13 Oct 2021 18:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3250361165 for ; Wed, 13 Oct 2021 18:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238658AbhJMSU5 (ORCPT ); Wed, 13 Oct 2021 14:20:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:52104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238387AbhJMSU4 (ORCPT ); Wed, 13 Oct 2021 14:20:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 04AF161165; Wed, 13 Oct 2021 18:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634149133; bh=h43zpChNzyMQTIytYSLNOFwek9CqlNQr5TsiPcTFR6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=evt+nFVPa6UAau0wcLmzcJcAovJsoFMrrD+QlA50TSj3Ru8/Pz7p0oZoACJX18G+5 Gb+V2/yh+yjOBZ2zeX53OZMQn5wDpjMhlSzWMz6n2WKvhIgQcXLRsFgo3PCWkk0Lms e810yLZrGIFpZhSvFnDBvoKUQkrvXne141Nz4rf8= Date: Wed, 13 Oct 2021 20:18:50 +0200 From: Greg Kroah-Hartman To: Saravana Kannan Cc: "Rafael J. Wysocki" , Andy Shevchenko , ACPI Devel Maling List , Linux Kernel Mailing List , Len Brown Subject: Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h Message-ID: References: <20211013143707.80222-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Oct 13, 2021 at 10:34:54AM -0700, Saravana Kannan wrote: > On Wed, Oct 13, 2021 at 10:31 AM Rafael J. Wysocki wrote: > > > > On Wed, Oct 13, 2021 at 7:21 PM Saravana Kannan wrote: > > > > > > On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko > > > wrote: > > > > > > > > When adding some stuff to the header file we must not rely on > > > > implicit dependencies that are happen by luck or bugs in other > > > > headers. Hence fwnode.h needs to use bits.h directly. > > > > > > > > Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()") > > > > Cc: Saravana Kannan > > > > Signed-off-by: Andy Shevchenko > > > > > > Acked-by: Saravana Kannan > > > > I'm going to pick this up, thanks! > > > > I think Greg already picked it up. I did, but multiple people can :) thanks, greg k-h