From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE6B5C433EF for ; Thu, 14 Oct 2021 14:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89A6B60EE5 for ; Thu, 14 Oct 2021 14:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbhJNOg0 (ORCPT ); Thu, 14 Oct 2021 10:36:26 -0400 Received: from mga14.intel.com ([192.55.52.115]:54348 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbhJNOgY (ORCPT ); Thu, 14 Oct 2021 10:36:24 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="227970933" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="227970933" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 07:34:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="481278966" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga007.jf.intel.com with SMTP; 14 Oct 2021 07:34:15 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 14 Oct 2021 17:34:14 +0300 Date: Thu, 14 Oct 2021 17:34:14 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Borislav Petkov Cc: Ser Olmy , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [regression] commit d298b03506d3 ("x86/fpu: Restore the masking out of reserved MXCSR bits") Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 14, 2021 at 04:27:07PM +0200, Borislav Petkov wrote: > On Thu, Oct 14, 2021 at 02:44:33PM +0300, Ville Syrjälä wrote: > > I have a 32bit installation here that stopped working. Bisected it > > to commit d298b03506d3 ("x86/fpu: Restore the masking out of reserved > > MXCSR bits"). > > Lemme make sure I understand this correctly: this patch is bad and with > it reverted it works? Yes. > > Because before this patch, the restoring would be a more restrictive > than before and this patch reverts the code to the old behavior for > invalid MXCSR bits. > > > Tested the same disk on on both a 64bit capable Pentium D > > and a 32bit only Pentium 4 just to rule out the specific CPU. > > Busted on both. > > So that's a purely 32-bit installation and a 32-bit kernel and you've > booted it on two different machines? Yes. -- Ville Syrjälä Intel