From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Antoine Tenart <atenart@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sean Anderson <sean.anderson@seco.com>,
netdev@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH v2 1/2] net: macb: Clean up macb_validate
Date: Thu, 14 Oct 2021 17:34:27 +0100 [thread overview]
Message-ID: <YWhcEzZzrE5lMxD4@shell.armlinux.org.uk> (raw)
In-Reply-To: <163402758460.4280.9175185858026827934@kwain>
On Tue, Oct 12, 2021 at 10:33:04AM +0200, Antoine Tenart wrote:
> Hello Sean,
>
> Quoting Sean Anderson (2021-10-11 18:55:16)
> > As the number of interfaces grows, the number of if statements grows
> > ever more unweildy. Clean everything up a bit by using a switch
> > statement. No functional change intended.
>
> I'm not 100% convinced this makes macb_validate more readable: there are
> lots of conditions, and jumps, in the switch.
>
> Maybe you could try a mixed approach; keeping the invalid modes checks
> (bitmap_zero) at the beginning and once we know the mode is valid using
> a switch statement. That might make it easier to read as this should
> remove lots of conditionals. (We'll still have the one/_NA checks
> though).
Some of this could be improved if we add the ability for a MAC to
specify the phy_interface_t modes that it supports as a bitmap
before calling phylink_create() - then we can have phylink check
that the mode is supported itself prior to calling the validate
handler.
You can find some patches that add the "supported_interfaces" masks
in git.armlinux.org.uk/linux-arm.git net-queue
and we could add to phylink_validate():
if (!phy_interface_empty(pl->config->supported_interfaces) &&
!test_bit(state->interface, pl->config->supported_interfaces))
return -EINVAL;
which should go a long way to simplifying a lot of these validation
implementations.
Any thoughts on that?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-10-14 16:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 16:55 [PATCH v2 1/2] net: macb: Clean up macb_validate Sean Anderson
2021-10-11 16:55 ` [PATCH v2 2/2] net: macb: Allow SGMII only if we are a GEM in mac_validate Sean Anderson
2021-10-12 0:17 ` Jakub Kicinski
2021-10-12 8:27 ` Antoine Tenart
2021-10-12 16:20 ` Sean Anderson
2021-10-12 8:33 ` [PATCH v2 1/2] net: macb: Clean up macb_validate Antoine Tenart
2021-10-12 8:34 ` Antoine Tenart
2021-10-12 9:24 ` Nicolas Ferre
2021-10-12 16:34 ` Sean Anderson
2021-10-12 16:53 ` Antoine Tenart
2021-10-14 16:34 ` Russell King (Oracle) [this message]
2021-10-14 17:50 ` Sean Anderson
2021-10-14 23:08 ` Russell King (Oracle)
2021-10-15 22:28 ` Sean Anderson
2021-10-15 22:47 ` Russell King (Oracle)
2021-10-19 15:02 ` Russell King (Oracle)
2021-10-22 17:37 ` Sean Anderson
2021-10-25 10:35 ` Russell King (Oracle)
2021-10-25 15:26 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWhcEzZzrE5lMxD4@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=atenart@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.