From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB06C433EF for ; Fri, 15 Oct 2021 08:51:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 264556109E for ; Fri, 15 Oct 2021 08:51:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 264556109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7908D6ECFF; Fri, 15 Oct 2021 08:51:15 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECCEF6ECFE; Fri, 15 Oct 2021 08:51:14 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="288743507" X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="288743507" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 01:51:14 -0700 X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="492379684" Received: from tscherue-mobl.ger.corp.intel.com (HELO intel.com) ([10.249.44.3]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 01:51:11 -0700 Date: Fri, 15 Oct 2021 10:51:08 +0200 From: Andi Shyti To: Lucas De Marchi Cc: Andi Shyti , Andi Shyti , Intel GFX , DRI Devel , Tvrtko Ursulin , Chris Wilson Subject: Re: [Intel-gfx] [PATCH v5] drm/i915/gt: move remaining debugfs interfaces into gt Message-ID: References: <20211012221738.16029-1-andi@etezian.org> <20211014000427.652zp2ahlq7g2cvd@ldmartin-desk2> <20211015045450.ew5n7plkbllshms2@ldmartin-desk2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015045450.ew5n7plkbllshms2@ldmartin-desk2> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Lucas, > > > > The following interfaces: > > > > > > > > i915_wedged > > > > i915_forcewake_user > > > > > > > > are dependent on gt values. Put them inside gt/ and drop the > > > > "i915_" prefix name. This would be the new structure: > > > > > > > > dri/0/gt > > > > | > > > > +-- forcewake_user > > > > | > > > > \-- reset > > > > > > > > For backwards compatibility with existing igt (and the slight > > > > semantic difference between operating on the i915 abi entry > > > > points and the deep gt info): > > > > > > > > dri/0 > > > > | > > > > +-- i915_wedged > > > > | > > > > \-- i915_forcewake_user > > > > > > > > remain at the top level. > > > > > > > > Signed-off-by: Andi Shyti > > > > Cc: Tvrtko Ursulin > > > > Cc: Chris Wilson > > > > Reviewed-by: Lucas De Marchi > > > > > > do you want me to push this? > > > > yes, please. > > done, thanks. Thanks! > Now, about igt: eventually we need to update it to use the gt > debugfs file. Is this something you have already or is it something > we are waiting on multi-gt to land? There is some work done in igt but it's all around multitile. I think it's better to wait for the multitile to land and then update igt. In any case, at the current state, igt shouldn't be affected. Thanks again, Andi