From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF814C433F5 for ; Sat, 16 Oct 2021 19:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91D2A604DB for ; Sat, 16 Oct 2021 19:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240638AbhJPTTF (ORCPT ); Sat, 16 Oct 2021 15:19:05 -0400 Received: from rosenzweig.io ([138.197.143.207]:47016 "EHLO rosenzweig.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232336AbhJPTTC (ORCPT ); Sat, 16 Oct 2021 15:19:02 -0400 Received: by rosenzweig.io (Postfix, from userid 1000) id DA8B341012; Sat, 16 Oct 2021 19:16:53 +0000 (UTC) Date: Sat, 16 Oct 2021 19:16:53 +0000 From: Alyssa Rosenzweig To: Jassi Brar Cc: Sven Peter , Rob Herring , Mark Kettenis , Hector Martin , Mohamed Mediouni , Stan Skowronek , Devicetree List , linux-arm-kernel , Linux Kernel Mailing List Subject: Re: [PATCH v2 2/2] mailbox: apple: Add driver for Apple mailboxes Message-ID: References: <20210916154911.3168-1-sven@svenpeter.dev> <20210916154911.3168-3-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +struct apple_mbox_msg { > > + u64 msg0; > > + u32 msg1; > > +}; > > + > Aren't msg0/1 the Tx and Rx channels? If so you may want to separate > them out as such. But of course, I don't know the h/w details so I may > be wrong. AIUI -- It's a 96-bit message (msg0 is general purpose, msg1 is used for dispatch). This goes for both RX and TX. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF105C433F5 for ; Sat, 16 Oct 2021 19:18:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D41C60F35 for ; Sat, 16 Oct 2021 19:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D41C60F35 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rosenzweig.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p+pBz5KFDEf4BztwaeN1FcUGJ1gUX58Div/k5hS4Ong=; b=Zbj8YhdDOWi3ax +vkR179ekAWSMEluWdprXD8ackc9gXU/woDEEijfCETuRkNBUG/ROUIL/jzPMXe1hRZ/5BWkVnA/V P4vfwiWn/ySx7m9EmNCdgDaxpoh5ieySatQVMjh9onZRlVqMkZTL+XANtNjpJkZZCyoW3nCctGCdZ qtsILij9HLFmnjrkDNfgrO4FXxHPlQZQjCGVSD2duTc2o1eFi+r0krlQhPoUDBfJOnEDpyWMohoDR Udv/OL/vUlPA/d9N5fmCKK2yM6a9k3ayGE5L2i7O02XX1+gtK9wD4dUprQeZDdR0qdPodUHCZBpns VkURSRY7rZIvM2IfJQ1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbpB7-00BBPf-Al; Sat, 16 Oct 2021 19:17:09 +0000 Received: from rosenzweig.io ([138.197.143.207]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbpB3-00BBOw-Ie for linux-arm-kernel@lists.infradead.org; Sat, 16 Oct 2021 19:17:07 +0000 Received: by rosenzweig.io (Postfix, from userid 1000) id DA8B341012; Sat, 16 Oct 2021 19:16:53 +0000 (UTC) Date: Sat, 16 Oct 2021 19:16:53 +0000 From: Alyssa Rosenzweig To: Jassi Brar Cc: Sven Peter , Rob Herring , Mark Kettenis , Hector Martin , Mohamed Mediouni , Stan Skowronek , Devicetree List , linux-arm-kernel , Linux Kernel Mailing List Subject: Re: [PATCH v2 2/2] mailbox: apple: Add driver for Apple mailboxes Message-ID: References: <20210916154911.3168-1-sven@svenpeter.dev> <20210916154911.3168-3-sven@svenpeter.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211016_121705_711576_FCD5420F X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > +struct apple_mbox_msg { > > + u64 msg0; > > + u32 msg1; > > +}; > > + > Aren't msg0/1 the Tx and Rx channels? If so you may want to separate > them out as such. But of course, I don't know the h/w details so I may > be wrong. AIUI -- It's a 96-bit message (msg0 is general purpose, msg1 is used for dispatch). This goes for both RX and TX. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel