From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E120FC433FE for ; Sun, 17 Oct 2021 14:02:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8C1861250 for ; Sun, 17 Oct 2021 14:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242523AbhJQOE5 (ORCPT ); Sun, 17 Oct 2021 10:04:57 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:36301 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232132AbhJQOEz (ORCPT ); Sun, 17 Oct 2021 10:04:55 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5112E20005; Sun, 17 Oct 2021 14:02:42 +0000 (UTC) Date: Sun, 17 Oct 2021 16:02:42 +0200 From: Alexandre Belloni To: Greg KH Cc: William Breathitt Gray , jic23@kernel.org, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter Subject: Re: [PATCH v17 2/9] counter: Add character device interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/2021 15:50:11+0200, Greg KH wrote: > Note, review of this now that it has been submitted in a pull request to > me, sorry I missed this previously... > > On Wed, Sep 29, 2021 at 12:15:59PM +0900, William Breathitt Gray wrote: > > +static int counter_chrdev_open(struct inode *inode, struct file *filp) > > +{ > > + struct counter_device *const counter = container_of(inode->i_cdev, > > + typeof(*counter), > > + chrdev); > > + > > + /* Ensure chrdev is not opened more than 1 at a time */ > > + if (!atomic_add_unless(&counter->chrdev_lock, 1, 1)) > > + return -EBUSY; > > I understand the feeling that you wish to stop userspace from doing > this, but really, it does not work. Eventhough you are doing this > correctly (you should see all the other attempts at doing this), you are > not preventing userspace from having multiple processes access this > device node at the same time, so please, don't even attempt to stop this > from happening. > > So you can drop the atomic "lock" you have here, it's not needed at all. > Could you elaborate a bit here because we've had a similar thing in the RTC subsystem: https://elixir.bootlin.com/linux/latest/source/drivers/rtc/dev.c#L28 And it would mean I can remove rtc->flags completely. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B35CCC433EF for ; Sun, 17 Oct 2021 14:04:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79AFD61247 for ; Sun, 17 Oct 2021 14:04:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 79AFD61247 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XoLMMW/iHjBW3FPPif+J4y3HdSZwlku5Gw04KmLGlvs=; b=3Od9f9hnEeVeTn f4lBIGBpY/mkkrneEFEpFZzDW/pGae3LsNEwCvQfKEFk/pxHgG1taat6RgBVMbGfwBa2saG7YW3MO uXGl/KhWXwf893HDUFo1+5uK/j8107Bn/AFIUE3UFbL/gqQZOxXFX3MWD0kZY5FiYaiUuRrk5wvVX rBK6hV3K3aQGucOo4Wmm96WYQt2jC8z1fdpbGCfhrXiYbpA8FgO75G6ZXqO0dUoMuPG8SZVvwk0pZ j1nkz/Xryd8E9SMszbNw+y8TsNiJ68NKQfD0le8WjN0DeAx/gfsTcU5HBBOlG98u/K6urfZbpdWh7 7OsHCri0Kb5nlwuOiIOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mc6kY-00CjT9-CW; Sun, 17 Oct 2021 14:02:54 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mc6kT-00CjRo-MH for linux-arm-kernel@lists.infradead.org; Sun, 17 Oct 2021 14:02:52 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5112E20005; Sun, 17 Oct 2021 14:02:42 +0000 (UTC) Date: Sun, 17 Oct 2021 16:02:42 +0200 From: Alexandre Belloni To: Greg KH Cc: William Breathitt Gray , jic23@kernel.org, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter Subject: Re: [PATCH v17 2/9] counter: Add character device interface Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211017_070249_905358_191A9214 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/10/2021 15:50:11+0200, Greg KH wrote: > Note, review of this now that it has been submitted in a pull request to > me, sorry I missed this previously... > > On Wed, Sep 29, 2021 at 12:15:59PM +0900, William Breathitt Gray wrote: > > +static int counter_chrdev_open(struct inode *inode, struct file *filp) > > +{ > > + struct counter_device *const counter = container_of(inode->i_cdev, > > + typeof(*counter), > > + chrdev); > > + > > + /* Ensure chrdev is not opened more than 1 at a time */ > > + if (!atomic_add_unless(&counter->chrdev_lock, 1, 1)) > > + return -EBUSY; > > I understand the feeling that you wish to stop userspace from doing > this, but really, it does not work. Eventhough you are doing this > correctly (you should see all the other attempts at doing this), you are > not preventing userspace from having multiple processes access this > device node at the same time, so please, don't even attempt to stop this > from happening. > > So you can drop the atomic "lock" you have here, it's not needed at all. > Could you elaborate a bit here because we've had a similar thing in the RTC subsystem: https://elixir.bootlin.com/linux/latest/source/drivers/rtc/dev.c#L28 And it would mean I can remove rtc->flags completely. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel