From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF920C433EF for ; Mon, 1 Nov 2021 11:13:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93703610A8 for ; Mon, 1 Nov 2021 11:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231964AbhKALP5 (ORCPT ); Mon, 1 Nov 2021 07:15:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:42518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbhKALPy (ORCPT ); Mon, 1 Nov 2021 07:15:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D937960C41; Mon, 1 Nov 2021 11:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635765201; bh=NispMSSM3f4yPtuU4e/ZHhw/LHg6vk+i5/TW9NlGTPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kTWNsW0jtNaC3TAwn+fNlc4PpNdgREWDRRqW4c1qA3xN9A+NVzlwhfUEA6DFlWEDH aSbHz2bTI96OzpWj7wey0p/bu3anZPdk0pB1hvdZBCkg90Vuj+uOODnVjEuauvHFCE 9ISy9oDDAlUyW0yRxPO9/THJ0pJpE7BmkfUOat1c= Date: Mon, 1 Nov 2021 12:13:14 +0100 From: Greg Kroah-Hartman To: Suzuki K Poulose Cc: Will Deacon , Catalin Marinas , Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> <20211101094045.GB27400@willie-the-truck> <55cc7816-cc7a-3161-71cc-0c969ec131a2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55cc7816-cc7a-3161-71cc-0c969ec131a2@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 09:52:22AM +0000, Suzuki K Poulose wrote: > On 01/11/2021 09:40, Will Deacon wrote: > > On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > > > On 01/11/2021 09:01, Will Deacon wrote: > > > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > > > From: Arnd Bergmann > > > > > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > > > > > Reviewed-by: Suzuki K Poulose > > > > > > Tested-by: Suzuki K Poulose > > > > > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > > > it could go via the arm64 tree. > > > > > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > > > merging window, though he could take it as a fix afterwards. > > > > > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > > > go through the coresight tree. > > > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > > --- > > > > > > > Not sure if we actually want this to be exported, this is my local > > > > > > > workaround for the randconfig build bot. > > > > > > > --- > > > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > > > return false; > > > > > > > } > > > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > > > specialised than cpus_have_const_cap(). > > > > > > > > > > With that: > > > > > > > > > > Acked-by: Catalin Marinas > > > > > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > > > So with the _GPL export: > > > > > > > > Acked-by: Will Deacon > > > > > > > > If that doesn't work for some reason, I can take it next week after the > > > > initial arm64 queue has been merged. Please just let me know. > > > > > > As I understand correctly, this will now need to go via arm64 tree. The > > > CoreSight tree changes are pulled into Greg's tree and the next it will > > > happen is for the next release. Usually the fixes don't end up there > > > during the -rc cycles. So, I believe it is better if this goes via > > > arm64. > > > > Hmm, are you saying that Coresight drivers don't receive fixes outside of > > the merge window? That sounds sub-optimal... > > Unfortunately thats how it works today. We should fix this. > > Mathieu, Greg, > > Do you have any thoughts on how to address this ? What? That's crazy, if there are bugfixes needed of course I would take them during the -rc cycle, that is explicitly what it is there for! It's up to the maintainer of the subsystem to send me the fixes to get into the -final kernel release, I don't pick them up on my own unless asked to by them. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A038C433F5 for ; Mon, 1 Nov 2021 11:16:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4FD660C41 for ; Mon, 1 Nov 2021 11:16:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4FD660C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P0yTHJtLqC2w3uku3+Ntyidh4odUlu9JeqX1DqV7Zm8=; b=CaIcQoEkKchDI7 he0efbFHJBeZLoH+7SrmZsbNb4IDGSzbgmYTzLszReQPCx7rj5ud43JL+kq+ADy0BSuI22hJ3aMKW 3uP5inLvYm95ch4K4ioCeE1zntqCta6NtJ9MP9+zhSulxH5RGJ/ll3dbM4AuwdZ85TWcwpQxW/Jm7 +IZKsNBhQq/BKS4UW4zv3oWViEUjCtfLUtKq8LVTGncWcfpk/Cuh0kteVg3RuNOnbjvPhkOXkWXUP msOKpLmx3FUbl7tPiJobyBEbefLrGCXHrQaTlvjUQ7KTypr1CkXHZQQDATlwI9Xgb2d8ZT3pQnIBu oee9E1lowpP3+cldUx1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhVFk-00G56n-VD; Mon, 01 Nov 2021 11:13:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhVFh-00G56A-Gr for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 11:13:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D937960C41; Mon, 1 Nov 2021 11:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635765201; bh=NispMSSM3f4yPtuU4e/ZHhw/LHg6vk+i5/TW9NlGTPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kTWNsW0jtNaC3TAwn+fNlc4PpNdgREWDRRqW4c1qA3xN9A+NVzlwhfUEA6DFlWEDH aSbHz2bTI96OzpWj7wey0p/bu3anZPdk0pB1hvdZBCkg90Vuj+uOODnVjEuauvHFCE 9ISy9oDDAlUyW0yRxPO9/THJ0pJpE7BmkfUOat1c= Date: Mon, 1 Nov 2021 12:13:14 +0100 From: Greg Kroah-Hartman To: Suzuki K Poulose Cc: Will Deacon , Catalin Marinas , Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> <20211101094045.GB27400@willie-the-truck> <55cc7816-cc7a-3161-71cc-0c969ec131a2@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <55cc7816-cc7a-3161-71cc-0c969ec131a2@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_041321_636507_6B50BDE7 X-CRM114-Status: GOOD ( 42.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 01, 2021 at 09:52:22AM +0000, Suzuki K Poulose wrote: > On 01/11/2021 09:40, Will Deacon wrote: > > On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > > > On 01/11/2021 09:01, Will Deacon wrote: > > > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > > > From: Arnd Bergmann > > > > > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > > > > > Reviewed-by: Suzuki K Poulose > > > > > > Tested-by: Suzuki K Poulose > > > > > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > > > it could go via the arm64 tree. > > > > > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > > > merging window, though he could take it as a fix afterwards. > > > > > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > > > go through the coresight tree. > > > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > > --- > > > > > > > Not sure if we actually want this to be exported, this is my local > > > > > > > workaround for the randconfig build bot. > > > > > > > --- > > > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > > > return false; > > > > > > > } > > > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > > > specialised than cpus_have_const_cap(). > > > > > > > > > > With that: > > > > > > > > > > Acked-by: Catalin Marinas > > > > > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > > > So with the _GPL export: > > > > > > > > Acked-by: Will Deacon > > > > > > > > If that doesn't work for some reason, I can take it next week after the > > > > initial arm64 queue has been merged. Please just let me know. > > > > > > As I understand correctly, this will now need to go via arm64 tree. The > > > CoreSight tree changes are pulled into Greg's tree and the next it will > > > happen is for the next release. Usually the fixes don't end up there > > > during the -rc cycles. So, I believe it is better if this goes via > > > arm64. > > > > Hmm, are you saying that Coresight drivers don't receive fixes outside of > > the merge window? That sounds sub-optimal... > > Unfortunately thats how it works today. We should fix this. > > Mathieu, Greg, > > Do you have any thoughts on how to address this ? What? That's crazy, if there are bugfixes needed of course I would take them during the -rc cycle, that is explicitly what it is there for! It's up to the maintainer of the subsystem to send me the fixes to get into the -final kernel release, I don't pick them up on my own unless asked to by them. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel