From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58AB1C433F5 for ; Mon, 1 Nov 2021 13:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32B476112F for ; Mon, 1 Nov 2021 13:55:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231370AbhKAN6E (ORCPT ); Mon, 1 Nov 2021 09:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231366AbhKAN6D (ORCPT ); Mon, 1 Nov 2021 09:58:03 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68D0FC061714; Mon, 1 Nov 2021 06:55:30 -0700 (PDT) Received: from zn.tnic (p200300ec2f0cfa00550d50f28aca2b2a.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:fa00:550d:50f2:8aca:2b2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D02BC1EC0372; Mon, 1 Nov 2021 14:55:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1635774928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GcU1HWR5qISsDwTHBiKEg0sBai14OP3L0fM0QZX4Ol4=; b=g/e5Vr8DDlHPO8e9O2574sKCmZupwyOws8NUFT0VlaThZsQVTgTc6DxawEV0bEDjFpwO2i 5QAX5PlDEluAbZmTZRvvsdYy6wp7ZreqlKJSFYR1zdIPDeYaJgDKjGbrJczKAQGNh2hrNK 6rheWjYP3HBic0N8dgpxodhEE6OyWpo= Date: Mon, 1 Nov 2021 14:55:26 +0100 From: Borislav Petkov To: Xuesong Chen Cc: Will Deacon , helgaas@kernel.org, catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, james.morse@arm.com, rafael@kernel.org, tony.luck@intel.com, mingo@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/4] PCI MCFG consolidation and APEI resource filtering Message-ID: References: <20211027081035.53370-1-xuesong.chen@linux.alibaba.com> <20211101093618.GA27400@willie-the-truck> <286ac625-e712-d7e9-2f5d-923f1572b5d1@linux.alibaba.com> <19fde29a-5a63-3fe7-2e83-307a974c80ad@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19fde29a-5a63-3fe7-2e83-307a974c80ad@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Nov 01, 2021 at 09:32:31PM +0800, Xuesong Chen wrote: > Actually that's my original intention There's a misunderstanding here - I don't think your original intention is to get ignored indefinitely. > especially when you take lots of serious effors to rework it round by > round, but no one say YES or NO, which is really frustrating. Well, try to put yourself in the maintainer's shoes, maybe that would answer some of that frustration: - Most of the maintainers are overworked and backlogged until forever. - If you rework something and you don't get an answer, maybe the maintainer is not sure yet and is thinking about the pros and cons of taking that patch. Greg has formulated this particular issue of the maintainers very nicely: "Seriously. It's easier for the maintainer to not accept your code at all. To accept it, it takes time to review it, apply it, send it on up the development chain, handle any problems that might happen with the patch, accept responsibility for the patch, possibly fix any problems that happen later on when you disappear, and maintain it for the next 20 years. That's a lot of work that you are asking someone else to do on your behalf… So your goal is, when sending a patch, to give me no excuse to not accept it. To make it such that if I ignore it, or reject it, I am the one that is the problem here, not you." And this thing is not really clear to all submitters - once their patch(es) is applied, they're done. But maintainers have to deal with that code forever. So before you send your patchset, try to think as a maintainer and think whether your change makes sense for the *whole* tree and whether maintaining it forward would be easy. - Did I say that maintainers are overworked? Submitters don't see the amount of work maintainers do in the background, testing everything and fixing build issues and bugs. Because most of the time, submitters submit and the cleanups and bugs get mopped after them by the maintainers - not the submitters. Look at how some trees resort to maintainer *groups* because a single maintainer simply doesn't scale, at the risk of a burnout or whatever nasty. And those maintainer groups have *all* their hands full. > Hopefully the newbies can also be treated fairly in the community. Newbies are treated fairly in the community - especially those who come prepared and try to understand why the maintainers say things they way they do and listen to feedback. If there are examples against that, we would all like to know about them. I sincerely hope that explains the situation and hope that it'll help you see it from the maintainers' POV too and maybe help you deal with future submissions a lot better. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFF1C433EF for ; Mon, 1 Nov 2021 13:57:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C2AB60E8C for ; Mon, 1 Nov 2021 13:57:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C2AB60E8C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yv1bL+oB2gaRh+A4JkOMESfoUygjm8706Ea7goP0j2M=; b=n2a3ip7yl9F13x gqSrDVDoR5qYovwBSQXtSjxOrt2aGxE0ZfFitAIJcpqrwD8qdZ3m4ZtfV5aSRnHsyUzcKhavokuIU wI7EYwATzf9x9xkMvtZfnQRG86CojIfq1LTROs3AXk6veuE7wtRrpI4mfzQN6VMijfPi5mlR8W6zJ mP95VE4zdvK2Cx1LA3JJ49JK8jez4U3VVmVZf08vjiuNE9lMZJsuEdoblBkiGbA/Tc+oQLwURgZz5 K5AT7BKYdebSFHT7iPxKYSxQ5w3idyU/VZ0FTWDB+RvIl+3jUFDWJqbNDs8NUOB/SX6hvqQClEhez qQ1sgy8iFFH0Ov0AzgaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhXmg-00GVjy-FS; Mon, 01 Nov 2021 13:55:34 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhXmc-00GVhs-Rd for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 13:55:32 +0000 Received: from zn.tnic (p200300ec2f0cfa00550d50f28aca2b2a.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:fa00:550d:50f2:8aca:2b2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D02BC1EC0372; Mon, 1 Nov 2021 14:55:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1635774928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GcU1HWR5qISsDwTHBiKEg0sBai14OP3L0fM0QZX4Ol4=; b=g/e5Vr8DDlHPO8e9O2574sKCmZupwyOws8NUFT0VlaThZsQVTgTc6DxawEV0bEDjFpwO2i 5QAX5PlDEluAbZmTZRvvsdYy6wp7ZreqlKJSFYR1zdIPDeYaJgDKjGbrJczKAQGNh2hrNK 6rheWjYP3HBic0N8dgpxodhEE6OyWpo= Date: Mon, 1 Nov 2021 14:55:26 +0100 From: Borislav Petkov To: Xuesong Chen Cc: Will Deacon , helgaas@kernel.org, catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, james.morse@arm.com, rafael@kernel.org, tony.luck@intel.com, mingo@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/4] PCI MCFG consolidation and APEI resource filtering Message-ID: References: <20211027081035.53370-1-xuesong.chen@linux.alibaba.com> <20211101093618.GA27400@willie-the-truck> <286ac625-e712-d7e9-2f5d-923f1572b5d1@linux.alibaba.com> <19fde29a-5a63-3fe7-2e83-307a974c80ad@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19fde29a-5a63-3fe7-2e83-307a974c80ad@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_065531_080326_D3A0E350 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDEsIDIwMjEgYXQgMDk6MzI6MzFQTSArMDgwMCwgWHVlc29uZyBDaGVuIHdy b3RlOgo+IEFjdHVhbGx5IHRoYXQncyBteSBvcmlnaW5hbCBpbnRlbnRpb24KClRoZXJlJ3MgYSBt aXN1bmRlcnN0YW5kaW5nIGhlcmUgLSBJIGRvbid0IHRoaW5rIHlvdXIgb3JpZ2luYWwgaW50ZW50 aW9uCmlzIHRvIGdldCBpZ25vcmVkIGluZGVmaW5pdGVseS4KCj4gZXNwZWNpYWxseSB3aGVuIHlv dSB0YWtlIGxvdHMgb2Ygc2VyaW91cyBlZmZvcnMgdG8gcmV3b3JrIGl0IHJvdW5kIGJ5Cj4gcm91 bmQsIGJ1dCBubyBvbmUgc2F5IFlFUyBvciBOTywgd2hpY2ggaXMgcmVhbGx5IGZydXN0cmF0aW5n LgoKV2VsbCwgdHJ5IHRvIHB1dCB5b3Vyc2VsZiBpbiB0aGUgbWFpbnRhaW5lcidzIHNob2VzLCBt YXliZSB0aGF0IHdvdWxkCmFuc3dlciBzb21lIG9mIHRoYXQgZnJ1c3RyYXRpb246CgotIE1vc3Qg b2YgdGhlIG1haW50YWluZXJzIGFyZSBvdmVyd29ya2VkIGFuZCBiYWNrbG9nZ2VkIHVudGlsIGZv cmV2ZXIuCgotIElmIHlvdSByZXdvcmsgc29tZXRoaW5nIGFuZCB5b3UgZG9uJ3QgZ2V0IGFuIGFu c3dlciwgbWF5YmUgdGhlCm1haW50YWluZXIgaXMgbm90IHN1cmUgeWV0IGFuZCBpcyB0aGlua2lu ZyBhYm91dCB0aGUgcHJvcyBhbmQgY29ucyBvZgp0YWtpbmcgdGhhdCBwYXRjaC4KCkdyZWcgaGFz IGZvcm11bGF0ZWQgdGhpcyBwYXJ0aWN1bGFyIGlzc3VlIG9mIHRoZSBtYWludGFpbmVycyB2ZXJ5 Cm5pY2VseToKCiJTZXJpb3VzbHkuIEl0J3MgZWFzaWVyIGZvciB0aGUgbWFpbnRhaW5lciB0byBu b3QgYWNjZXB0IHlvdXIgY29kZSBhdAphbGwuIFRvIGFjY2VwdCBpdCwgaXQgdGFrZXMgdGltZSB0 byByZXZpZXcgaXQsIGFwcGx5IGl0LCBzZW5kIGl0IG9uIHVwCnRoZSBkZXZlbG9wbWVudCBjaGFp biwgaGFuZGxlIGFueSBwcm9ibGVtcyB0aGF0IG1pZ2h0IGhhcHBlbiB3aXRoIHRoZQpwYXRjaCwg YWNjZXB0IHJlc3BvbnNpYmlsaXR5IGZvciB0aGUgcGF0Y2gsIHBvc3NpYmx5IGZpeCBhbnkgcHJv YmxlbXMKdGhhdCBoYXBwZW4gbGF0ZXIgb24gd2hlbiB5b3UgZGlzYXBwZWFyLCBhbmQgbWFpbnRh aW4gaXQgZm9yIHRoZSBuZXh0IDIwCnllYXJzLgoKVGhhdCdzIGEgbG90IG9mIHdvcmsgdGhhdCB5 b3UgYXJlIGFza2luZyBzb21lb25lIGVsc2UgdG8gZG8gb24geW91cgpiZWhhbGbigKYKClNvIHlv dXIgZ29hbCBpcywgd2hlbiBzZW5kaW5nIGEgcGF0Y2gsIHRvIGdpdmUgbWUgbm8gZXhjdXNlIHRv IG5vdAphY2NlcHQgaXQuIFRvIG1ha2UgaXQgc3VjaCB0aGF0IGlmIEkgaWdub3JlIGl0LCBvciBy ZWplY3QgaXQsIEkgYW0gdGhlCm9uZSB0aGF0IGlzIHRoZSBwcm9ibGVtIGhlcmUsIG5vdCB5b3Uu IgoKQW5kIHRoaXMgdGhpbmcgaXMgbm90IHJlYWxseSBjbGVhciB0byBhbGwgc3VibWl0dGVycyAt IG9uY2UgdGhlaXIKcGF0Y2goZXMpIGlzIGFwcGxpZWQsIHRoZXkncmUgZG9uZS4gQnV0IG1haW50 YWluZXJzIGhhdmUgdG8gZGVhbCB3aXRoCnRoYXQgY29kZSBmb3JldmVyLgoKU28gYmVmb3JlIHlv dSBzZW5kIHlvdXIgcGF0Y2hzZXQsIHRyeSB0byB0aGluayBhcyBhIG1haW50YWluZXIgYW5kCnRo aW5rIHdoZXRoZXIgeW91ciBjaGFuZ2UgbWFrZXMgc2Vuc2UgZm9yIHRoZSAqd2hvbGUqIHRyZWUg YW5kIHdoZXRoZXIKbWFpbnRhaW5pbmcgaXQgZm9yd2FyZCB3b3VsZCBiZSBlYXN5LgoKLSBEaWQg SSBzYXkgdGhhdCBtYWludGFpbmVycyBhcmUgb3ZlcndvcmtlZD8KClN1Ym1pdHRlcnMgZG9uJ3Qg c2VlIHRoZSBhbW91bnQgb2Ygd29yayBtYWludGFpbmVycyBkbyBpbiB0aGUKYmFja2dyb3VuZCwg dGVzdGluZyBldmVyeXRoaW5nIGFuZCBmaXhpbmcgYnVpbGQgaXNzdWVzIGFuZCBidWdzLiBCZWNh dXNlCm1vc3Qgb2YgdGhlIHRpbWUsIHN1Ym1pdHRlcnMgc3VibWl0IGFuZCB0aGUgY2xlYW51cHMg YW5kIGJ1Z3MgZ2V0IG1vcHBlZAphZnRlciB0aGVtIGJ5IHRoZSBtYWludGFpbmVycyAtIG5vdCB0 aGUgc3VibWl0dGVycy4KCkxvb2sgYXQgaG93IHNvbWUgdHJlZXMgcmVzb3J0IHRvIG1haW50YWlu ZXIgKmdyb3VwcyogYmVjYXVzZSBhIHNpbmdsZQptYWludGFpbmVyIHNpbXBseSBkb2Vzbid0IHNj YWxlLCBhdCB0aGUgcmlzayBvZiBhIGJ1cm5vdXQgb3Igd2hhdGV2ZXIKbmFzdHkuCgpBbmQgdGhv c2UgbWFpbnRhaW5lciBncm91cHMgaGF2ZSAqYWxsKiB0aGVpciBoYW5kcyBmdWxsLgoKPiBIb3Bl ZnVsbHkgdGhlIG5ld2JpZXMgY2FuIGFsc28gYmUgdHJlYXRlZCBmYWlybHkgaW4gdGhlIGNvbW11 bml0eS4KCk5ld2JpZXMgYXJlIHRyZWF0ZWQgZmFpcmx5IGluIHRoZSBjb21tdW5pdHkgLSBlc3Bl Y2lhbGx5IHRob3NlIHdobyBjb21lCnByZXBhcmVkIGFuZCB0cnkgdG8gdW5kZXJzdGFuZCB3aHkg dGhlIG1haW50YWluZXJzIHNheSB0aGluZ3MgdGhleSB3YXkKdGhleSBkbyBhbmQgbGlzdGVuIHRv IGZlZWRiYWNrLgoKSWYgdGhlcmUgYXJlIGV4YW1wbGVzIGFnYWluc3QgdGhhdCwgd2Ugd291bGQg YWxsIGxpa2UgdG8ga25vdyBhYm91dAp0aGVtLgoKSSBzaW5jZXJlbHkgaG9wZSB0aGF0IGV4cGxh aW5zIHRoZSBzaXR1YXRpb24gYW5kIGhvcGUgdGhhdCBpdCdsbCBoZWxwCnlvdSBzZWUgaXQgZnJv bSB0aGUgbWFpbnRhaW5lcnMnIFBPViB0b28gYW5kIG1heWJlIGhlbHAgeW91IGRlYWwgd2l0aApm dXR1cmUgc3VibWlzc2lvbnMgYSBsb3QgYmV0dGVyLgoKVGh4LgoKLS0gClJlZ2FyZHMvR3J1c3Ms CiAgICBCb3Jpcy4KCmh0dHBzOi8vcGVvcGxlLmtlcm5lbC5vcmcvdGdseC9ub3Rlcy1hYm91dC1u ZXRpcXVldHRlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==