All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs/249: test btrfs filesystem usage command on missing seed device
Date: Wed, 20 Oct 2021 14:44:56 -0400	[thread overview]
Message-ID: <YXBjqOuaSwH4iIut@localhost.localdomain> (raw)
In-Reply-To: <990d5851-5168-c51e-eb5d-f72eac2f327f@oracle.com>

On Wed, Oct 20, 2021 at 10:58:56PM +0800, Anand Jain wrote:
> 
> 
> On 20/10/2021 21:53, Josef Bacik wrote:
> > On Wed, Oct 20, 2021 at 03:16:44PM +0800, Anand Jain wrote:
> > > If there is a missing seed device in a sprout, the btrfs filesystem usage
> > > command fails, which is fixed by the following patches:
> > > 
> > >    btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
> > >    btrfs-progs: read fsid from the sysfs in device_is_seed
> > > 
> > > Test if it works now after these patches in the kernel and in the
> > > btrfs-progs respectively.
> > > 
> > > Suggested-by: Josef Bacik <josef@toxicpanda.com>
> > > Signed-off-by: Anand Jain <anand.jain@oracle.com>
> > 
> > Shouldn't this use
> > 
> > 
> > as well?  I wish there was a way to detect that btrfs-progs had support for
> > reading it but I suppose this is a good enough gate.  Maybe add a
> 
>  _require_btrfs_sysfs_fsid ?
> 
> The problem is about the nonexistence of the sysfs interface to read fsid.
> Adding it will fail to reproduce the problem.
> 
> So if there is no sysfs interface, then btrfs-progs will fail back to the
> read-sb method, which shall expose it to fail.
> 

Sigh sorry, I typed this out and then decided I wanted to comment below, and
forgot to delete this bit.

Yeah sorry I'm thinking about it in terms of the CI testing for us, we'll start
failing this test once its merged without the fix merged, but I guess that's
kinda what we want.  Let's just leave this as it is.  Thanks,

Josef

  reply	other threads:[~2021-10-20 18:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  7:16 [PATCH 0/3] fstests: btrfs validate sysfs fsid and usage Anand Jain
2021-10-20  7:16 ` [PATCH 1/3] common/btrfs: add _require_btrfs_sysfs_fsid helper Anand Jain
2021-10-20  7:16 ` [PATCH 2/3] btrfs/248: validate sysfs fsid Anand Jain
2021-10-20  7:16 ` [PATCH 3/3] btrfs/249: test btrfs filesystem usage command on missing seed device Anand Jain
2021-10-20 13:53   ` Josef Bacik
2021-10-20 14:58     ` Anand Jain
2021-10-20 18:44       ` Josef Bacik [this message]
2021-10-20 18:45 ` [PATCH 0/3] fstests: btrfs validate sysfs fsid and usage Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXBjqOuaSwH4iIut@localhost.localdomain \
    --to=josef@toxicpanda.com \
    --cc=anand.jain@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.