From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA04C433EF for ; Thu, 21 Oct 2021 10:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0033960F6E for ; Thu, 21 Oct 2021 10:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230325AbhJUKWH (ORCPT ); Thu, 21 Oct 2021 06:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230265AbhJUKWC (ORCPT ); Thu, 21 Oct 2021 06:22:02 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 848E2C061749 for ; Thu, 21 Oct 2021 03:19:46 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id r10so173314wra.12 for ; Thu, 21 Oct 2021 03:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dhSbBeMpplIN9aEwtuPqKPrB7V0aSld0d2iKsObDAz8=; b=IzO7FxkWxXu9C1yvUIWIZbVpp9dq+rKGM2iKblt88BzkyvV1Mb52e5LKbzmQPk4+cY K4ODB6ssl44/amMfOzPf2tMUSaun3bfe9sTJmxHFEokRudqhLy5bs+k7csSYPs87sDcp l8pvcXIBI0lioTsR11rhm8P5oNqAY6XtHOuchGB/E79nCrAFTm/hFwqSAJ04lKTrRxZA 1PrGiyHgksNd1PfWfiSV57KTZpixc36Nrhcuyu3rE4OqnDuW4SgLg7IUheEpCKC4dBBT /NTYNcfHK+rySTuelBdIkBS1VbukfKn1XdxvDkM+nPZGV09P/GT0AcrMKEiibpka8l2m lZPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dhSbBeMpplIN9aEwtuPqKPrB7V0aSld0d2iKsObDAz8=; b=yMvBB5Oaw7ao7KOYgW7OfJLro7EU8mrVDxgzKHuPanWm3lzp2+CeBNHLN1ZaeuWKSB shgEZhmnvE653WXHjsLjIOZGxNQtVG03JPexfI2VkZqC9r6q6f7KP/hFJ2/HNzIFEdiJ sr/7zLlbL+XkjFhLy63vIVbayZoL7ylfuweLyeLpmGvMZ+Oc6YaH8XjWUO3kGsAic33f SISxtwap5ESycFVqG/L7uDTUP/scczL01FnZryLIFgfiqwMMESjdZh5H4BOecDM+mQsV 4a6ER8ojD0En90SUeFLbCRtAsV8HfzuR2yAdWKEZm8xQGNSHYAGkdMQNVIIfPsj6Idz0 tWEw== X-Gm-Message-State: AOAM530SlGmLSnL4pIc+uxDjAlOnP/Gr9VpnfNg3pmYutHFyKgn9Dj+o TYzwVsQPWxhusVOb+kxOTiRxPA== X-Google-Smtp-Source: ABdhPJzzoNdFzbYSoa90Y5/EikrCF6/C/9sHXw10OXLzZnwA91JbnU/+ft+cqY65JdASL2ktQP8ZlA== X-Received: by 2002:adf:8b1a:: with SMTP id n26mr6222253wra.182.1634811585166; Thu, 21 Oct 2021 03:19:45 -0700 (PDT) Received: from google.com ([95.148.6.207]) by smtp.gmail.com with ESMTPSA id p188sm494257wmp.30.2021.10.21.03.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 03:19:44 -0700 (PDT) Date: Thu, 21 Oct 2021 11:19:43 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Mark Brown , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 10/20] mfd: tps65912: Make tps65912_device_exit() return void Message-ID: References: <20211012153945.2651412-1-u.kleine-koenig@pengutronix.de> <20211012153945.2651412-11-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211012153945.2651412-11-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2021, Uwe Kleine-König wrote: > Up to now tps65912_device_exit() returns zero unconditionally. Make it > return void instead which makes it easier to see in the callers that > there is no error to handle. > > Also the return value of i2c and spi remove callbacks is ignored anyway. > > Signed-off-by: Uwe Kleine-König > --- > drivers/mfd/tps65912-core.c | 4 +--- > drivers/mfd/tps65912-i2c.c | 4 +++- > drivers/mfd/tps65912-spi.c | 4 +++- > include/linux/mfd/tps65912.h | 2 +- > 4 files changed, 8 insertions(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog