From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318E6C433EF for ; Thu, 21 Oct 2021 14:15:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0E9F61208 for ; Thu, 21 Oct 2021 14:15:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0E9F61208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdYqp-0001ee-Ky for qemu-devel@archiver.kernel.org; Thu, 21 Oct 2021 10:15:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdYni-0007I0-D4 for qemu-devel@nongnu.org; Thu, 21 Oct 2021 10:12:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdYnf-0002BW-5v for qemu-devel@nongnu.org; Thu, 21 Oct 2021 10:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634825525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u7Y56i4Csh40Uvjp3XxZjCEigNkEfxJvqLUOJ7r1voM=; b=cNvurHFTNDq3Nj5lo5sHfW1e+7L2qREWpsC5kHd2Gud160qwEuAbUHq//18CQVzqKEM18H QLGd0Qme2zgQcgWAAZUFBqbwUz3jYNFFqcHT5DlPUzKwFTlol5hc/tVFyof/8XwJp7VPZ7 qT1dTMhmX5h50N5egyrHiijboZ21bFw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-xiemzdDPNTWLEJRiJlmeQA-1; Thu, 21 Oct 2021 10:12:02 -0400 X-MC-Unique: xiemzdDPNTWLEJRiJlmeQA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19E411922025; Thu, 21 Oct 2021 14:12:00 +0000 (UTC) Received: from localhost (unknown [10.39.195.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2783E5F4EB; Thu, 21 Oct 2021 14:11:58 +0000 (UTC) Date: Thu, 21 Oct 2021 15:11:58 +0100 From: Stefan Hajnoczi To: Emanuele Giuseppe Esposito Subject: Re: [PATCH v3 02/25] include/block/block: split header into I/O and global state API Message-ID: References: <20211012084906.2060507-1-eesposit@redhat.com> <20211012084906.2060507-3-eesposit@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211012084906.2060507-3-eesposit@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tkHjZHzhaurbizGi" Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Vladimir Sementsov-Ogievskiy , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , qemu-block@nongnu.org, Juan Quintela , qemu-devel@nongnu.org, John Snow , Richard Henderson , Markus Armbruster , "Dr. David Alan Gilbert" , Hanna Reitz , Paolo Bonzini , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --tkHjZHzhaurbizGi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 12, 2021 at 04:48:43AM -0400, Emanuele Giuseppe Esposito wrote: > block.h currently contains a mix of functions: > some of them run under the BQL and modify the block layer graph, > others are instead thread-safe and perform I/O in iothreads. > It is not easy to understand which function is part of which > group (I/O vs GS), and this patch aims to clarify it. >=20 > The "GS" functions need the BQL, and often use > aio_context_acquire/release and/or drain to be sure they > can modify the graph safely. > The I/O function are instead thread safe, and can run in > any AioContext. >=20 > By splitting the header in two files, block-io.h > and block-global-state.h we have a clearer view on what > needs what kind of protection. block-common.h > instead contains common structures shared by both headers. >=20 > block.h is left there for legacy and to avoid changing > all includes in all c files that use the block APIs. >=20 > Assertions are added in the next patch. >=20 > Signed-off-by: Emanuele Giuseppe Esposito > --- > block.c | 3 + > block/meson.build | 7 +- > include/block/block-common.h | 389 +++++++++++++ > include/block/block-global-state.h | 263 +++++++++ > include/block/block-io.h | 283 ++++++++++ > include/block/block.h | 863 +---------------------------- > 6 files changed, 947 insertions(+), 861 deletions(-) > create mode 100644 include/block/block-common.h > create mode 100644 include/block/block-global-state.h > create mode 100644 include/block/block-io.h Modulo Eric's comments: Reviewed-by: Stefan Hajnoczi --tkHjZHzhaurbizGi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmFxdS4ACgkQnKSrs4Gr c8g1hwf+NVBA9HI3at98Jrhu8sLs/h+RUUaXzIjE9l4Uw9iAjd6DdYC2XT2xn99S ma198uQJ0cvQcYiqRPPgkZTpP9zjLNOSdMKxHY4fdZGMzDe3lPQDTzy3hFJRGLwT O+L4aVFscToDejMmX9XTdDWwn2UY9+waQZCP0NpJA5Oyr2EHC7z+UriOu38XiIF2 fNNOdq7NgolfeBlRa8r9H1mgG5lMAtOMIgUN39Hkd3Vrr43D2k6CKWby7tY5mFJC h2jPNVM+T+b26mBU0caNEsA2z7AP3h7u+uYi3ZpagZ5qG6C/zCqsBEoAmRg9ll3w kroE17511kK8o86o9DbCx+GSNbtU3g== =YNok -----END PGP SIGNATURE----- --tkHjZHzhaurbizGi--