From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0825AC433FE for ; Mon, 25 Oct 2021 12:16:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83B0B6108B for ; Mon, 25 Oct 2021 12:16:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83B0B6108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A867016CD; Mon, 25 Oct 2021 14:16:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A867016CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635164210; bh=c20Y+CBVP1rQ3q8ZreYoK6aSKZoxnVw1Pl+dYFfGyI8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NHYnfYlmPeoyMV8Np6ktb+uri84/3WDDf0m90E0MTHOAI/NsnCh70tlq4oSSyODVX Qpf+yXKS1zhcl00iIDmOzjljVWxOoZYgFi9kStKWUp6QZbz81yDdzU9PcLGNNaloBS MBmlqGwjojYCoXfhm9uGQk0Zs1AbgZmaWUpwnnRQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 415B3F80166; Mon, 25 Oct 2021 14:16:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C340AF8025A; Mon, 25 Oct 2021 14:15:56 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0C99F8010A for ; Mon, 25 Oct 2021 14:15:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0C99F8010A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AgYEfspL" Received: by mail.kernel.org (Postfix) with ESMTPSA id C53F960FDA; Mon, 25 Oct 2021 12:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635164147; bh=c20Y+CBVP1rQ3q8ZreYoK6aSKZoxnVw1Pl+dYFfGyI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AgYEfspLjhU5wHqVSWk4XHgkr9RIWttYase0BwKdwZm/S6EtipiEIqPj0kck11s1b /hlXYuydR2V655dcrr3vN1YBfl4U0FYbfadkfPJXmwSWIJFZz5mt7U5fTzYWUlV/PY qD+eLmuXEeUMApLNp5PGLbpD/5bRunCKJBzejrlYN/eyWjC9ZRTHBeGsP81vAxRCzp IeJGLQ8/YgtbJCpIHM7tUlN+1Tgp8Sm3DaPjGzZhyxXOsS2w0fKsiHrctX61V0wdqW sR+1UmjkPWoWCtqRx0E9yA9XWM9H78wf+ZhPPZahJelxPdVyUwFY4w2FtWfydyjIen Khbw8DQsNM5eA== Date: Mon, 25 Oct 2021 13:15:44 +0100 From: Mark Brown To: David Lin Subject: Re: [PATCH 1/2] ASoC: nau8825: add set_jack coponment support Message-ID: References: <20211025113857.3860951-1-CTLIN0@nuvoton.com> <20211025113857.3860951-2-CTLIN0@nuvoton.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iZzbKOFQQ2wp/57I" Content-Disposition: inline In-Reply-To: <20211025113857.3860951-2-CTLIN0@nuvoton.com> X-Cookie: From concentrate. Cc: alsa-devel@alsa-project.org, WTLI@nuvoton.com, SJLIN0@nuvoton.com, KCHSU0@nuvoton.com, lgirdwood@gmail.com, YHCHuang@nuvoton.com, mac.chiang@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --iZzbKOFQQ2wp/57I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 25, 2021 at 07:38:57PM +0800, David Lin wrote: > Use set_jack ops to set jack for new machine drivers. Meanwhile, > the old machine drivers can still call previous export function > "nau8825_enable_jack_detect". >=20 > Signed-off-by: David Lin > Signed-off-by: Mac Chiang > --- > sound/soc/codecs/nau8825.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c > index 67de0e49ccf4..e7a6bd918be3 100644 > --- a/sound/soc/codecs/nau8825.c > +++ b/sound/soc/codecs/nau8825.c > @@ -1434,6 +1434,12 @@ int nau8825_enable_jack_detect(struct snd_soc_comp= onent *component, > =20 > nau8825->jack =3D jack; > =20 > + if (!nau8825->jack) { > + regmap_update_bits(regmap, NAU8825_REG_HSD_CTRL, > + NAU8825_HSD_AUTO_MODE | NAU8825_SPKR_DWN1R | > + NAU8825_SPKR_DWN1L, 0); This looks like a separate change to support disabling jack detect which should be in a separate commit. > + return 0; > + } > /* Ground HP Outputs[1:0], needed for headset auto detection Should really be a blank line here. --iZzbKOFQQ2wp/57I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmF2n+8ACgkQJNaLcl1U h9BRswgAgunSlEDrFtpQ17tteZgjhyzOntQeNGNh132EScXSDHNDpPYaK8aWEA47 UezsFkan8LC1H0UsRbX7szsokNjlVfwck55IuXXhWGQxYzjU/IjROikrdfC9bH7J ZA2oQMA8sj7tVqGiKmwUy4ujTf42b0nZOC/8u9eMIH5vshu9IszBIRFjTz+CJjAQ ctNJmvkddM5X0NUc3QjigA6WNdjf/65qIjCGDKLwKhZadRCgQ7TuQix98/EBnKyZ Wb5M3hqdNxDZc2h4O1Rw2IsBKFLssPBhYiBS+WPvJdG8g8MuM6tMNfrYB4FZlSjr rFBKvigP4FVIDiJXgI7LsTTw+su4kw== =l5Ee -----END PGP SIGNATURE----- --iZzbKOFQQ2wp/57I--