All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: David Lin <CTLIN0@nuvoton.com>
Cc: alsa-devel@alsa-project.org, WTLI@nuvoton.com,
	SJLIN0@nuvoton.com, KCHSU0@nuvoton.com, lgirdwood@gmail.com,
	YHCHuang@nuvoton.com, mac.chiang@intel.com
Subject: Re: [PATCH 1/2] ASoC: nau8825: add set_jack coponment support
Date: Mon, 25 Oct 2021 13:26:29 +0100	[thread overview]
Message-ID: <YXaidVceACviFFob@sirena.org.uk> (raw)
In-Reply-To: <20211025113857.3860951-2-CTLIN0@nuvoton.com>

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

On Mon, Oct 25, 2021 at 07:38:57PM +0800, David Lin wrote:
> Use set_jack ops to set jack for new machine drivers. Meanwhile,
> the old machine drivers can still call previous export function
> "nau8825_enable_jack_detect".
> 
> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
> ---

One other thing, sorry - your signoff should generally come last.  If
Mac wrote this then the commit should say it comes from them, if you
worked on it together then Co-developed-by is usually used.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-10-25 12:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 11:38 [PATCH 0/2] Make genaral and simple for new sof machine driver David Lin
2021-10-25 11:38 ` [PATCH 1/2] ASoC: nau8825: add set_jack coponment support David Lin
2021-10-25 12:15   ` Mark Brown
2021-10-26  8:19     ` AS50 CTLin0
2021-10-25 12:26   ` Mark Brown [this message]
2021-10-26  8:25     ` AS50 CTLin0
2021-10-25 11:38 ` [PATCH 2/2] ASoC: nau8825: add clock management for power saving David Lin
2021-10-27 17:29 ` [PATCH 0/2] Make genaral and simple for new sof machine driver Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXaidVceACviFFob@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=CTLIN0@nuvoton.com \
    --cc=KCHSU0@nuvoton.com \
    --cc=SJLIN0@nuvoton.com \
    --cc=WTLI@nuvoton.com \
    --cc=YHCHuang@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=mac.chiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.