From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C245C433F5 for ; Wed, 27 Oct 2021 07:38:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 894E360F0F for ; Wed, 27 Oct 2021 07:38:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 894E360F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 94DBF80F5F; Wed, 27 Oct 2021 09:37:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="OZc330ZM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5B46980F5F; Wed, 27 Oct 2021 09:37:57 +0200 (CEST) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C896980D28 for ; Wed, 27 Oct 2021 09:37:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x335.google.com with SMTP id 136-20020a1c008e000000b0032ccae3b331so1565824wma.0 for ; Wed, 27 Oct 2021 00:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MiuL3or/OoLv8ILfxk22nUe4gS9IkfEneLntKy2eoSY=; b=OZc330ZMuHvKCYmAa5GEYl+IFQ7NRfBX+rD9tsNHOIGf2pzRivL1qVc+wm85+WS6rn LEjJS8BnDeCswAvnc8v3VKElfOqbGPC3JOv45oqyPHq/f+tvOxNvodlYoTalvhjRsXGz mWy5P/BHQdVncfntTSnJztln/7emToysHIIruf++LQbAf9ihPgKIvxSSh+s52L8HFr5s tnlCktyhGPScdt1rJ2H5F7DaA4482Y2nh/qnrn4gd/P+9KoZMlXPtFA8EjglJPfKh/Yn /Ro8zbHicBKOyHcJXAt9DATYNnYp/CoQBFBBcAzJRPlbOfg7mK/pLO2Z+zpl7oM3ZuEJ zxiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MiuL3or/OoLv8ILfxk22nUe4gS9IkfEneLntKy2eoSY=; b=7jQYNSdwBR36bHUVvt1kuC5kIWlS7gBpDFpEMgOSWDl1QzIUslK5WpFiBCfbEANigl yblI3BjgzB7E5u3X6YUXJxL7pZtTKFhQvZeEaMDCqZfl64RG+ffnwWvhgJ1poQc8qPRN cyiy5NIhQg3qkKmmm7OY2GrGVLUNMUDJ3Y+ppkkIsZ7ziEGK1sLpL0xZWU+q754/VjD/ Mo1YU+WrYDJ5QB7dSvnwZj+Qf4UcSZVaMrL+XTU9L/Qpbl7S6w6JIZbpV3XKFrzfD3Nl cQZqq9RlkIGIyTnifXYAEXYGQ7ZUh0C3LCTGMcDAtia/8pDntmxxfGF2N5Xy5Kd/xUgH DrQg== X-Gm-Message-State: AOAM532DA3maHmcDDoTmDt5pxrSIAd1/TiQW858mjPrdstbEFGAo+feg DKTtnuO+eSEG/63WNRPHgXU6kg== X-Google-Smtp-Source: ABdhPJzsLxCrqshR5Ay8r3oa45C2iU3JP0LA6IIGiNhUYD23FRhhBMxsiLQbva+yCuxRQ15HCDrZ1w== X-Received: by 2002:a7b:ce19:: with SMTP id m25mr4142820wmc.134.1635320273313; Wed, 27 Oct 2021 00:37:53 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-13.home.otenet.gr. [94.66.220.13]) by smtp.gmail.com with ESMTPSA id q18sm2693405wmc.7.2021.10.27.00.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 00:37:52 -0700 (PDT) Date: Wed, 27 Oct 2021 10:37:50 +0300 From: Ilias Apalodimas To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , Heinrich Schuchardt , Tom Rini , Daniel Schwierzeck , Steffen Jaeckel , Marek =?iso-8859-1?Q?Beh=FAn?= , Lukas Auer , Dennis Gilmore Subject: Re: [PATCH v2 23/41] bootstd: Add support for bootflows Message-ID: References: <20211023232635.9195-1-sjg@chromium.org> <20211023232635.9195-20-sjg@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211023232635.9195-20-sjg@chromium.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, > + [...] > +/* error codes used to signal running out of things */ > +enum { > + BF_NO_MORE_PARTS = -ESHUTDOWN, > + BF_NO_MORE_DEVICES = -ENODEV, > +}; > + > +static const char *const bootflow_state[BOOTFLOWST_COUNT] = { > + "base", > + "media", > + "part", > + "fs", > + "file", > + "ready", I can understand 'ready' as a boot state. What are the rest supposed to be ? > +}; > + > +const char *bootflow_state_get_name(enum bootflow_state_t state) > +{ > + if (state < 0 || state >= BOOTFLOWST_COUNT) > + return "?"; s/?/Unknown/ or invalid maybe? > + > + return bootflow_state[state]; > +} > + > +int bootflow_first_glob(struct bootflow **bflowp) > +{ > + struct bootstd_priv *std; [...] Regards /Ilias