From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D1EC433EF for ; Wed, 27 Oct 2021 07:45:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27D38610A4 for ; Wed, 27 Oct 2021 07:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240613AbhJ0HsL (ORCPT ); Wed, 27 Oct 2021 03:48:11 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:39675 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240609AbhJ0HsK (ORCPT ); Wed, 27 Oct 2021 03:48:10 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 32ACF580464; Wed, 27 Oct 2021 03:45:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 27 Oct 2021 03:45:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DkDJ3l cmtZdA72BLSb8N8otaG02Ed1Gxqos8Wk9KsPg=; b=ijRR+n1s4F6t5e95Ax6RJJ Jv6p4CsvNjBHu2bIftVSjv91XHdnAFCieh3IqPbRzqj5ASYW3kYO5EdwTnWafkCC PF+8lrGQHLClbUqRfgO+DEQtPJiVGsBcLifPSQnHGD0jHH+C1idFFMiCctWJtElf VaaWvwCzyOfErzRd1sXYzoPuvsjwchHApemfw+/NtBmXYNYiNyzTbL2wN2S1I8M0 f079vSrx/bt8faCkJV0T50I5j16Ugwe6NMK1FuYDqXjKcX6XN9wc1U5ThUarkYms 6cegerJSOONvBdI4MslIL8Mmzb3r/O9PzkU2/lIjthur3XFvq4OKhodAID8IVmBQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefledguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudeh leetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 03:45:44 -0400 (EDT) Date: Wed, 27 Oct 2021 10:45:42 +0300 From: Ido Schimmel To: Vladimir Oltean Cc: netdev@vger.kernel.org, Ido Schimmel , Jakub Kicinski , "David S. Miller" , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Florian Fainelli , Vivien Didelot , Vladimir Oltean , Jiri Pirko Subject: Re: [PATCH net-next 1/8] net: bridge: remove fdb_notify forward declaration Message-ID: References: <20211026142743.1298877-1-vladimir.oltean@nxp.com> <20211026142743.1298877-2-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211026142743.1298877-2-vladimir.oltean@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 26, 2021 at 05:27:36PM +0300, Vladimir Oltean wrote: > fdb_notify() has a forward declaration because its first caller, > fdb_delete(), is declared before 3 functions that fdb_notify() needs: > fdb_to_nud(), fdb_fill_info() and fdb_nlmsg_size(). > > This patch moves the aforementioned 4 functions above fdb_delete() and > deletes the forward declaration. > > Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel