From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3AEC433F5 for ; Wed, 27 Oct 2021 08:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE48561075 for ; Wed, 27 Oct 2021 08:05:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236073AbhJ0IHj (ORCPT ); Wed, 27 Oct 2021 04:07:39 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:52177 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234508AbhJ0IHi (ORCPT ); Wed, 27 Oct 2021 04:07:38 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 2468D58047F; Wed, 27 Oct 2021 04:05:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 27 Oct 2021 04:05:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7RHCmL itQyq7XByE8Hq1LG9ZsvriMgZ5rMzG2FR7UcQ=; b=To2jZx9z3vScULwaZ+ZhdZ 2xO4x+YRNEDUYgMLRJKNBRoaclo65orPKe+FamAxmxVqGYUuv9tq4H8Jqea6BtcC Mb4TWllUG9kzO9oVttxAB0qmYBfeoZ+ZUaHTHm4AKVWmrBhKGQSzQAVko86gnAsd SUdFRgOqKUvxBmcm8tWbiblQTPFa0TJku20E/KbuGIipCnfJLV4pvHScupKWYXrB CQOPMDJojWEHxmzJZgxIsWsvmxeU/WN0nNwNuRXUDAmqm1UOmZszSQjDQYIEqhRy kkz3KILxTpvfEKW2LeqeJ31xWoUf0/+SAkvC4TDimzcwKtkh3exolrczzJ6UO62A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefledguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudeh leetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 04:05:11 -0400 (EDT) Date: Wed, 27 Oct 2021 11:05:09 +0300 From: Ido Schimmel To: Vladimir Oltean Cc: netdev@vger.kernel.org, Ido Schimmel , Jakub Kicinski , "David S. Miller" , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Florian Fainelli , Vivien Didelot , Vladimir Oltean , Jiri Pirko Subject: Re: [PATCH net-next 5/8] net: bridge: reduce indentation level in fdb_create Message-ID: References: <20211026142743.1298877-1-vladimir.oltean@nxp.com> <20211026142743.1298877-6-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211026142743.1298877-6-vladimir.oltean@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 26, 2021 at 05:27:40PM +0300, Vladimir Oltean wrote: > We can express the same logic without an "if" condition as big as the > function, just return early if the kmem_cache_alloc() call fails. > > Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel