From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA7AC433F5 for ; Wed, 27 Oct 2021 10:01:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 732C8610A0 for ; Wed, 27 Oct 2021 10:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 732C8610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3FxmC6YnD7MvtDfyEO12zV4Ei4TwGb4r6ZYqnRarzAc=; b=dgW3HTm5SR0x2q Z8hLNI8uU0lgdI2DvGeyczv+xnWmcRsip+TkLJ8Y2DDSIrA6Rq2587bx31Tu8If2frr4crBQQQhNp sAJCoFmUCpNujWUkso0Ohtx4eRwRrM6fb6p0adpXg8qO7p9Rl3AjT3MlE/BAc7akqYX3G24l6FtqD p78HB6D3PHAzQJw8OsIbrEHHoO0VDLdyzsAb8Eno2IebKds6OQw7fS4CJSldhG0O0h4fkP9XwK9jT WrEVK/8VwEIKLJdKgAUux6LL+8u+T/i7uQvfyT3Q3eSRadmS9eSRRXi+OTVlbPGu8Gy1I5RnIK16H Aqed6t4uxZy4f7csNc3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffjN-004WdK-GA; Wed, 27 Oct 2021 10:00:25 +0000 Received: from mail-ed1-f51.google.com ([209.85.208.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffjJ-004WbX-Jv; Wed, 27 Oct 2021 10:00:22 +0000 Received: by mail-ed1-f51.google.com with SMTP id w12so8221860edd.11; Wed, 27 Oct 2021 03:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EsemFH0tETj3VZTrSmHxIMsN9NPXwXnYtpYm6mXI1Tk=; b=U50MYdImXnNfXlfWaEBelPnrXGFdug1IpBGtj7w2suctu4YWo5932POaqpDb8iZq8B 7vJuyFYpAeLd+EdRGD3xoNI0gPPj2qxuXn12pjTzaKBDM3G5fIK8BfgqFwRE7BpsCt2s dutLMPNYKaktnmQNKQkdIcjlJ1747YXiuP4WUuhBtUFvJqZyj90pWi96o4AN3+yYoqfu B0m/6cXa21ICTmy6bCIcHEVQOQ+yZvnf+oge/PcsEqd836pO5NTOUySQKx9m7e8+YZIe RYqHrvtFPTL4uBjugDekWJyMlLZIu5bb8ivDsLCcbpNJoxDo0NemKZMRiUVXbZvzZ9Aj lh+A== X-Gm-Message-State: AOAM5317c06cXwAWybuu0sNnWdBsR1t3d9phebP/fmdJosDayae1gNQj xRqRyjBX4ydbatMpldYqiHs= X-Google-Smtp-Source: ABdhPJwWFV7VmfT7RFLcWceqEPwWUqlkhVXAffxqOWvA+FVbvR+fUfPgg8451eo1WEr35K0YegqIOw== X-Received: by 2002:a17:906:4f8c:: with SMTP id o12mr37456066eju.115.1635328817804; Wed, 27 Oct 2021 03:00:17 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id r5sm8427743edy.86.2021.10.27.03.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 03:00:17 -0700 (PDT) Date: Wed, 27 Oct 2021 12:00:16 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Andy Shevchenko Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas Subject: Re: [PATCH v1 1/1] PCI: brcmstb: Use GENMASK() as __GENMASK() is for internal use only Message-ID: References: <20211027093433.4832-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211027093433.4832-1-andriy.shevchenko@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_030021_684340_4ED36142 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQW5keSwKCj4gVXNlIEdFTk1BU0soKSBhcyBfX0dFTk1BU0soKSBpcyBmb3IgaW50ZXJuYWwg dXNlIG9ubHkuCgpUbyBhZGQsIGZvciBwb3N0ZXJpdHksIHRoYXQgdXNpbmcgX19HRU5NQVNLKCkg YnlwYXNzZXMgdGhlIApHRU5NQVNLX0lOUFVUX0NIRUNLKCkgbWFjcm8gdGhhdCBhZGRzIGV4dHJh IHZhbGlkYXRpb24uCgo+IEZpeGVzOiAzYmFlYzY4NGE1MzEgKCJQQ0k6IGJyY21zdGI6IEFjY29t bW9kYXRlIE1TSSBmb3Igb2xkZXIgY2hpcHMiKQo+IFNpZ25lZC1vZmYtYnk6IEFuZHkgU2hldmNo ZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L3BjaS9jb250cm9sbGVyL3BjaWUtYnJjbXN0Yi5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9w Y2kvY29udHJvbGxlci9wY2llLWJyY21zdGIuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNp ZS1icmNtc3RiLmMKPiBpbmRleCAxZmM3YmQ0OWE3YWQuLjUxNTIyNTEwYzA4YyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaWUtYnJjbXN0Yi5jCj4gKysrIGIvZHJpdmVy cy9wY2kvY29udHJvbGxlci9wY2llLWJyY21zdGIuYwo+IEBAIC02MTksNyArNjE5LDcgQEAgc3Rh dGljIHZvaWQgYnJjbV9tc2lfcmVtb3ZlKHN0cnVjdCBicmNtX3BjaWUgKnBjaWUpCj4gIAo+ICBz dGF0aWMgdm9pZCBicmNtX21zaV9zZXRfcmVncyhzdHJ1Y3QgYnJjbV9tc2kgKm1zaSkKPiAgewo+ IC0JdTMyIHZhbCA9IF9fR0VOTUFTSygzMSwgbXNpLT5sZWdhY3lfc2hpZnQpOwo+ICsJdTMyIHZh bCA9IEdFTk1BU0soMzEsIG1zaS0+bGVnYWN5X3NoaWZ0KTsKClRoYW5rIHlvdSEKClJldmlld2Vk LWJ5OiBLcnp5c3p0b2YgV2lsY3p5xYRza2kgPGt3QGxpbnV4LmNvbT4KCglLcnp5c3p0b2YKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385ABC433EF for ; Wed, 27 Oct 2021 10:02:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1541360FBF for ; Wed, 27 Oct 2021 10:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239425AbhJ0KFO (ORCPT ); Wed, 27 Oct 2021 06:05:14 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:34734 "EHLO mail-ed1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241322AbhJ0KCo (ORCPT ); Wed, 27 Oct 2021 06:02:44 -0400 Received: by mail-ed1-f54.google.com with SMTP id g10so8421755edj.1; Wed, 27 Oct 2021 03:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EsemFH0tETj3VZTrSmHxIMsN9NPXwXnYtpYm6mXI1Tk=; b=OVrPHfz2U5JUp+QiwRAYIE7397KhB7YycXt+DXvYe4JcjhzXsFHE5CrXDeDHIuuD1M dEIkXjamD6BAgkr9Greu77ateYlJXmZPLyGqYey4pUhZ6oxyqZS455lzsSgVPDu+r9Lt EEDKloMTpBgKGUhCEcuOgsByPOODZ9V4RYYGrgIcHKb/SljzqPRmtEtLQ1Xyg7wX1dBW /mKgxkASIqjR8tzD30QERKId11vrnyQz6OhtJnjQT4JOnrWEEf2ctuGUfP+vzi/akV1H lNMHLkoGh9IgVbL7vKBmFCikA106YeF/RhCfVd7jrU3RxIHxybBFjq/af9RtMzOfRr4A O+bg== X-Gm-Message-State: AOAM532uomeSp4FOEndF14s9/JG028M4bvTGvS6Jp6x/idPuBAUxwnzv s/ssHihUzfaa4uIF6CCknnUmM6zLjdiJgw== X-Google-Smtp-Source: ABdhPJwWFV7VmfT7RFLcWceqEPwWUqlkhVXAffxqOWvA+FVbvR+fUfPgg8451eo1WEr35K0YegqIOw== X-Received: by 2002:a17:906:4f8c:: with SMTP id o12mr37456066eju.115.1635328817804; Wed, 27 Oct 2021 03:00:17 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id r5sm8427743edy.86.2021.10.27.03.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 03:00:17 -0700 (PDT) Date: Wed, 27 Oct 2021 12:00:16 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Andy Shevchenko Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas Subject: Re: [PATCH v1 1/1] PCI: brcmstb: Use GENMASK() as __GENMASK() is for internal use only Message-ID: References: <20211027093433.4832-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211027093433.4832-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, > Use GENMASK() as __GENMASK() is for internal use only. To add, for posterity, that using __GENMASK() bypasses the GENMASK_INPUT_CHECK() macro that adds extra validation. > Fixes: 3baec684a531 ("PCI: brcmstb: Accommodate MSI for older chips") > Signed-off-by: Andy Shevchenko > --- > drivers/pci/controller/pcie-brcmstb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 1fc7bd49a7ad..51522510c08c 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -619,7 +619,7 @@ static void brcm_msi_remove(struct brcm_pcie *pcie) > > static void brcm_msi_set_regs(struct brcm_msi *msi) > { > - u32 val = __GENMASK(31, msi->legacy_shift); > + u32 val = GENMASK(31, msi->legacy_shift); Thank you! Reviewed-by: Krzysztof Wilczyński Krzysztof