From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 615A7C433EF for ; Wed, 27 Oct 2021 10:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 414B56103C for ; Wed, 27 Oct 2021 10:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239299AbhJ0KaL (ORCPT ); Wed, 27 Oct 2021 06:30:11 -0400 Received: from mga05.intel.com ([192.55.52.43]:4474 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbhJ0KaH (ORCPT ); Wed, 27 Oct 2021 06:30:07 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="316334146" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="316334146" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 03:27:42 -0700 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="597312127" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 03:27:39 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mfg9P-001R57-CT; Wed, 27 Oct 2021 13:27:19 +0300 Date: Wed, 27 Oct 2021 13:27:19 +0300 From: Andy Shevchenko To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas Subject: Re: [PATCH v1 1/1] PCI: brcmstb: Use GENMASK() as __GENMASK() is for internal use only Message-ID: References: <20211027093433.4832-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 27, 2021 at 12:00:16PM +0200, Krzysztof Wilczyński wrote: > > Use GENMASK() as __GENMASK() is for internal use only. > > To add, for posterity, that using __GENMASK() bypasses the > GENMASK_INPUT_CHECK() macro that adds extra validation. In general, yes, but here we have a variable... > > - u32 val = __GENMASK(31, msi->legacy_shift); > > + u32 val = GENMASK(31, msi->legacy_shift); ...which make me thing that the whole construction is ugly (and I truly believe the code is very ugly here, because the idea behind GENMASK() is to be used with constants). So, what about u32 val = ~(BIT(msi->legacy_shift) - 1); instead? > Thank you! > > Reviewed-by: Krzysztof Wilczyński Thank you! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F37F4C433F5 for ; Wed, 27 Oct 2021 10:29:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B612660F39 for ; Wed, 27 Oct 2021 10:29:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B612660F39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JWoxliuUuO6lJEjQgeT0YGvRl5/WQF2PXNYPrPyHv70=; b=nVJtHdi6Kokpo3 fO9TlJcaGIAw6lFrdi2ZCfcMoUycUMA6cOGJOVCxN5IhqCiczxDqV/vaZJ8VBBezunDd1ZMfCpmUx PowoEIfYaGW3cIBa9w4xjHxsBweBt4+cgVwc6YZ+19ELTIfIZd7qO77nTSIut3gex1J6SxWraCWGb Z4VgVanC6sL9y3iHh28rE42QksNSanLAtt+2Wn6FimcObTzm+e2SHIng7LLkokO38bVbfAYIlv9Lx Qu9aBpXb/TLgshDIS+ZXnsM85vkYPhI5rS8hNBNIqqLUyW3BZBJQSbQxqmpNGuBV2wuNmayFm35Pe WK5anThB/9YHTgD1RjrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfg9s-004Ylk-A5; Wed, 27 Oct 2021 10:27:48 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfg9o-004Yl7-AO; Wed, 27 Oct 2021 10:27:45 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="228881648" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="228881648" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 03:27:42 -0700 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="597312127" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 03:27:39 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mfg9P-001R57-CT; Wed, 27 Oct 2021 13:27:19 +0300 Date: Wed, 27 Oct 2021 13:27:19 +0300 From: Andy Shevchenko To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne , Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas Subject: Re: [PATCH v1 1/1] PCI: brcmstb: Use GENMASK() as __GENMASK() is for internal use only Message-ID: References: <20211027093433.4832-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_032744_396436_7A853FF9 X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMjcsIDIwMjEgYXQgMTI6MDA6MTZQTSArMDIwMCwgS3J6eXN6dG9mIFdpbGN6 ecWEc2tpIHdyb3RlOgo+ID4gVXNlIEdFTk1BU0soKSBhcyBfX0dFTk1BU0soKSBpcyBmb3IgaW50 ZXJuYWwgdXNlIG9ubHkuCj4gCj4gVG8gYWRkLCBmb3IgcG9zdGVyaXR5LCB0aGF0IHVzaW5nIF9f R0VOTUFTSygpIGJ5cGFzc2VzIHRoZQo+IEdFTk1BU0tfSU5QVVRfQ0hFQ0soKSBtYWNybyB0aGF0 IGFkZHMgZXh0cmEgdmFsaWRhdGlvbi4KCkluIGdlbmVyYWwsIHllcywgYnV0IGhlcmUgd2UgaGF2 ZSBhIHZhcmlhYmxlLi4uCgo+ID4gLQl1MzIgdmFsID0gX19HRU5NQVNLKDMxLCBtc2ktPmxlZ2Fj eV9zaGlmdCk7Cj4gPiArCXUzMiB2YWwgPSBHRU5NQVNLKDMxLCBtc2ktPmxlZ2FjeV9zaGlmdCk7 CgouLi53aGljaCBtYWtlIG1lIHRoaW5nIHRoYXQgdGhlIHdob2xlIGNvbnN0cnVjdGlvbiBpcyB1 Z2x5CihhbmQgSSB0cnVseSBiZWxpZXZlIHRoZSBjb2RlIGlzIHZlcnkgdWdseSBoZXJlLCBiZWNh dXNlCiB0aGUgaWRlYSBiZWhpbmQgR0VOTUFTSygpIGlzIHRvIGJlIHVzZWQgd2l0aCBjb25zdGFu dHMpLgoKU28sIHdoYXQgYWJvdXQKCgl1MzIgdmFsID0gfihCSVQobXNpLT5sZWdhY3lfc2hpZnQp IC0gMSk7CgppbnN0ZWFkPwoKPiBUaGFuayB5b3UhCj4gCj4gUmV2aWV3ZWQtYnk6IEtyenlzenRv ZiBXaWxjennFhHNraSA8a3dAbGludXguY29tPgoKVGhhbmsgeW91IQoKLS0gCldpdGggQmVzdCBS ZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=